From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43463C433EF for ; Tue, 26 Oct 2021 11:44:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44E2460C41 for ; Tue, 26 Oct 2021 11:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 44E2460C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 18BE8833B1; Tue, 26 Oct 2021 13:44:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="d0/hKrCF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8358583569; Tue, 26 Oct 2021 07:58:41 +0200 (CEST) Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9557F83538 for ; Tue, 26 Oct 2021 07:58:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-yb1-xb30.google.com with SMTP id i65so31249426ybb.2 for ; Mon, 25 Oct 2021 22:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+YKUal6iG9NSHTbWImghg1rg994lb0uA3AdV8hWqe84=; b=d0/hKrCFY95KArStBf7Ruf++SccxC31Oec2zE15mHQsvLMcCDlvuvut+STEsP4sdCn M6e6X8iR8KJKqM21HhCr71Y6EkXuA2siu6mcF+I5G6HG9wxYXL1+RtIFpLe52s0afEhV cuR0Zzgsb3QakBhPrHM1S1lSyDxAtOe4TNJK0RyhR3PzhchuhDyFQyklM3XwW380avrd rudSo1PzC1UwJQQ8612gruhQ9pnq9NCcBSu5RQFtaFaOGFv97r0+dk6HXAD/dh2uyig3 RTfIJROchI0EcmptH9O69zTzrO3AYDSwuOKSj+duhWNMUiX4mojdiGBvYAYxCgcg8+nS Jgkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+YKUal6iG9NSHTbWImghg1rg994lb0uA3AdV8hWqe84=; b=eCA0MIBmejbgF5Ttg04bi8iOUBeviixXRwb36bqwYXaS354AoRFYvtIAKysml6KIYr 8bi0djug+Z/G0XAW6ytvXZnSGXA/Mc3bQ9NaTyaS2IvAbOrXGAW8m60mLfDiHQoM7JBy bzHo6li8r+N9kwbz+NR5tp1t/lqNgUKLwqmPnRU51HM0vrx6OO1fHHp1NN0C8drItiki HOyZBfmKroYEYJCAcFrdZZZRfczd1WxM/jjgHS0AOVIBPcUj9LGbEB+axZ8ZcqFohMt0 u1avI2DQl05E0VUzQb+JJ9BZtx3pgspfEeJVxOayZAX6JxKIq/oTQfayGC1ZDGTNSUo3 SIJw== X-Gm-Message-State: AOAM532irXSKPsw/z5q62mF7dxq0zxwPB74TT3Y9+v7ZyyimVYWYR2Ex 3QTP0TL4oQNwU+25Dn34lejZj1k6/KX+r8KIEyvdxA== X-Google-Smtp-Source: ABdhPJwJCGQ3fGoT1uPPHjPzpvuVx5wsIjT2fjRAB1h+z0U36/I4aUSI+vVFTKTT+tEJiimJVPaeBqYAzktp7BMEmsA= X-Received: by 2002:a25:d3cc:: with SMTP id e195mr24375594ybf.410.1635227915247; Mon, 25 Oct 2021 22:58:35 -0700 (PDT) MIME-Version: 1.0 References: <20211019130725.171193-1-ilias.apalodimas@linaro.org> <20211025211713.GA1992726@bill-the-cat> In-Reply-To: <20211025211713.GA1992726@bill-the-cat> From: Ilias Apalodimas Date: Tue, 26 Oct 2021 08:57:59 +0300 Message-ID: Subject: Re: [PATCH v4] sandbox: Remove OF_HOSTFILE To: Tom Rini Cc: sjg@chromium.org, Patrick Delaunay , Patrice Chotard , Liviu Dudau , Thomas Fitzsimmons , Matthias Brugger , Michal Simek , =?UTF-8?Q?Pali_Roh=C3=A1r?= , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Bin Meng , Heinrich Schuchardt , Stefan Roese , Tim Harvey , Harald Seiler , Sughosh Ganu , Priyanka Jain , Vladimir Oltean , Andre Przywara , Ramon Fried , Nicolas Saenz Julienne , Peter Robinson , "Ivan T. Ivanov" , Marek Szyprowski , Zong Li , Leo Yu-Chi Liang , Sean Anderson , Rick Chen , Green Wan , T Karthik Reddy , Ashok Reddy Soma , Rasmus Villemoes , Alper Nebi Yasak , AKASHI Takahiro , Wasim Khan , Alexandru Gagniuc , Nandor Han , Pratyush Yadav , Steffen Jaeckel , Heiko Schocher , Asherah Connor , u-boot@lists.denx.de, uboot-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 26 Oct 2021 13:44:22 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 26 Oct 2021 at 00:17, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 04:07:21PM +0300, Ilias Apalodimas wrote: > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > unique and not causing any confusions, we are better of having simpler > > config options for the DTB. > > > > So let's replace that with the existing OF_BOARD. U-Boot would then > > have only three config options for the DTB origin. > > - OF_SEPARATE, build separately from U-Boot > > - OF_BOARD, board specific way of providing the DTB > > - OF_EMBED embedded in the u-boot binary(should not be used in production > > > > Signed-off-by: Ilias Apalodimas > > Reviewed-by: Simon Glass > > > This doesn't build on riscv: > +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c:57:7: error: conflicting types for 'board_fdt_blob_setup'; have 'void *(void)' > +(ae350_rv64) 57 | void *board_fdt_blob_setup(void) > +(ae350_rv64) | ^~~~~~~~~~~~~~~~~~~~ > +(ae350_rv64) In file included from include/asm-generic/global_data.h:23, > +(ae350_rv64) from arch/riscv/include/asm/global_data.h:35, > +(ae350_rv64) from include/init.h:21, > +(ae350_rv64) from board/AndesTech/ax25-ae350/ax25-ae350.c:10: > +(ae350_rv64) include/fdtdec.h:1164:7: note: previous declaration of 'board_fdt_blob_setup' with type 'void *(int *)' > +(ae350_rv64) 1164 | void *board_fdt_blob_setup(int *err); > +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c: In function 'board_fdt_blob_setup': > +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c:59:10: error: 'err' undeclared (first use in this function); did you mean 'errno'? > +(ae350_rv64) 59 | *err = 0; > +(ae350_rv64) | ^~~ > +(ae350_rv64) | errno > +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c:59:10: note: each undeclared identifier is reported only once for each function it appears in > +(ae350_rv64) make[2]: *** [scripts/Makefile.build:254: board/AndesTech/ax25-ae350/ax25-ae350.o] Error 1 > +(ae350_rv64) make[1]: *** [Makefile:1801: board/AndesTech/ax25-ae350] Error 2 > +(ae350_rv64) make: *** [Makefile:177: sub-make] Error 2 Yea I somehow managed to mess up my merges. Apologies for the noise, I'll send a v5 Cheers /Ilias > > -- > Tom