From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E574C433EF for ; Fri, 7 Jan 2022 12:39:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 071CE83662; Fri, 7 Jan 2022 13:39:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="AeSGbS5z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 795D0836C5; Fri, 7 Jan 2022 13:39:38 +0100 (CET) Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A908483510 for ; Fri, 7 Jan 2022 13:39:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-yb1-xb2b.google.com with SMTP id y130so16357894ybe.8 for ; Fri, 07 Jan 2022 04:39:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SW1ExKwAomXvY7rfXl0eubd2HB9UMTe4sdI8XBXQ/kE=; b=AeSGbS5zdJsOnl7HFkmCqghUNbnO7k14UusHNCol+Lxk2gIuqX1sxTB0yADf0Rgt3A csmAXMaRthd78GOAiK2VnhLwM/4+PFHeHVzkRoe1Af1c5wsa11gIMVStjsQEx51GikTm 64O/Y/6fin35o6PUXiDdU/RHetkg5Xc6j6nDbrTzRMQbcOZLlvK6tswdHCM8UeMznhtJ sP8/8h3mN34eP33m/w1JAi+38YPyjD3hjEpepJArCD9yXvQwC/mhMmEKRy70JIML2sHn nrmwtHmdb1hGaa69Adniiqnmi6ro8dajrUOgAY00qBkq8n0e28CRwvCnnverrvw+MhLJ C5Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SW1ExKwAomXvY7rfXl0eubd2HB9UMTe4sdI8XBXQ/kE=; b=U7P91Qo/VGHrCbv/R0E5j9B6XoGkb2CebxauDhFT+6qWntHsf1+a3Sk2BLREhXdMXr /bq9Zn3+JNUs0PaoIDAmQJdGFOmoMTTJBvA6MVcVs2a60ESNdbkFo/hvsa26yyS+GxKI 81IgS/MWZexsXT7hR0LEGCr2bFLKtlW6r+wOazCz51NGX+MhCfj8pMJJVSruoQH/e4x0 iSVX7SGT9yTbzC6VE30y1cM69KxoO7QDvCkguausf80T6cVac/lXixbMD668/3RpA28H opgmUtVdcWAu0XLWEMUITZMt8QlU+1OiSv4Ha5YqRCGTk8YVD1CZQp/NvfkX1+Ub6ATk 3khw== X-Gm-Message-State: AOAM530488jHZQx0AmG+sIZJ7nN35jBeWUc0pOAClp9zctK1JCvIKdpe FHMKSMTYh8lkmQ1wwJKgK2q9MutfQIa2zlFH2Jx7Mg== X-Google-Smtp-Source: ABdhPJz+FBXm2M3ZokJrzOfzFTyr7yr78n+6yP5FG5oLNJFQ8X6v3hEJvWKJ6E5LQTCLx2y+ndPxrtdnsp+5DK17qdc= X-Received: by 2002:a25:2a50:: with SMTP id q77mr4009552ybq.426.1641559174268; Fri, 07 Jan 2022 04:39:34 -0800 (PST) MIME-Version: 1.0 References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-10-takahiro.akashi@linaro.org> In-Reply-To: From: Ilias Apalodimas Date: Fri, 7 Jan 2022 14:38:58 +0200 Message-ID: Subject: Re: [RFC v2 09/20] dm: fix an 'undefined' error in some macros To: Simon Glass Cc: AKASHI Takahiro , xypron.glpk@gmx.de, agraf@csgraf.de, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 13 Dec 2021 at 14:51, Simon Glass wrote: > > On Thu, 9 Dec 2021 at 23:58, AKASHI Takahiro wrote: > > > > Due to a non-existing parameter name in macro's, use of those macro's will > > cause a compiler error of "undefined reference". > > Unfortunately, dm test doesn't fail because a wrong name ("&dev", hence it > > is accidentally a valid name in the context of a caller site) is passed on. > > > > Signed-off-by: AKASHI Takahiro > > Fixes: f262d4ca4b2b ("dm: core: Add a way to read platdata for all > > child devices") > > Fixes: 903e83ee8464 ("dm: core: Add a way to iterate through children, > > probing each") > > --- > > include/dm/device.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas