From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Masahisa Kojima <masahisa.kojima@linaro.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Alexander Graf <agraf@csgraf.de>, Simon Glass <sjg@chromium.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 2/3] efi_loader: fix boot_service_capability_min calculation
Date: Fri, 3 Sep 2021 09:19:32 +0300 [thread overview]
Message-ID: <CAC_iWjK5k8P3HxVa9X0ZOgfsW+8n1BsRNFXB5hYBX1ii9gwaRA@mail.gmail.com> (raw)
In-Reply-To: <20210903015552.17180-3-masahisa.kojima@linaro.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
On Fri, 3 Sept 2021 at 04:54, Masahisa Kojima
<masahisa.kojima@linaro.org> wrote:
>
> TCG EFI Protocol Specification requires to the input
> ProtocolCapability.Size < size of the EFI_TCG2_BOOT_SERVICE_CAPABILITY
> up to and including the vendor ID field.
> Current implementation does different calculation, let's fix it.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
> ---
> include/efi_tcg2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/efi_tcg2.h b/include/efi_tcg2.h
> index b6b958da51..45788d55d5 100644
> --- a/include/efi_tcg2.h
> +++ b/include/efi_tcg2.h
> @@ -127,8 +127,8 @@ struct efi_tcg2_boot_service_capability {
> efi_tcg_event_algorithm_bitmap active_pcr_banks;
> };
>
> +/* up to and including the vendor ID(manufacture_id) field */
> #define boot_service_capability_min \
> - sizeof(struct efi_tcg2_boot_service_capability) - \
> offsetof(struct efi_tcg2_boot_service_capability, number_of_pcr_banks)
>
> #define TCG_EFI_SPEC_ID_EVENT_SIGNATURE_03 "Spec ID Event03"
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-09-03 6:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 1:55 [PATCH 0/3] Miscellaneous fixes of efi_tcg2 Masahisa Kojima
2021-09-03 1:55 ` [PATCH 1/3] efi_loader: add missing parameter check for EFI_TCG2_PROTOCOL api Masahisa Kojima
2021-09-03 6:25 ` Ilias Apalodimas
2021-09-03 1:55 ` [PATCH 2/3] efi_loader: fix boot_service_capability_min calculation Masahisa Kojima
2021-09-03 6:19 ` Ilias Apalodimas [this message]
2021-09-03 7:01 ` Heinrich Schuchardt
2021-09-03 7:24 ` Masahisa Kojima
2021-09-03 1:55 ` [PATCH 3/3] efi_loader: fix efi_tcg2_hash_log_extend_event() parameter check Masahisa Kojima
2021-09-03 6:20 ` Ilias Apalodimas
2021-09-03 6:22 ` Heinrich Schuchardt
2021-09-03 6:51 ` Ilias Apalodimas
2021-09-03 7:11 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC_iWjK5k8P3HxVa9X0ZOgfsW+8n1BsRNFXB5hYBX1ii9gwaRA@mail.gmail.com \
--to=ilias.apalodimas@linaro.org \
--cc=agraf@csgraf.de \
--cc=masahisa.kojima@linaro.org \
--cc=sjg@chromium.org \
--cc=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.