From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33FEAC433EF for ; Mon, 1 Nov 2021 06:55:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96A3D60FD9 for ; Mon, 1 Nov 2021 06:55:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 96A3D60FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1E30B8020E; Mon, 1 Nov 2021 07:55:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="aHl3q1HO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5CFD982D85; Mon, 1 Nov 2021 07:55:26 +0100 (CET) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C6502801DD for ; Mon, 1 Nov 2021 07:55:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-yb1-xb2a.google.com with SMTP id s3so8942418ybs.9 for ; Sun, 31 Oct 2021 23:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WUKXdcdEKnKqLMdVHer4001/U2sKv6BiPLXBNHlG9as=; b=aHl3q1HOlzHGc8KDaArqtRa9K5pcGJGLjDl/6j1kgnawU2eOH4jq1zktzh0iQPSJhO C7g0gpSXcm6B1dlWu48eY0SNx5dRVjNOGP2OHlqxgAxf0q47Sg7U+v9SW8qgtxDhLFqe cjMdijFr6FssYwuff4/ZDlhyHMqOpc2Es1ZJrT+bIA2z3ipGXT/9NNBubMo2BpJPlWCQ ryGOJtVWjVs3nbgXevNmiJLpqaicQTQptC46+A/HdIQrYjrHYTNjUBg4UMVDMDn4V6Ys Qr4lJsXL3uu4pSUXZkzIt3RwJhyfAZ7wqiIrFEuusjd9s+qnmaDY7PkkHRl01HPxuZwq OHKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WUKXdcdEKnKqLMdVHer4001/U2sKv6BiPLXBNHlG9as=; b=x4isxxgX/TjKOzqpRrjyn9pWiuRuRoeMBkFEzefS3DLqXOnWJUFzrtMVK8UoQRIVRB Rje4hC/jNJ9cPeI8w3TFbsKSogDiC/30zRRfocgw30DGejGXymQEA9H+V6di+DsBwibg 6w4te+2PyRLsuMbeFWPQYKbrYIfcGEGcEX63VX/xh+BD5rslJKNpx+kZ1y5/Tc7gz5CD DobO5l9sACX1uzAJq3Q/Cv7KS6snkGww3hj1xNXjE571j+j7C27WWmaNSdSH4Z09d4sU zHDxbADYPGCOqPAsUW9+y25yNlvvXxeY8eXTyl8iV/1FHUwDuzzChzl5u8RahHtANoc5 3i1g== X-Gm-Message-State: AOAM533J0t6neplA0ovweoZrtb4eEl1/gGL+/lS8w3ZJB1YISAsZ9tDp kwLkIBo1fVGDfrjRKpwc+t8WMjdUIbTSFlBzdzNbLg== X-Google-Smtp-Source: ABdhPJwxS5LN2uc1ZPTMQtjpU/IyJPY8l3Ut1fQbi2J4rwxR5U4FZj90rtaHaIe8yy01Q5h+U+yJVb6NBoVJpVtup6E= X-Received: by 2002:a25:2f13:: with SMTP id v19mr28879008ybv.410.1635749720161; Sun, 31 Oct 2021 23:55:20 -0700 (PDT) MIME-Version: 1.0 References: <20211101011734.1614781-1-sjg@chromium.org> <20211101011734.1614781-2-sjg@chromium.org> In-Reply-To: <20211101011734.1614781-2-sjg@chromium.org> From: Ilias Apalodimas Date: Mon, 1 Nov 2021 08:54:44 +0200 Message-ID: Subject: Re: [PATCH 01/31] Makefile: Correct TPL rule for OF_REAL To: Simon Glass Cc: U-Boot Mailing List , Tom Rini , Bin Meng , Bill Mills , Heinrich Schuchardt , =?UTF-8?Q?Fran=C3=A7ois_Ozog?= , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, As I expect this series to go through some versions before we agree on something and this seems like a pure bugfix can you split it of as a single patch? On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > Correct an error in the tpl-dtb parameter to binman. At present the TPL > rule follows SPL but this is not correct, if TPL uses of-platdata, for > example. > > Fixes: f99cbe4e867 ("fdt: Update Makefile rules with the new OF_REAL Kconfig") > Signed-off-by: Simon Glass > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 09a5cea8cb8..d256a3cdc33 100644 > --- a/Makefile > +++ b/Makefile > @@ -1309,7 +1309,7 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \ > -a spl-bss-pad=$(if $(CONFIG_SPL_SEPARATE_BSS),,1) \ > -a tpl-bss-pad=$(if $(CONFIG_TPL_SEPARATE_BSS),,1) \ > -a spl-dtb=$(CONFIG_SPL_OF_REAL) \ > - -a tpl-dtb=$(CONFIG_SPL_OF_REAL) \ > + -a tpl-dtb=$(CONFIG_TPL_OF_REAL) \ > $(BINMAN_$(@F)) > > OBJCOPYFLAGS_u-boot.ldr.hex := -I binary -O ihex > -- > 2.33.1.1089.g2158813163f-goog > Reviewed-by: Ilias Apalodimas