From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E303C433FE for ; Thu, 10 Nov 2022 11:44:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CAB6385135; Thu, 10 Nov 2022 12:44:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="EfqOAKvP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6A9CE850A3; Thu, 10 Nov 2022 12:44:41 +0100 (CET) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AE066850A3 for ; Thu, 10 Nov 2022 12:44:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-lf1-x12f.google.com with SMTP id f37so2685993lfv.8 for ; Thu, 10 Nov 2022 03:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WgjX6H7h+Mv6nLiOgQbc9cZyqidmcDUnNoujK74wUXg=; b=EfqOAKvPyKQmdDchO44InjHUzTVfDRMNsg7j51GTxaeTi5qB8E96Gn5kBbqlOMG99O 1YpldN19mx/P21hLHk73sxteiH+N0wjhZoAsxiDFCM9aoAKewKQL1mJz5sRlImw8/wh1 zMQ3/bo2gmIRlN8GHlzpKzsQgBT1eFcTe8X/B1wk5NMEiAIUZpK1cmyxmFShyDbD+t+b qWrbEH5SK69au7vrDcg3Xe41SUxp8ra1O9DslWnhH2UBQebY1WQKG5+/0zfZBA/09eWX h0HHbq7Wg92H2I1bKoP4TFoG+uCkK1+5PdJQYEAslhcXHN/cTUZuBlIR3SW6n8XxxuYC 7yLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WgjX6H7h+Mv6nLiOgQbc9cZyqidmcDUnNoujK74wUXg=; b=Pjc0f+0GQkG6vsPMh1PavJOSQzCM2pLBlT/j9TTveGZdO6YodaQtqDxRgj7ceHNp6H H4D45pteatj2tILx7GAknl5Frq+ku2Rg8E0yhnqSoH+qIMm9NC6puTCPNHabn3Fi9X71 e9vX+1kSMUULOC3sS+YRyVS9wmqsTjNkYpRnkOaOtgVXLFrJYrQI5QcLLDv0VLvk9Bip yV34oaZg0dCcSPC/RyDPDLGR0lnvn+G0gLPQZg9B7pju9hFfDWjdRjJ2AXtwmZxL+uc5 v7hGu3Xl1sLmN/Y8guFE01f7bn4RRH5kADflj7mWoB/pmawRWWppt4qcWBjKKok+knab T2dw== X-Gm-Message-State: ANoB5plKVYyE5NrU/uhZiKPjXPR10Jw8s7yhVRZ/BXo5x1RAUT61EHgV uk5ehIRXFh5NRD5BTFWcEl0CKNyHkt5J0D4NC63OWQ== X-Google-Smtp-Source: AA0mqf5b5dGYiWolNm4Yw2YwWaC6TAz7go0rtQbVrtA057RoyPOaaAHVMgWDNHMJzEwMUUHMDx5XTXEhkYQ40xQTJlI= X-Received: by 2002:a19:2d4e:0:b0:4b4:7490:5f5c with SMTP id t14-20020a192d4e000000b004b474905f5cmr247022lft.501.1668080678054; Thu, 10 Nov 2022 03:44:38 -0800 (PST) MIME-Version: 1.0 References: <20221110113727.861220-1-heinrich.schuchardt@canonical.com> In-Reply-To: <20221110113727.861220-1-heinrich.schuchardt@canonical.com> From: Ilias Apalodimas Date: Thu, 10 Nov 2022 13:44:02 +0200 Message-ID: Subject: Re: [PATCH 1/1] cmd: remove superfluous if in eficonfig_edit_boot_option To: Heinrich Schuchardt Cc: Masahisa Kojima , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thu, 10 Nov 2022 at 13:37, Heinrich Schuchardt wrote: > > Goto for an immediately succeeding label is superfluous. > > Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option") > Addresses-Coverity: 376202 ("Identical code for different branches") > Signed-off-by: Heinrich Schuchardt > --- > cmd/eficonfig.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c > index 2595dd9563..0dc6e7b01e 100644 > --- a/cmd/eficonfig.c > +++ b/cmd/eficonfig.c > @@ -1527,8 +1527,6 @@ static efi_status_t eficonfig_edit_boot_option(u16 *varname, struct eficonfig_bo > } > > ret = eficonfig_set_boot_option(varname, final_dp, final_dp_size, bo->description, tmp); > - if (ret != EFI_SUCCESS) > - goto out; > out: > free(tmp); > free(bo->optional_data); > -- > 2.37.2 > Reviewed-by: Ilias Apalodimas