From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8320AC433EF for ; Sat, 18 Sep 2021 12:23:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D421A6127A for ; Sat, 18 Sep 2021 12:23:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D421A6127A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 826F883224; Sat, 18 Sep 2021 14:23:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="kv7Hw5vj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 16DA78322E; Sat, 18 Sep 2021 14:23:16 +0200 (CEST) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B884682999 for ; Sat, 18 Sep 2021 14:23:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-qk1-x72e.google.com with SMTP id ay33so26124457qkb.10 for ; Sat, 18 Sep 2021 05:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9hSP0NtMl9tXlHtWEGsh0SOT46eKAvpaV4AGKyuP26I=; b=kv7Hw5vjLNKe6fHyHKIyf6nat2jwU3fqNLdjdhWRRe9c5NzEo+RzJufDN7zk3sjmGM iodPSFJ4JdVuZEZZTeRJhtFA+vONy4gvE7A1te4+roZheNf0aIVwsk2YmRZAe+HyXwJA 04g9dm1lr+3QIe2F10f292BJkiRh4Gs1awBY6XTU0q7P5lHOgiXoUiLeay+vjYr+cxc1 Cvahpfuf7pZGgcku5Y6RDweqMCB74lh0H14rpjHtdzN0fxUuFFiiHBkiQwVvwRQURdX4 oIXNlcGhYlpQo2bntVHExG6v2UyDhhC5yWajGio4blY9PWLWWL62s+SSGbmDU67WkXn9 eyqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9hSP0NtMl9tXlHtWEGsh0SOT46eKAvpaV4AGKyuP26I=; b=ZhhUekZeFdrgQQ3a5f7Xq3g0EYvpDsJORyAPZdSBfoW0xFXwoTKUmDhiuyw2+J8rTv GMqXIwMJtfHKPl1Nb7ZA/4fGt1h97kHP00HYTAuki8NgRb8aUWtNRyKBuhE8GJABvjam BSw7y/UxZDfSVaQizveOPvualG9atlK1V89wM1h+n9BdjrYlsb+l8czhQcUTzh6OgvLF y+Ju26hY+pWzJdlgcmNNrAPPMJ17NG+CXKFM7j+7Uh1CtXq618MUBYdqBy5pynnvB1WA FzSVD1jz1BHBU5t3gVK3C4mPWnRjFHG4PleuPkDp35OqF4y8iw+IOV71y8WQicApxWVt 43Jw== X-Gm-Message-State: AOAM533WP7X7ZsOWuezKP/gCFM/gseUjluMS5Ogp4edg4PsDppaqQ+It k9T2bbhZP61VoQxlLTtdv4pgszw6fYgdV0EIKs/yVA== X-Google-Smtp-Source: ABdhPJzuGvHxskH+dmOBAZUJJHfeLe1VftNhlh1NB3Ao9OHrN3h5NmTIsm19w3HsXO+8EffmzFb96nuCaDI7wfZdwws= X-Received: by 2002:a25:2e0f:: with SMTP id u15mr2600329ybu.133.1631967790578; Sat, 18 Sep 2021 05:23:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ilias Apalodimas Date: Sat, 18 Sep 2021 15:22:59 +0300 Message-ID: Subject: Re: Please pull u-boot-dm To: Simon Glass Cc: U-Boot Mailing List , Tom Rini , Heinrich Schuchardt , Mark Kettenis , =?UTF-8?Q?Fran=C3=A7ois_Ozog?= Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon Top posting again apologies. I am fine with whatever really. I've spent more time arguing about it than coding it :) I have worked planned for this and the DM/EFI integration, so I'll update you on the details once we start Cheers Ilias On Sat, 18 Sep 2021, 15:13 Simon Glass, wrote: > Hi Ilias, > > On Sat, 18 Sept 2021 at 05:59, Ilias Apalodimas > wrote: > > > > +cc a few people that had some input on that discussion. > > Apologies from top posting, but I am sending this from a mobile. > > > > I think I've spent enough time trying to explain why I think we don't > need to revert this and why moving the signature to the dtb once we fix it > has minimal effect on the users. > > We could get a patch in the release which makes it clear that the > current approach is temporary only and will change immediately after > the release. But really I don't see any sense in that since it just > confuses people. Better to drop it and get it done for next time. > > > > > Note that the mkeficapsule is completely irrelevant and shouldnt be > reversed anyway but since we have to make changes in documentation etc and > we are close to a release, just keep it in there. > > > > If everyone is convinced that this needs to be reverted I am fine. I'll > just refix all of the platforms(since with this reverted only qemu supports > authenticated capsules) and have a look on the dtb issues. > > Yes and I am very happy to work with you on that. > > Regards, > Simon > > > > > Regards > > Ilias > > > > On Sat, 18 Sep 2021, 14:34 Simon Glass, wrote: > >> > >> Hi Tom, > >> > >> This is a revert of the EFI patches as mentioned on the mailing list. > >> I believe this is the best way forward and avoids the current, flawed > >> approach from getting into an official release and making it difficult > >> to back out. > >> > >> > >> https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/9154 > >> > >> > >> > >> The following changes since commit > d0b8c9a231d6e5fba881960c9fcfcc444f1812f9: > >> > >> Merge branch '2021-09-17-TI-platform-updates' (2021-09-17 18:51:57 > -0400) > >> > >> are available in the Git repository at: > >> > >> git@source.denx.de:u-boot/custodians/u-boot-dm.git > tags/dm-pull-18sep21 > >> > >> for you to fetch changes up to 47a25e81d35c8d801cae9089de90c9ffea083409: > >> > >> Revert "efi_capsule: Move signature from DTB to .rodata" (2021-09-18 > >> 03:47:50 -0600) > >> > >> ---------------------------------------------------------------- > >> Revert the public-key-embedded-in-executable patches so this does not > form > >> part of an official release before it is agreed. > >> > >> ---------------------------------------------------------------- > >> Simon Glass (3): > >> Revert "doc: Update CapsuleUpdate READMEs" > >> Revert "mkeficapsule: Remove dtb related options" > >> Revert "efi_capsule: Move signature from DTB to .rodata" > >> > >> board/emulation/common/Makefile | 1 + > >> doc/develop/uefi/uefi.rst | 124 ------------------------------ > >> include/asm-generic/sections.h | 2 - > >> lib/efi_loader/Kconfig | 7 -- > >> lib/efi_loader/Makefile | 8 -- > >> lib/efi_loader/efi_capsule.c | 18 +---- > >> lib/efi_loader/efi_capsule_key.S | 17 ----- > >> tools/mkeficapsule.c | 229 > >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > >> 8 files changed, 226 insertions(+), 180 deletions(-) > >> delete mode 100644 lib/efi_loader/efi_capsule_key.S > >> > >> > >> Regards, > >> Simon >