From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 964CA746F for ; Wed, 20 Jul 2022 20:08:05 +0000 (UTC) Received: by mail-qv1-f41.google.com with SMTP id j11so614916qvt.10 for ; Wed, 20 Jul 2022 13:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bBt2aXduXrk3yTFTMljU9bjqy/gjhF70VjHkOj8ezJQ=; b=fpOe6RRt86snubDzij/nij4d7nEXqB7gZ5vUfuXDSb4mEXI7wFsTEUnHWkadGGT+SV qS+CfCoE5Ak9EtNzmTrS+G1bH3Ag74/yRC8BQjNdDixQOlm9cufa8URUF5fsbgKUUeKo WDJw+qHQONYANM93QWG1sw9uf+4Rdn1X+Kjg0VMn+KupawJfnkDA0o8lSk+xWs5+PzUm JwcBAeybMS+er8/b3SvFrgoCVIBIw0mlK80q/LlmAd0ULWTRwDSOkKNN0tqZZdGiGt68 Ord3doXJBGbROeZfkwFVjDZhAwsM/enKr7kzThzTHfLsghQ96ifMMzWPIuSxxRMq/kFa DHYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bBt2aXduXrk3yTFTMljU9bjqy/gjhF70VjHkOj8ezJQ=; b=Zyp0ykBMFvQZPVH9D+LOtMYCyXGDyIt/ZUPXBrR9LfUC9uZ9qLyzjRirDEBpzDv3hx uM6X7ndhpKOF1bL+Cd5hkz0dU48mGIMR894wyLPfyM0C167xBzt4nu+lqOPUQa01c+3y mWOeBAzW7BQ5eUJex+hkpx6rInQeoUU/zvxKYlPkOWnqJY/Z9/S5BLZChBUnh5u2fQou OkvFpP0ksj9UOV5VunGw1RbYs0eEgklBiUTBfB4+Vpy/QZg5ZCLgw+mGov2pN+Yt95ch 2H5nLM6Y5Ha6jtoV6pvxIVMjL9mZvmG4zbBOWZEIlUscfY15mG+Qigx+s4J5Z5L4sJ5P rqmA== X-Gm-Message-State: AJIora98PyPGUV9STwYy+VZUlpP3GKt/Fb0x9thIOcg+3sbtGwBrf9w9 eECJalG9lXujYwFzEVhqi1TX3KI1MZMuANeCwdPQpQ== X-Google-Smtp-Source: AGRyM1vyf1j8XqVCErCglA0UEjOSGZrnbuaSbmW1xdUCg7HF23L5loulxZKywUcdPsvfRbBWorrP7qBY6KYLgxte8fk= X-Received: by 2002:a05:6214:761:b0:470:8558:d1c3 with SMTP id f1-20020a056214076100b004708558d1c3mr31210261qvz.107.1658347684520; Wed, 20 Jul 2022 13:08:04 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220719170555.2576993-1-roberto.sassu@huawei.com> <20220719170555.2576993-2-roberto.sassu@huawei.com> In-Reply-To: <20220719170555.2576993-2-roberto.sassu@huawei.com> From: Quentin Monnet Date: Wed, 20 Jul 2022 21:07:53 +0100 Message-ID: Subject: Re: [PATCH 2/4] bpftool: Complete libbfd feature detection To: Roberto Sassu Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , Stanislav Fomichev , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , terrelln@fb.com, Nathan Chancellor , Nick Desaulniers , bpf , "linux-perf-use." , llvm@lists.linux.dev, open list Content-Type: text/plain; charset="UTF-8" On Tue, 19 Jul 2022 at 18:06, Roberto Sassu wrote: > > Commit 6e8ccb4f624a7 ("tools/bpf: properly account for libbfd variations") > sets the linking flags depending on which flavor of the libbfd feature was > detected. > > However, the flavors except libbfd cannot be detected, as they are not in > the feature list. > > Complete the list of features to detect by adding libbfd-liberty and > libbfd-liberty-z. > > Fixes: 6e8ccb4f624a7 ("tools/bpf: properly account for libbfd variations") > Signed-off-by: Roberto Sassu > --- > tools/bpf/bpftool/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile > index 6b5b3a99f79d..4b09a5c3b9f1 100644 > --- a/tools/bpf/bpftool/Makefile > +++ b/tools/bpf/bpftool/Makefile > @@ -93,8 +93,10 @@ INSTALL ?= install > RM ?= rm -f > > FEATURE_USER = .bpftool > -FEATURE_TESTS = libbfd disassembler-four-args libcap clang-bpf-co-re > -FEATURE_DISPLAY = libbfd disassembler-four-args libcap clang-bpf-co-re > +FEATURE_TESTS = libbfd libbfd-liberty libbfd-liberty-z \ > + disassembler-four-args libcap clang-bpf-co-re > +FEATURE_DISPLAY = libbfd libbfd-liberty libbfd-liberty-z \ > + disassembler-four-args libcap clang-bpf-co-re Do you know if there is a way to fold the different feature-libbfd-* features into a single one for FEATURE_DISPLAY? Or should the various features be all moved under feature-libbfd with multiple attempts, like you did for disassembler-four-args in patch 1? My concern is that users may think some features could be missing when they compile and see that detection fails for some items.