From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 513B4C35247 for ; Mon, 3 Feb 2020 18:43:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 269C720CC7 for ; Mon, 3 Feb 2020 18:43:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Yo1y1Xav" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729671AbgBCSnF (ORCPT ); Mon, 3 Feb 2020 13:43:05 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:45822 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728010AbgBCSnE (ORCPT ); Mon, 3 Feb 2020 13:43:04 -0500 Received: by mail-qk1-f193.google.com with SMTP id x1so15238939qkl.12 for ; Mon, 03 Feb 2020 10:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4PMgClN19IhUmet8zzgKP6n4a6viDIBm9kvnRUtH3mA=; b=Yo1y1XavCUEy1wE5P7+cmjzPnnfg1oFVKZVmBL5dtthCguCkZ1WQnpf2YAC7eHPaDm LAIKxbOy+zNgxZgCta9TGT+psszC8jdSUX+mmFt4blUWtcmCkMJVzzsTh65pnXnuuFti F2uSLrsCNrlosOXGbZRwweYEiSo/SJzkncSnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4PMgClN19IhUmet8zzgKP6n4a6viDIBm9kvnRUtH3mA=; b=WkKjYf3rsz4icerT/3LpGC4IorcPMNJlx8U1W3ON2CMkvyQ2Ya83jpFfaMenVEtiH9 3vk8bOsydCFjK/L4F3vT/KTPXaD/5ouN+3nhEPjhxBSVANz8Dvi5XEFvJHKC4zNc9S7R CGjN1Mw1+qDAqeXJ3L0DgpSx2Drzkb9HfCZ4Y9FXTAezqvczmBiOoCTxJNQeNAUh3jfR WZ9rAMdsU4rRBAaR42LPPJfMk4o6BGmvOWYFVvSxZw8TRIrEQ0hGHu1fOezImkrpTkyH vcdH99HTV6YMdM/J5NbLuBywzI1pHWqQe2pOKvNM5Z4JiF9pX72P7VXUYJMpkfcOxigh ST9g== X-Gm-Message-State: APjAAAV1qVtowcHIUqHRKoeqzDQLMfltoes9AgwunnEwEOY++W3xU982 6XUNhpMg+17DWYqM/E7roHG5B+a3ScuUrRLcIb6K2w== X-Google-Smtp-Source: APXvYqw1bX0A3kJ4KvUVv86WXufvnleEdtH4TO5zCbHUJmtjESA5AF1NOa9A9O2Tbs2y01O4QjbPgw6zzCm91hZD6E4= X-Received: by 2002:a05:620a:2218:: with SMTP id m24mr25211961qkh.442.1580755381994; Mon, 03 Feb 2020 10:43:01 -0800 (PST) MIME-Version: 1.0 References: <20200130203106.201894-1-pmalani@chromium.org> <20200130203106.201894-12-pmalani@chromium.org> <20200201110358.GR3897@sirena.org.uk> In-Reply-To: <20200201110358.GR3897@sirena.org.uk> From: Prashant Malani Date: Mon, 3 Feb 2020 10:42:51 -0800 Message-ID: Subject: Re: [PATCH 11/17] ASoC: cros_ec_codec: Use cros_ec_send_cmd_msg() To: Mark Brown Cc: Linux Kernel Mailing List , Cheng-Yi Chiang , Enric Balletbo i Serra , Guenter Roeck , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Benson Leung , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, thanks for looking at the patch. Please see inline. On Sun, Feb 2, 2020 at 4:00 AM Mark Brown wrote: > > On Thu, Jan 30, 2020 at 12:30:56PM -0800, Prashant Malani wrote: > > Replace send_ec_host_command() with cros_ec_send_cmd_msg() which does > > the same thing, but is defined in a common location in platform/chrome > > and exposed for other modules to use. This allows us to remove > > send_ec_host_command() entirely. > > I only have this patch, I've nothing else from the series or a > cover letter. What's the story with dependencies and so on? Sorry about that. I will add you to the cover letter for subsequent versions (I followed https://lwn.net/Articles/585782/ but I think it only adds the relevant mailing lists to the cover letter...) Just for reference, the cover series LKML link is here: https://lkml.org/lkml/2020/1/30/802 Best regards, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF221C35247 for ; Mon, 3 Feb 2020 18:44:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E3FF20721 for ; Mon, 3 Feb 2020 18:44:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="qM9Vh/PQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Yo1y1Xav" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E3FF20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CEC7F86E; Mon, 3 Feb 2020 19:43:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CEC7F86E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580755444; bh=GgVd9AhXft2m41bV3bEXKZUAnTA6uicMBaszaGRkkzE=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qM9Vh/PQTO4ZQRsqzHdeVSyQnDAEB9gYNF+pnrX/RF4dPCivX081ZerKhlCXuXf48 vlIwktNx5suOR1/sj8tHbZKJ1qr+iYmbIEp9ZSvQ7HZP4J8mrcHSo/TcRxrrXilC3x xBCsh7TkaGVL4a+vto2Y7RvAnsKGls/QCm3cr6PQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4C368F800B8; Mon, 3 Feb 2020 19:43:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 10E33F80148; Mon, 3 Feb 2020 19:43:12 +0100 (CET) Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 559A8F800B8 for ; Mon, 3 Feb 2020 19:43:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 559A8F800B8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Yo1y1Xav" Received: by mail-qk1-x744.google.com with SMTP id q15so15223160qke.9 for ; Mon, 03 Feb 2020 10:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4PMgClN19IhUmet8zzgKP6n4a6viDIBm9kvnRUtH3mA=; b=Yo1y1XavCUEy1wE5P7+cmjzPnnfg1oFVKZVmBL5dtthCguCkZ1WQnpf2YAC7eHPaDm LAIKxbOy+zNgxZgCta9TGT+psszC8jdSUX+mmFt4blUWtcmCkMJVzzsTh65pnXnuuFti F2uSLrsCNrlosOXGbZRwweYEiSo/SJzkncSnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4PMgClN19IhUmet8zzgKP6n4a6viDIBm9kvnRUtH3mA=; b=MuioU/Z+gW3CT3XHw8AmtTA/vZFz9y7GH3YrnxNkpGD85TCOVg0tZa89N/bURBQUzS zXPW2xD9BbzRIKf//s7pnCaDu04arzigLg6MXCGFLSI4SsB8FSKRli+ssD0V3WLEE8eF QLL6tuG4Xp0jHR2hbP+O3lVfWNNiajMHqlcOG8Mat1vqItlvVJYC2oPS8B9c7Cbm3Rh3 goqcz63In4TDeffpUj0uV0qqqH4KqhQQfPzEfwwqekUqesYSHYQq6bTVFvLqBryO/vVV z5+nDFF5Tq6uqRzjoee7KLoKVWZQv/KWuhJfoDg0qsZzsn6FJ7isQD6+mBmtvWtM6Nx/ Sasw== X-Gm-Message-State: APjAAAXaU+OgmZ1DHhzrTySKgbc/XGqoMourt4E2fj7kmI9kOBq5Ek8E VOO908fH/8A99J31jzh+BRJEnpZ4WMuk0AnNaP0ZXA== X-Google-Smtp-Source: APXvYqw1bX0A3kJ4KvUVv86WXufvnleEdtH4TO5zCbHUJmtjESA5AF1NOa9A9O2Tbs2y01O4QjbPgw6zzCm91hZD6E4= X-Received: by 2002:a05:620a:2218:: with SMTP id m24mr25211961qkh.442.1580755381994; Mon, 03 Feb 2020 10:43:01 -0800 (PST) MIME-Version: 1.0 References: <20200130203106.201894-1-pmalani@chromium.org> <20200130203106.201894-12-pmalani@chromium.org> <20200201110358.GR3897@sirena.org.uk> In-Reply-To: <20200201110358.GR3897@sirena.org.uk> From: Prashant Malani Date: Mon, 3 Feb 2020 10:42:51 -0800 Message-ID: To: Mark Brown Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Linux Kernel Mailing List , Takashi Iwai , Liam Girdwood , Guenter Roeck , Enric Balletbo i Serra , Benson Leung , Cheng-Yi Chiang Subject: Re: [alsa-devel] [PATCH 11/17] ASoC: cros_ec_codec: Use cros_ec_send_cmd_msg() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Mark, thanks for looking at the patch. Please see inline. On Sun, Feb 2, 2020 at 4:00 AM Mark Brown wrote: > > On Thu, Jan 30, 2020 at 12:30:56PM -0800, Prashant Malani wrote: > > Replace send_ec_host_command() with cros_ec_send_cmd_msg() which does > > the same thing, but is defined in a common location in platform/chrome > > and exposed for other modules to use. This allows us to remove > > send_ec_host_command() entirely. > > I only have this patch, I've nothing else from the series or a > cover letter. What's the story with dependencies and so on? Sorry about that. I will add you to the cover letter for subsequent versions (I followed https://lwn.net/Articles/585782/ but I think it only adds the relevant mailing lists to the cover letter...) Just for reference, the cover series LKML link is here: https://lkml.org/lkml/2020/1/30/802 Best regards, _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel