From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jhAhp-0001cl-By for mharc-grub-devel@gnu.org; Fri, 05 Jun 2020 07:40:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhAho-0001cd-Ax for grub-devel@gnu.org; Fri, 05 Jun 2020 07:40:12 -0400 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]:45859) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhAhn-0005Ns-5Y for grub-devel@gnu.org; Fri, 05 Jun 2020 07:40:11 -0400 Received: by mail-lj1-x244.google.com with SMTP id i27so370406ljb.12 for ; Fri, 05 Jun 2020 04:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=hUvLeA6m1oXEqO6bSsb+r1DaU2EWLboN1wdpjfyBgy0=; b=gh97QdEdelEjn3KzzNWZhMbbvxlZIESim1vbCx27o90Cnz6Xn+JAW5nH0+v7fCHPvN VhM3jjjbktuQ7sKCelNms7iwCTO1FtQP1FkLWugAo0IqrkRzFsb7e+HGJKpNDMqu6CDe NbPmUlf8X+2h+m82elRdvPuah/v6FfQ2V+DS6ft1sFq95viripIAhKM41HZ+1pHpYiYm 8BDa898Lnn/o80zWdySQMGdzlVIe6k6OpSuNUiy+/XjTw/r5AfxgSG5S8xE5Hh8h2Ma+ oHeH3EQDsOnM+ePWijJX2h79he33Hi8Rfs62IGog0XWbVIWaPy69XBxgPYNSKTAAttOq vO5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=hUvLeA6m1oXEqO6bSsb+r1DaU2EWLboN1wdpjfyBgy0=; b=W45yeoTllvk0lqVwEYGgk8KlZFQH5lMYL2ad032N+03L0FginMUotuGuItdjYK83c0 euWRYd5fBDIWV6Ilc6Nq9sgM1QGcYAKp2TB/nZ6W1jX+Dl1M8T9egLD6s/ge3+OJtdgD NIKWuYydRzqN+GdXOU4yN9Wf7MZhYwx2RGhdkU7umzUAb52AwOJvaT46a6bYeocCx/dw ObxoJRfQnYtRSH3umj7+z5XI5KrRCx34cP5Fd5DobF5vFYwfEpeWcco3Rfq4W3JU91Ml UjErZ5hOxKjzNkFNEcarRzQW3Y1OeOvahCkqxayknlzoW2akQf3vGya4y8DiwdRpNSBs f8/A== X-Gm-Message-State: AOAM533G/3bNAzAfB4BLWnliwVF8nEQHEv+HiQUL7xdb56C0BaeUtnjX YEMxyQNgJf/V6AlgPAtS7S34wZfVwEb6iyhjqTHd77xUsXs= X-Google-Smtp-Source: ABdhPJyHuiUsT3aCjg/7ieHitR6fnm4t5N88/UoYlSDl9sjCpKG8WIvEqepzracPmvSNQyhgAwfTwpACQHoG3ZjOD0I= X-Received: by 2002:a2e:3808:: with SMTP id f8mr4514527lja.165.1591357207827; Fri, 05 Jun 2020 04:40:07 -0700 (PDT) MIME-Version: 1.0 References: <20200604073326.3255847-1-javierm@redhat.com> <20200604073326.3255847-4-javierm@redhat.com> <20200605021552.GA3688@mercury> In-Reply-To: <20200605021552.GA3688@mercury> From: Thomas Frauendorfer Date: Fri, 5 Jun 2020 13:39:56 +0200 Message-ID: Subject: Re: [PATCH 3/4] efinet: UEFI IPv6 PXE support To: The development of GNU GRUB Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::244; envelope-from=thomas.frauendorfer@gmail.com; helo=mail-lj1-x244.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2020 11:40:12 -0000 On Fri, Jun 5, 2020 at 4:16 AM Michael Chang wrote: > > You're probably right if the data type for `station_ip` is > `grub_efi_pxe_ip_address_t`, but here it is `grub_efi_ip_address_t` declared > as: > > typedef grub_uint8_t grub_efi_ip_address_t[8] __attribute__ ((aligned(4))); > > So the compiler would have been taking care of the alignment already ... Oh, right. I only ran into an alignment problem wenn I combined your patches to use the UEFI Managed Network Protocol together with a patch to handle proxy dhcp. Sorry for the noise > By the way, I found the mentioned hunk is different to what was posted on the > list[1], which had relevant fields like this: > > grub_uint8_t using_ipv6; > grub_uint8_t unused[16]; > grub_efi_pxe_ip_address_t station_ip; > grub_efi_pxe_ip_address_t subnet_mask; > > Maybe Javier could help to shed some light on why the change was made ? Though > I'm not against it, I'm still interested to know about it if they have any > other concern or in case anything could be missing here. :) > > [1] https://lists.gnu.org/archive/html/grub-devel/2016-08/msg00003.html > > Thanks, > Michael > > > > > On Thu, Jun 4, 2020 at 9:34 AM Javier Martinez Canillas > > wrote: > > > > > > > > typedef struct grub_efi_pxe_mode > > > { > > > - grub_uint8_t unused[52]; > > > + grub_efi_boolean_t started; > > > + grub_efi_boolean_t ipv6_available; > > > + grub_efi_boolean_t ipv6_supported; > > > + grub_efi_boolean_t using_ipv6; > > > + grub_efi_boolean_t bis_supported; > > > + grub_efi_boolean_t bis_detected; > > > + grub_efi_boolean_t auto_arp; > > > + grub_efi_boolean_t send_guid; > > > + grub_efi_boolean_t dhcp_discover_valid; > > > + grub_efi_boolean_t dhcp_ack_received; > > > + grub_efi_boolean_t proxy_offer_received; > > > + grub_efi_boolean_t pxe_discover_valid; > > > + grub_efi_boolean_t pxe_reply_received; > > > + grub_efi_boolean_t pxe_bis_reply_received; > > > + grub_efi_boolean_t icmp_error_received; > > > + grub_efi_boolean_t tftp_error_received; > > > + grub_efi_boolean_t make_callbacks; > > > + grub_efi_uint8_t ttl; > > > + grub_efi_uint8_t tos; > > > + grub_efi_ip_address_t station_ip; > > > + grub_efi_ip_address_t subnet_mask; > > > grub_efi_pxe_packet_t dhcp_discover; > > > grub_efi_pxe_packet_t dhcp_ack; > > > grub_efi_pxe_packet_t proxy_offer; > > > grub_efi_pxe_packet_t pxe_discover; > > > grub_efi_pxe_packet_t pxe_reply; > > > + grub_efi_pxe_packet_t pxe_bis_reply; > > > + grub_efi_pxe_ip_filter_t ip_filter; > > > + grub_efi_uint32_t arp_cache_entries; > > > + grub_efi_pxe_arp_entry_t arp_cache[GRUB_EFI_PXE_BASE_CODE_MAX_ARP_ENTRIES]; > > > + grub_efi_uint32_t route_table_entries; > > > + grub_efi_pxe_route_entry_t route_table[GRUB_EFI_PXE_BASE_CODE_MAX_ROUTE_ENTRIES]; > > > + grub_efi_pxe_icmp_error_t icmp_error; > > > + grub_efi_pxe_tftp_error_t tftp_error; > > > } grub_efi_pxe_mode_t; > > > > > > typedef struct grub_efi_pxe Those changes look like the api.h changes in a patch from Joseph Mroczek to support proxy dhcp https://lists.gnu.org/archive/html/grub-devel/2014-05/msg00002.html