From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E462AC2D0A3 for ; Mon, 9 Nov 2020 13:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BB4320897 for ; Mon, 9 Nov 2020 13:25:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vGwYDQLw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387975AbgKINZT (ORCPT ); Mon, 9 Nov 2020 08:25:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732757AbgKINZG (ORCPT ); Mon, 9 Nov 2020 08:25:06 -0500 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E0EEC0613CF; Mon, 9 Nov 2020 05:25:06 -0800 (PST) Received: by mail-il1-x144.google.com with SMTP id y17so8250140ilg.4; Mon, 09 Nov 2020 05:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vTFIkPLyuQgyDTeSB90HW+RN1q4pGMJR237yURKzGvY=; b=vGwYDQLwU0TnedQNkBcGBO2I6U4BayCbNJ93T3kRs9AF/kq8/G6FN7/JJdl1BWdeC4 SJz6wRnh149A3g+Ad//i7Vnd0giVrSKayDzl4UWx0tgLnsqNm5XjVovnxWS6UTwNoozP ikyg83nvKrzuktXtovLRxqIh6u8Xb0ctA8bfYP/gRHO2xyHj3b22wk+jvodrvcnBD0Nd bnh25poMn/9zQSV1pFXa0jerwilrlr/8lqL+IYXVltU38Vvo2Frh+hSnvyW3pQ0678yS jrFQZOyBhBA5cW/p5t/n7lbeKcxw2D6yvr8lZnDID6UXkzql26Tt0ni4EdZGzO9c2dfN 4E9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vTFIkPLyuQgyDTeSB90HW+RN1q4pGMJR237yURKzGvY=; b=rdYWU8vXMQrlKirSq3uuEKclYspt6qeUBtE9fog1OpvzfWrImiX6PDpOR6JBLC7Cj5 d5q2VC1e1XzG0r/nlDECqFDbZgA0/c1URd2L57c0JKgbo/OsbapMK5Wpv3eEZnH50bO3 I9d5KVDJpOMwjAjKfbDOtJjxc+hE/sXNgC2JEn4r3nCmtE0iAWPxQwNvH2XTDWsGIcze l6DnsBDWlTGPv+GEnaJ9oovea1wFc469dB7NlLX3vB04eS1740rBI/Fa8LxX9XjH0dDm lRHOvS3xiQnCVmAgUKZ4zt2dxeMtm8SUi/g8pQ40x6XaHMly1yadyx1WgiKlof5wTC8g tJEQ== X-Gm-Message-State: AOAM532Qtb4lrdUUmHAJKwgt7JurCx971bODc07eA75JvDFbqHaHf+1L wFmDH9ULqnch1F2WrW1KwROUZZ6OPAzBW6dtIg13H6+uH/Q= X-Google-Smtp-Source: ABdhPJwOnorxLlzA7DDy3GiiWRQV3tnl/YNgbtaLZdIUzwk/Mj8wRQhXxbt/BKRpdAX+Za75d1giY0qm4Gz/wtNketo= X-Received: by 2002:a92:ac0e:: with SMTP id r14mr10641398ilh.197.1604928306006; Mon, 09 Nov 2020 05:25:06 -0800 (PST) MIME-Version: 1.0 References: <6687de05226dd055ee362933d4841a12b038792d.1601655904.git.npcomplete13@gmail.com> <20201104202952.783724-1-npcomplete13@gmail.com> <20201104202952.783724-3-npcomplete13@gmail.com> <20201104205836.GA783888@ubuntu> In-Reply-To: <20201104205836.GA783888@ubuntu> From: Vivek Unune Date: Mon, 9 Nov 2020 08:24:55 -0500 Message-ID: Subject: Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl To: Florian Fainelli Cc: Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , bcm-kernel-feedback-list , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 4, 2020 at 3:58 PM Vivek Unune wrote: > > On Wed, Nov 04, 2020 at 12:37:45PM -0800, Florian Fainelli wrote: > > > > > > On 11/4/2020 12:29 PM, Vivek Unune wrote: > > > Now that we have a pin controller, use that instead of manuplating the > > > mdio/mdc pins directly. i.e. we no longer require the mdio-mii-mux > > > > I am a bit confused here as I thought the mux was intended to > > dynamically switch the pins in order to support both internal and > > external MDIO devices but given the register ranges that were used, > > these were actually the pinmux configuration for the MDC and MDIO pins. > > > > This does not break USB and/or PCIe PHY communication does it? > > Hi Florian, > > The external and internal MDIO logic is controlled by mdio-bus-mux. > Which controls the BIT(9) of the mdio register. This stays. > > The removal of mdio-mii-mux and it's replacement with usage of > pinctrl doesn't affect USB3 or PCIe. See below USB3 detection. > > [ 4295.450118] usb 1-1: new high-speed USB device number 2 using ehci-platform > [ 4295.690183] usb 4-1: new SuperSpeed Gen 1 USB device number 2 using xhci-hcd > [ 4295.721888] usb-storage 4-1:1.0: USB Mass Storage device detected > [ 4295.728349] scsi host0: usb-storage 4-1:1.0 > [ 4296.811047] scsi 0:0:0:0: Direct-Access SanDisk Ultra Fit 1.00 PQ: 0 ANSI: 6 > [ 4296.821159] sd 0:0:0:0: [sda] 60063744 512-byte logical blocks: (30.8 GB/28.6 GiB) > [ 4296.829667] sd 0:0:0:0: [sda] Write Protect is off > [ 4296.834502] sd 0:0:0:0: [sda] Mode Sense: 43 00 00 00 > [ 4296.834864] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA > [ 4296.852604] GPT:Primary header thinks Alt. header is not at the end of the disk. > [ 4296.860079] GPT:1540387 != 60063743 > [ 4296.863586] GPT:Alternate GPT header not at the end of the disk. > [ 4296.869600] GPT:1540387 != 60063743 > [ 4296.873090] GPT: Use GNU Parted to correct GPT errors. > [ 4296.878266] sda: sda1 sda2 > [ 4296.884416] sd 0:0:0:0: [sda] Attached SCSI removable disk > Hi Florian, Does this clarify your confusion? Thanks, Vivek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C192C2D0A3 for ; Mon, 9 Nov 2020 13:25:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF4C520663 for ; Mon, 9 Nov 2020 13:25:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qzRVqsvQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vGwYDQLw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF4C520663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=15d6UmbqPCVv0GxLPtNyAyfup3OVFRVaqJN8C6dR5yQ=; b=qzRVqsvQrX5CNswA1IDdfRzsT N0fZ684kZFm0PHhqLkX5xMQ0SsmCnvk+83h39vnItwaAGkVulP81uED7PYzHjlCym87pm6WTJo+NX SVCC4+uOXqQtL1nfi02nRp4C9Pueb0PZaLW9FAIuOUwTHnO6k/sqtSS1wwmzpZC0WGvs5KczaQYli dXW0C5zyXot+1OxiuNtIhgMo4HGype5uLo2N1F1v4wjgz/UsmsZCjiadljtuHx5MNMWVX3y8sUMFV gaoKx5rViLdTPPVk4EX5EpnBBQwt2jpxAR+mZyBMjcizKqpsDC4U4LawjG1JkrkwFki9lz9WHpPYd CwITjwL3A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc7AZ-0001N2-1r; Mon, 09 Nov 2020 13:25:15 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc7AV-0001M1-Ti for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 13:25:12 +0000 Received: by mail-il1-x142.google.com with SMTP id y9so1144509ilb.0 for ; Mon, 09 Nov 2020 05:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vTFIkPLyuQgyDTeSB90HW+RN1q4pGMJR237yURKzGvY=; b=vGwYDQLwU0TnedQNkBcGBO2I6U4BayCbNJ93T3kRs9AF/kq8/G6FN7/JJdl1BWdeC4 SJz6wRnh149A3g+Ad//i7Vnd0giVrSKayDzl4UWx0tgLnsqNm5XjVovnxWS6UTwNoozP ikyg83nvKrzuktXtovLRxqIh6u8Xb0ctA8bfYP/gRHO2xyHj3b22wk+jvodrvcnBD0Nd bnh25poMn/9zQSV1pFXa0jerwilrlr/8lqL+IYXVltU38Vvo2Frh+hSnvyW3pQ0678yS jrFQZOyBhBA5cW/p5t/n7lbeKcxw2D6yvr8lZnDID6UXkzql26Tt0ni4EdZGzO9c2dfN 4E9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vTFIkPLyuQgyDTeSB90HW+RN1q4pGMJR237yURKzGvY=; b=gqFFc2TX1NW0/79cZi2CEs5H1MURa6r+NO3A7uv6MVt2LCWTM0uAg/XhPpuBCWRTzz C10W6r97BJHGWHz8GL/RpfaEwIgJkEHrWCmVU9DfqlEAGCsKHOcCpOWWNmdldpgtGGdX vA3UWzYeEzCifFLVILzt+SFscKt5yw0iTohn1uVt4aFjC43pFKNPtRz8oRTqHuqCsx/J /HanfpZ1yp/Y+54t1GxLo7qsNyTiJGzVK5mUoO1pQu3vrc5CdF88y18yR+kRjkeD+8F0 gojvgekjz8cHs+5/gsH5z5kRLH5aRgY92iPTyCHfhPlksHZBs6lgUVFCghHpz8Mp35aA kP8g== X-Gm-Message-State: AOAM532RkZCXdESnG3toWRTcosXgUpZs/q0gQI/7ciEXqOzqtIaR55zi I8eSO73/+LXxr86YThhs182PdmO3plXOZVZxANg= X-Google-Smtp-Source: ABdhPJwOnorxLlzA7DDy3GiiWRQV3tnl/YNgbtaLZdIUzwk/Mj8wRQhXxbt/BKRpdAX+Za75d1giY0qm4Gz/wtNketo= X-Received: by 2002:a92:ac0e:: with SMTP id r14mr10641398ilh.197.1604928306006; Mon, 09 Nov 2020 05:25:06 -0800 (PST) MIME-Version: 1.0 References: <6687de05226dd055ee362933d4841a12b038792d.1601655904.git.npcomplete13@gmail.com> <20201104202952.783724-1-npcomplete13@gmail.com> <20201104202952.783724-3-npcomplete13@gmail.com> <20201104205836.GA783888@ubuntu> In-Reply-To: <20201104205836.GA783888@ubuntu> From: Vivek Unune Date: Mon, 9 Nov 2020 08:24:55 -0500 Message-ID: Subject: Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl To: Florian Fainelli X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_082512_004550_198E0EE7 X-CRM114-Status: GOOD ( 20.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Linux Kernel Mailing List , Rob Herring , bcm-kernel-feedback-list , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 4, 2020 at 3:58 PM Vivek Unune wrote: > > On Wed, Nov 04, 2020 at 12:37:45PM -0800, Florian Fainelli wrote: > > > > > > On 11/4/2020 12:29 PM, Vivek Unune wrote: > > > Now that we have a pin controller, use that instead of manuplating the > > > mdio/mdc pins directly. i.e. we no longer require the mdio-mii-mux > > > > I am a bit confused here as I thought the mux was intended to > > dynamically switch the pins in order to support both internal and > > external MDIO devices but given the register ranges that were used, > > these were actually the pinmux configuration for the MDC and MDIO pins. > > > > This does not break USB and/or PCIe PHY communication does it? > > Hi Florian, > > The external and internal MDIO logic is controlled by mdio-bus-mux. > Which controls the BIT(9) of the mdio register. This stays. > > The removal of mdio-mii-mux and it's replacement with usage of > pinctrl doesn't affect USB3 or PCIe. See below USB3 detection. > > [ 4295.450118] usb 1-1: new high-speed USB device number 2 using ehci-platform > [ 4295.690183] usb 4-1: new SuperSpeed Gen 1 USB device number 2 using xhci-hcd > [ 4295.721888] usb-storage 4-1:1.0: USB Mass Storage device detected > [ 4295.728349] scsi host0: usb-storage 4-1:1.0 > [ 4296.811047] scsi 0:0:0:0: Direct-Access SanDisk Ultra Fit 1.00 PQ: 0 ANSI: 6 > [ 4296.821159] sd 0:0:0:0: [sda] 60063744 512-byte logical blocks: (30.8 GB/28.6 GiB) > [ 4296.829667] sd 0:0:0:0: [sda] Write Protect is off > [ 4296.834502] sd 0:0:0:0: [sda] Mode Sense: 43 00 00 00 > [ 4296.834864] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA > [ 4296.852604] GPT:Primary header thinks Alt. header is not at the end of the disk. > [ 4296.860079] GPT:1540387 != 60063743 > [ 4296.863586] GPT:Alternate GPT header not at the end of the disk. > [ 4296.869600] GPT:1540387 != 60063743 > [ 4296.873090] GPT: Use GNU Parted to correct GPT errors. > [ 4296.878266] sda: sda1 sda2 > [ 4296.884416] sd 0:0:0:0: [sda] Attached SCSI removable disk > Hi Florian, Does this clarify your confusion? Thanks, Vivek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel