* [PATCH] kexec: restore arch_kexec_kernel_image_probe declaration
@ 2019-07-29 12:14 ` Vasily Gorbik
0 siblings, 0 replies; 6+ messages in thread
From: Vasily Gorbik @ 2019-07-29 12:14 UTC (permalink / raw)
To: Eric Biederman, Andrew Morton
Cc: Dave Young, kexec, linux-kernel, AKASHI Takahiro
arch_kexec_kernel_image_probe function declaration has been removed by
commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops
functions"). Still this function is overridden by couple of architectures
and proper prototype declaration is therefore important, so bring it
back. This fixes the following sparse warning on s390:
arch/s390/kernel/machine_kexec_file.c:333:5: warning: symbol 'arch_kexec_kernel_image_probe' was not declared. Should it be static?
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
---
include/linux/kexec.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index 1740fe36b5b7..f7529d120920 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -183,6 +183,8 @@ int kexec_purgatory_get_set_symbol(struct kimage *image, const char *name,
bool get_value);
void *kexec_purgatory_get_symbol_addr(struct kimage *image, const char *name);
+int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
+ unsigned long buf_len);
void * __weak arch_kexec_kernel_image_load(struct kimage *image);
int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi,
Elf_Shdr *section,
--
2.21.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] kexec: restore arch_kexec_kernel_image_probe declaration
2019-07-29 12:14 ` Vasily Gorbik
@ 2019-07-30 9:45 ` Dave Young
-1 siblings, 0 replies; 6+ messages in thread
From: Dave Young @ 2019-07-30 9:45 UTC (permalink / raw)
To: Vasily Gorbik
Cc: Eric Biederman, Andrew Morton, kexec, linux-kernel, AKASHI Takahiro
On 07/29/19 at 02:14pm, Vasily Gorbik wrote:
> arch_kexec_kernel_image_probe function declaration has been removed by
> commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops
> functions"). Still this function is overridden by couple of architectures
> and proper prototype declaration is therefore important, so bring it
> back. This fixes the following sparse warning on s390:
> arch/s390/kernel/machine_kexec_file.c:333:5: warning: symbol 'arch_kexec_kernel_image_probe' was not declared. Should it be static?
>
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> include/linux/kexec.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 1740fe36b5b7..f7529d120920 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -183,6 +183,8 @@ int kexec_purgatory_get_set_symbol(struct kimage *image, const char *name,
> bool get_value);
> void *kexec_purgatory_get_symbol_addr(struct kimage *image, const char *name);
>
> +int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
> + unsigned long buf_len);
> void * __weak arch_kexec_kernel_image_load(struct kimage *image);
> int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi,
> Elf_Shdr *section,
> --
> 2.21.0
>
Acked-by: Dave Young <dyoung@redhat.com>
Thanks
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kexec: restore arch_kexec_kernel_image_probe declaration
@ 2019-07-30 9:45 ` Dave Young
0 siblings, 0 replies; 6+ messages in thread
From: Dave Young @ 2019-07-30 9:45 UTC (permalink / raw)
To: Vasily Gorbik
Cc: AKASHI Takahiro, Andrew Morton, kexec, Eric Biederman, linux-kernel
On 07/29/19 at 02:14pm, Vasily Gorbik wrote:
> arch_kexec_kernel_image_probe function declaration has been removed by
> commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops
> functions"). Still this function is overridden by couple of architectures
> and proper prototype declaration is therefore important, so bring it
> back. This fixes the following sparse warning on s390:
> arch/s390/kernel/machine_kexec_file.c:333:5: warning: symbol 'arch_kexec_kernel_image_probe' was not declared. Should it be static?
>
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> include/linux/kexec.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 1740fe36b5b7..f7529d120920 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -183,6 +183,8 @@ int kexec_purgatory_get_set_symbol(struct kimage *image, const char *name,
> bool get_value);
> void *kexec_purgatory_get_symbol_addr(struct kimage *image, const char *name);
>
> +int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
> + unsigned long buf_len);
> void * __weak arch_kexec_kernel_image_load(struct kimage *image);
> int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi,
> Elf_Shdr *section,
> --
> 2.21.0
>
Acked-by: Dave Young <dyoung@redhat.com>
Thanks
Dave
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kexec: restore arch_kexec_kernel_image_probe declaration
2019-07-29 12:14 ` Vasily Gorbik
@ 2019-07-30 10:25 ` Bhupesh Sharma
-1 siblings, 0 replies; 6+ messages in thread
From: Bhupesh Sharma @ 2019-07-30 10:25 UTC (permalink / raw)
To: Vasily Gorbik
Cc: Eric Biederman, Andrew Morton, Dave Young, kexec mailing list,
Linux Kernel Mailing List, AKASHI Takahiro
Hi Vasily,
On Mon, Jul 29, 2019 at 5:44 PM Vasily Gorbik <gor@linux.ibm.com> wrote:
>
> arch_kexec_kernel_image_probe function declaration has been removed by
> commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops
> functions"). Still this function is overridden by couple of architectures
> and proper prototype declaration is therefore important, so bring it
> back. This fixes the following sparse warning on s390:
> arch/s390/kernel/machine_kexec_file.c:333:5: warning: symbol 'arch_kexec_kernel_image_probe' was not declared. Should it be static?
May be it would be better to add a 'Fixes:' tag here (but may be it
can be added while picking it into the tree). With the above minor
nitpick:
Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
Thanks,
Bhupesh
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> include/linux/kexec.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 1740fe36b5b7..f7529d120920 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -183,6 +183,8 @@ int kexec_purgatory_get_set_symbol(struct kimage *image, const char *name,
> bool get_value);
> void *kexec_purgatory_get_symbol_addr(struct kimage *image, const char *name);
>
> +int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
> + unsigned long buf_len);
> void * __weak arch_kexec_kernel_image_load(struct kimage *image);
> int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi,
> Elf_Shdr *section,
> --
> 2.21.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kexec: restore arch_kexec_kernel_image_probe declaration
@ 2019-07-30 10:25 ` Bhupesh Sharma
0 siblings, 0 replies; 6+ messages in thread
From: Bhupesh Sharma @ 2019-07-30 10:25 UTC (permalink / raw)
To: Vasily Gorbik
Cc: kexec mailing list, Linux Kernel Mailing List, AKASHI Takahiro,
Eric Biederman, Andrew Morton, Dave Young
Hi Vasily,
On Mon, Jul 29, 2019 at 5:44 PM Vasily Gorbik <gor@linux.ibm.com> wrote:
>
> arch_kexec_kernel_image_probe function declaration has been removed by
> commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops
> functions"). Still this function is overridden by couple of architectures
> and proper prototype declaration is therefore important, so bring it
> back. This fixes the following sparse warning on s390:
> arch/s390/kernel/machine_kexec_file.c:333:5: warning: symbol 'arch_kexec_kernel_image_probe' was not declared. Should it be static?
May be it would be better to add a 'Fixes:' tag here (but may be it
can be added while picking it into the tree). With the above minor
nitpick:
Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
Thanks,
Bhupesh
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> include/linux/kexec.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 1740fe36b5b7..f7529d120920 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -183,6 +183,8 @@ int kexec_purgatory_get_set_symbol(struct kimage *image, const char *name,
> bool get_value);
> void *kexec_purgatory_get_symbol_addr(struct kimage *image, const char *name);
>
> +int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
> + unsigned long buf_len);
> void * __weak arch_kexec_kernel_image_load(struct kimage *image);
> int __weak arch_kexec_apply_relocations_add(struct purgatory_info *pi,
> Elf_Shdr *section,
> --
> 2.21.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread