All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Yeryomin <leroi.lists@gmail.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Rajkumar Manoharan <rmanohar@codeaurora.org>
Subject: Re: ath10k performance, master branch from 20160407
Date: Fri, 22 Apr 2016 20:02:33 +0300	[thread overview]
Message-ID: <CACiydbL6vxuvG2fzRGnmZOzE_cWV5FJbYJG4=XjPpT0rDxTSUg@mail.gmail.com> (raw)
In-Reply-To: <CA+BoTQndOpgYYZiZbenROV9+-WUHSbUugDDgCKGVe2fyA0efXQ@mail.gmail.com>

On 19 April 2016 at 08:28, Michal Kazior <michal.kazior@tieto.com> wrote:
> On 18 April 2016 at 15:00, Roman Yeryomin <leroi.lists@gmail.com> wrote:
>> So it looks like Michal's patch set "ath10k: implement push-pull tx
>> model" introduced this regression - after restoring it from reverts
>> fq_codel_drop is hungry again.
>> Any ideas how to fix?
>
> If my hunch is right there's no easy (and proper) fix for that now.
>
> One of the patchset patches (ath10k: implement wake_tx_queue) starts
> to use mac80211 software queuing. This introduces extra induced
> latency and I'm guessing it results in fill-in-then-drain sequences in
> some cases which end up being long enough to make fq_codel_drop more
> work than normal.
>
> This is required for other changes and MU-MIMO performance
> improvements so this patch can't be removed.
>
> I guess you could try forcing fq_codel to use different target time,
> e.g. 20ms (instead of the default 5). You can do this using `tc`
> command like so:
>
>    tc qdisc replace dev wlan0 parent :1 fq_codel limit 1024 target 20ms
>    tc qdisc replace dev wlan0 parent :2 fq_codel limit 1024 target 20ms
>    tc qdisc replace dev wlan0 parent :3 fq_codel limit 1024 target 20ms
>    tc qdisc replace dev wlan0 parent :4 fq_codel limit 1024 target 20ms

this didn't change anything

qdisc mq 0: dev wlan0 root
qdisc fq_codel 8001: dev wlan0 parent :1 limit 1024p flows 1024
quantum 1514 target 20.0ms interval 100.0ms ecn
qdisc fq_codel 8002: dev wlan0 parent :2 limit 1024p flows 1024
quantum 1514 target 20.0ms interval 100.0ms ecn
qdisc fq_codel 8003: dev wlan0 parent :3 limit 1024p flows 1024
quantum 1514 target 20.0ms interval 100.0ms ecn
qdisc fq_codel 8004: dev wlan0 parent :4 limit 1024p flows 1024
quantum 1514 target 20.0ms interval 100.0ms ecn

> You might also want to try `pfifo` instead of `fq_codel` for comparison as well.

and this did, but for UDP only: 450Mbps instead of 30, TCP remained on 550Mbps


Regards,
Roman

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2016-04-22 17:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 14:44 Roman Yeryomin
2016-04-08 15:34 ` Manoharan, Rajkumar
2016-04-08 16:00   ` Roman Yeryomin
2016-04-08 16:41     ` Manoharan, Rajkumar
2016-04-08 17:19       ` Roman Yeryomin
2016-04-09  4:02         ` Manoharan, Rajkumar
2016-04-13 12:44           ` Roman Yeryomin
2016-04-17  9:28           ` Roman Yeryomin
2016-04-17 15:06             ` Manoharan, Rajkumar
2016-04-17 23:03               ` Roman Yeryomin
2016-04-18 13:00                 ` Roman Yeryomin
2016-04-19  5:28                   ` Michal Kazior
2016-04-19  7:31                     ` Roman Yeryomin
2016-04-19  7:43                       ` Michal Kazior
2016-04-19 15:35                         ` Valo, Kalle
2016-04-22 17:05                           ` Roman Yeryomin
2016-05-09 12:26                             ` Michal Kazior
2016-05-15 22:59                               ` Roman Yeryomin
2016-05-16  3:57                                 ` Rajkumar Manoharan
2016-04-22 17:03                         ` Roman Yeryomin
2016-04-22 17:02                     ` Roman Yeryomin [this message]
2016-04-20  9:03                 ` Michal Kazior
2016-04-12 10:16     ` Xue Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACiydbL6vxuvG2fzRGnmZOzE_cWV5FJbYJG4=XjPpT0rDxTSUg@mail.gmail.com' \
    --to=leroi.lists@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=michal.kazior@tieto.com \
    --cc=rmanohar@codeaurora.org \
    --cc=rmanohar@qti.qualcomm.com \
    --subject='Re: ath10k performance, master branch from 20160407' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.