All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Yeryomin <leroi.lists@gmail.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: Rajkumar Manoharan <rmanohar@codeaurora.org>,
	"michal.kazior@tieto.com" <michal.kazior@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>
Subject: Re: ath10k performance, master branch from 20160407
Date: Fri, 22 Apr 2016 20:05:21 +0300	[thread overview]
Message-ID: <CACiydbLD2F2Z-iEW_jNr2hoKZzbiA7Y2gCnP4eeKkZpotzkSzA@mail.gmail.com> (raw)
In-Reply-To: <87k2jtk3wt.fsf@kamboji.qca.qualcomm.com>

On 19 April 2016 at 18:35, Valo, Kalle <kvalo@qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> On 19 April 2016 at 09:31, Roman Yeryomin <leroi.lists@gmail.com> wrote:
>>> On 19 April 2016 at 08:28, Michal Kazior <michal.kazior@tieto.com> wrote:
>>>
>>>> If my hunch is right there's no easy (and proper) fix for that now.
>>>>
>>>> One of the patchset patches (ath10k: implement wake_tx_queue) starts
>>>> to use mac80211 software queuing. This introduces extra induced
>>>> latency and I'm guessing it results in fill-in-then-drain sequences in
>>>> some cases which end up being long enough to make fq_codel_drop more
>>>> work than normal.
>>>>
>>>> This is required for other changes and MU-MIMO performance
>>>> improvements so this patch can't be removed.
>>>
>>> But qca988x doesn't support MU-MIMO, AFAIK.
>>
>> Correct.
>>
>>
>>> Can this be made chip dependent?
>>
>> I guess it could but it'd arguably make the driver more complex and
>> harder to maintain. What we want is a long-term fix, not a short-term
>> one.
>
> But we should never go backwards and TCP dropping from 750 Mbps to ~550
> Mbps is a huge drop, so this is not ok. We have to do something to fix
> this, be it reverting the wake_tx_queue support, somehow disabling it by
> default or something.

I would agree with Kalle here. This looks like very serious regression.
But I'm afraid I can only help with testing here.

Regards,
Roman

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2016-04-22 17:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 14:44 ath10k performance, master branch from 20160407 Roman Yeryomin
2016-04-08 15:34 ` Manoharan, Rajkumar
2016-04-08 16:00   ` Roman Yeryomin
2016-04-08 16:41     ` Manoharan, Rajkumar
2016-04-08 17:19       ` Roman Yeryomin
2016-04-09  4:02         ` Manoharan, Rajkumar
2016-04-13 12:44           ` Roman Yeryomin
2016-04-17  9:28           ` Roman Yeryomin
2016-04-17 15:06             ` Manoharan, Rajkumar
2016-04-17 23:03               ` Roman Yeryomin
2016-04-18 13:00                 ` Roman Yeryomin
2016-04-19  5:28                   ` Michal Kazior
2016-04-19  7:31                     ` Roman Yeryomin
2016-04-19  7:43                       ` Michal Kazior
2016-04-19 15:35                         ` Valo, Kalle
2016-04-22 17:05                           ` Roman Yeryomin [this message]
2016-05-09 12:26                             ` Michal Kazior
2016-05-15 22:59                               ` Roman Yeryomin
2016-05-16  3:57                                 ` Rajkumar Manoharan
2016-04-22 17:03                         ` Roman Yeryomin
2016-04-22 17:02                     ` Roman Yeryomin
2016-04-20  9:03                 ` Michal Kazior
2016-04-12 10:16     ` Xue Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACiydbLD2F2Z-iEW_jNr2hoKZzbiA7Y2gCnP4eeKkZpotzkSzA@mail.gmail.com \
    --to=leroi.lists@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=michal.kazior@tieto.com \
    --cc=rmanohar@codeaurora.org \
    --cc=rmanohar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.