From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Yeryomin Subject: Re: OpenWRT wrong adjustment of fq_codel defaults (Was: fq_codel_drop vs a udp flood) Date: Mon, 16 May 2016 22:46:59 +0300 Message-ID: References: <1462125592.5535.194.camel@edumazet-glaptop3.roam.corp.google.com> <865DA393-262D-40B6-A9D3-1B978CD5F6C6@gmail.com> <1462128385.5535.200.camel@edumazet-glaptop3.roam.corp.google.com> <1462136140.5535.219.camel@edumazet-glaptop3.roam.corp.google.com> <1462201620.5535.250.camel@edumazet-glaptop3.roam.corp.google.com> <1462205669.5535.254.camel@edumazet-glaptop3.roam.corp.google.com> <1462464776.13075.18.camel@edumazet-glaptop3.roam.corp.google.com> <1462476207.13075.20.camel@edumazet-glaptop3.roam.corp.google.com> <20160506114243.4eb4f95e@redhat.com> <20160506144740.210901f5@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Rajkumar Manoharan , make-wifi-fast@lists.bufferbloat.net, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , ath10k , "netdev@vger.kernel.org" , "codel@lists.bufferbloat.net" , Jonathan Morton , OpenWrt Development List , Felix Fietkau To: Dave Taht Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: codel-bounces@lists.bufferbloat.net Sender: "Codel" List-Id: netdev.vger.kernel.org T24gMTYgTWF5IDIwMTYgYXQgMTk6MDQsIERhdmUgVGFodCA8ZGF2ZS50YWh0QGdtYWlsLmNvbT4g d3JvdGU6Cj4gT24gTW9uLCBNYXkgMTYsIDIwMTYgYXQgMToxNCBBTSwgUm9tYW4gWWVyeW9taW4g PGxlcm9pLmxpc3RzQGdtYWlsLmNvbT4gd3JvdGU6Cj4+IE9uIDE2IE1heSAyMDE2IGF0IDAxOjM0 LCBSb21hbiBZZXJ5b21pbiA8bGVyb2kubGlzdHNAZ21haWwuY29tPiB3cm90ZToKPj4+IE9uIDYg TWF5IDIwMTYgYXQgMjI6NDMsIERhdmUgVGFodCA8ZGF2ZS50YWh0QGdtYWlsLmNvbT4gd3JvdGU6 Cj4+Pj4gT24gRnJpLCBNYXkgNiwgMjAxNiBhdCAxMTo1NiBBTSwgUm9tYW4gWWVyeW9taW4gPGxl cm9pLmxpc3RzQGdtYWlsLmNvbT4gd3JvdGU6Cj4+Pj4+IE9uIDYgTWF5IDIwMTYgYXQgMjE6NDMs IFJvbWFuIFllcnlvbWluIDxsZXJvaS5saXN0c0BnbWFpbC5jb20+IHdyb3RlOgo+Pj4+Pj4gT24g NiBNYXkgMjAxNiBhdCAxNTo0NywgSmVzcGVyIERhbmdhYXJkIEJyb3VlciA8YnJvdWVyQHJlZGhh dC5jb20+IHdyb3RlOgo+Pj4+Pj4+Cj4+Pj4+Pj4gSSd2ZSBjcmVhdGVkIGEgT3BlbldSVCB0aWNr ZXRbMV0gb24gdGhpcyBpc3N1ZSwgYXMgaXQgc2VlbXMgdGhhdCBzb21lb25lWzJdCj4+Pj4+Pj4g Y2xvc2VkIEZlbGl4J2VzIE9wZW5XUlQgZW1haWwgYWNjb3VudCAoYmFkIGNob2ljZSEgZW1haWxz IGJvdW5jaW5nKS4KPj4+Pj4+PiBTb3VuZHMgbGlrZSBPcGVuV1JUIGFuZCB0aGUgTEVERSBodHRw czovL3d3dy5sZWRlLXByb2plY3Qub3JnLyBwcm9qZWN0Cj4+Pj4+Pj4gaXMgaW4gc29tZSBraW5k IG9mIGNvbmZsaWN0Lgo+Pj4+Pj4+Cj4+Pj4+Pj4gT3BlbldSVCB0aWNrZXQgWzFdIGh0dHBzOi8v ZGV2Lm9wZW53cnQub3JnL3RpY2tldC8yMjM0OQo+Pj4+Pj4+Cj4+Pj4+Pj4gWzJdIGh0dHA6Ly90 aHJlYWQuZ21hbmUub3JnL2dtYW5lLmNvbXAuZW1iZWRkZWQub3BlbndydC5kZXZlbC80MDI5OC9m b2N1cz00MDMzNQo+Pj4+Pj4KPj4+Pj4+IE9LLCBzbywgYWZ0ZXIgcG9ydGluZyB0aGUgcGF0Y2gg dG8gNC4xIG9wZW53cnQga2VybmVsIGFuZCBwbGF5aW5nIGEKPj4+Pj4+IGJpdCB3aXRoIGZxX2Nv ZGVsIGxpbWl0cyBJIHdhcyBhYmxlIHRvIGdldCA0MjBNYnBzIFVEUCBsaWtlIHRoaXM6Cj4+Pj4+ PiB0YyBxZGlzYyByZXBsYWNlIGRldiB3bGFuMCBwYXJlbnQgOjEgZnFfY29kZWwgZmxvd3MgMTYg bGltaXQgMjU2Cj4+Pj4+Cj4+Pj4+IEZvcmdvdCB0byBtZW50aW9uLCBJJ3ZlIHJlZHVjZWQgZHJv cF9iYXRjaF9zaXplIGRvd24gdG8gMzIKPj4+Pgo+Pj4+IDApIE5vdCBjbGVhciB0byBtZSBpZiB0 aGF0J3MgdGhlIHJpZ2h0IGxpbmUsIHRoZXJlIGFyZSA0IHdpZmkgcXVldWVzLAo+Pj4+IGFuZCB0 aGUgdGhpcmQgb25lCj4+Pj4gaXMgdGhlIEJFIHF1ZXVlLgo+Pj4KPj4+IFRoYXQgd2FzIGFuIGV4 YW1wbGUsIHNvcnJ5LCBzaG91bGQgaGF2ZSBzdGF0ZWQgdGhhdC4gSSd2ZSBhcHBsaWVkIHNhbWUK Pj4+IHNldHRpbmdzIHRvIGFsbCA0IHF1ZXVlcy4KPj4+Cj4+Pj4gVGhhdCBpcyB0b28gbG93IGEg bGltaXQsIGFsc28sIGZvciBub3JtYWwgdXNlLiBBbmQ6Cj4+Pj4gZm9yIHRoZSBwdXJwb3NlIG9m IHRoaXMgcGFydGljdWxhciBVRFAgdGVzdCwgZmxvd3MgMTYgaXMgb2ssIGJ1dCBub3QKPj4+PiBp ZGVhbC4KPj4+Cj4+PiBJIHBsYXllZCB3aXRoIGRpZmZlcmVudCBjb21iaW5hdGlvbnMsIGl0IGRv ZXNuJ3QgbWFrZSBhbnkKPj4+IChzaWduaWZpY2FudCkgZGlmZmVyZW5jZTogMjAtMzBNYnBzLCBu b3QgbW9yZS4KPj4+IFdoYXQgbnVtYmVycyB3b3VsZCB5b3UgcHJvcG9zZT8KPj4+Cj4+Pj4gMSkg V2hhdCdzIHRoZSB0Y3AgbnVtYmVyICh3aXRoIGEgc2ltdWx0YW5lb3VzIHBpbmcpIHdpdGggdGhp cyBsYXRlc3QgcGF0Y2hzZXQ/Cj4+Pj4gKEkgY2FyZSBhYm91dCB0Y3AgcGVyZm9ybWFuY2UgYSBs b3QgbW9yZSB0aGFuIHVkcCBmbG9vZHMgLSBzdXJ2aXZpbmcgYQo+Pj4+IHVkcCBmbG9vZCB5ZXMs IHBlcmZvcm1hbmNlLCBubykKPj4+Cj4+PiBEdXJpbmcgdGhlIHRlc3QgKGJvdGggVENQIGFuZCBV RFApIGl0J3Mgcm91Z2hseSA1bXMgaW4gYXZlcmFnZSwgbm90Cj4+PiBydW5uaW5nIHRlc3RzIH4y bXMuIEFjdHVhbGx5IEknbSBub3cgd29uZGVyaW5nIGlmIHRhcmdldCBpcyB3b3JraW5nIGF0Cj4+ PiBhbGwsIGJlY2F1c2UgSSBoYWQgc2FtZSByZXN1bHQgd2l0aCB0YXJnZXQgODBtcy4uCj4+PiBT bywgeWVzLCBsYXRlbmN5IGlzIGdvb2QsIGJ1dCBwZXJmb3JtYW5jZSBpcyBwb29yLgo+Pj4KPj4+ PiBiZWZvcmUvYWZ0ZXI/Cj4+Pj4KPj4+PiB0YyAtcyBxZGlzYyBzaG93IGRldiB3bGFuMCBkdXJp bmcvYWZ0ZXIgcmVzdWx0cz8KPj4+Cj4+PiBkdXJpbmcgdGhlIHRlc3Q6Cj4+Pgo+Pj4gcWRpc2Mg bXEgMDogcm9vdAo+Pj4gIFNlbnQgMTYwMDQ5NjAwMCBieXRlcyAxMDU3MTk0IHBrdCAoZHJvcHBl ZCAxNDIxNTY4LCBvdmVybGltaXRzIDAgcmVxdWV1ZXMgMTcpCj4+PiAgYmFja2xvZyAxNTQ1Nzk0 YiAxMDIxcCByZXF1ZXVlcyAxNwo+Pj4gcWRpc2MgZnFfY29kZWwgODAwMTogcGFyZW50IDoxIGxp bWl0IDEwMjRwIGZsb3dzIDE2IHF1YW50dW0gMTUxNAo+Pj4gdGFyZ2V0IDgwLjBtcyBjZV90aHJl c2hvbGQgMzJ1cyBpbnRlcnZhbCAxMDAuMG1zIGVjbgo+Pj4gIFNlbnQgMCBieXRlcyAwIHBrdCAo ZHJvcHBlZCAwLCBvdmVybGltaXRzIDAgcmVxdWV1ZXMgMCkKPj4+ICBiYWNrbG9nIDBiIDBwIHJl cXVldWVzIDAKPj4+ICAgbWF4cGFja2V0IDAgZHJvcF9vdmVybGltaXQgMCBuZXdfZmxvd19jb3Vu dCAwIGVjbl9tYXJrIDAKPj4+ICAgbmV3X2Zsb3dzX2xlbiAwIG9sZF9mbG93c19sZW4gMAo+Pj4g cWRpc2MgZnFfY29kZWwgODAwMjogcGFyZW50IDoyIGxpbWl0IDEwMjRwIGZsb3dzIDE2IHF1YW50 dW0gMTUxNAo+Pj4gdGFyZ2V0IDgwLjBtcyBjZV90aHJlc2hvbGQgMzJ1cyBpbnRlcnZhbCAxMDAu MG1zIGVjbgo+Pj4gIFNlbnQgMCBieXRlcyAwIHBrdCAoZHJvcHBlZCAwLCBvdmVybGltaXRzIDAg cmVxdWV1ZXMgMCkKPj4+ICBiYWNrbG9nIDBiIDBwIHJlcXVldWVzIDAKPj4+ICAgbWF4cGFja2V0 IDAgZHJvcF9vdmVybGltaXQgMCBuZXdfZmxvd19jb3VudCAwIGVjbl9tYXJrIDAKPj4+ICAgbmV3 X2Zsb3dzX2xlbiAwIG9sZF9mbG93c19sZW4gMAo+Pj4gcWRpc2MgZnFfY29kZWwgODAwMzogcGFy ZW50IDozIGxpbWl0IDEwMjRwIGZsb3dzIDE2IHF1YW50dW0gMTUxNAo+Pj4gdGFyZ2V0IDgwLjBt cyBjZV90aHJlc2hvbGQgMzJ1cyBpbnRlcnZhbCAxMDAuMG1zIGVjbgo+Pj4gIFNlbnQgMTYwMTI3 MTE2OCBieXRlcyAxMDU3NzA2IHBrdCAoZHJvcHBlZCAxNDIyMzA0LCBvdmVybGltaXRzIDAgcmVx dWV1ZXMgMTcpCj4+PiAgYmFja2xvZyAxNTQxMjUyYiAxMDE4cCByZXF1ZXVlcyAxNwo+Pj4gICBt YXhwYWNrZXQgMTUxNCBkcm9wX292ZXJsaW1pdCAxNDIyMzA0IG5ld19mbG93X2NvdW50IDM1IGVj bl9tYXJrIDAKPj4+ICAgbmV3X2Zsb3dzX2xlbiAwIG9sZF9mbG93c19sZW4gMQo+Pj4gcWRpc2Mg ZnFfY29kZWwgODAwNDogcGFyZW50IDo0IGxpbWl0IDEwMjRwIGZsb3dzIDE2IHF1YW50dW0gMTUx NAo+Pj4gdGFyZ2V0IDgwLjBtcyBjZV90aHJlc2hvbGQgMzJ1cyBpbnRlcnZhbCAxMDAuMG1zIGVj bgo+Pj4gIFNlbnQgMCBieXRlcyAwIHBrdCAoZHJvcHBlZCAwLCBvdmVybGltaXRzIDAgcmVxdWV1 ZXMgMCkKPj4+ICBiYWNrbG9nIDBiIDBwIHJlcXVldWVzIDAKPj4+ICAgbWF4cGFja2V0IDAgZHJv cF9vdmVybGltaXQgMCBuZXdfZmxvd19jb3VudCAwIGVjbl9tYXJrIDAKPj4+ICAgbmV3X2Zsb3dz X2xlbiAwIG9sZF9mbG93c19sZW4gMAo+Pj4KPj4+Cj4+PiBhZnRlciB0aGUgdGVzdCAoNjBzZWMp Ogo+Pj4KPj4+IHFkaXNjIG1xIDA6IHJvb3QKPj4+ICBTZW50IDMwODQ5OTYwNTIgYnl0ZXMgMjAz Nzc0NCBwa3QgKGRyb3BwZWQgMjc3MDE3Niwgb3ZlcmxpbWl0cyAwIHJlcXVldWVzIDI4KQo+Pj4g IGJhY2tsb2cgMGIgMHAgcmVxdWV1ZXMgMjgKPj4+IHFkaXNjIGZxX2NvZGVsIDgwMDE6IHBhcmVu dCA6MSBsaW1pdCAxMDI0cCBmbG93cyAxNiBxdWFudHVtIDE1MTQKPj4+IHRhcmdldCA4MC4wbXMg Y2VfdGhyZXNob2xkIDMydXMgaW50ZXJ2YWwgMTAwLjBtcyBlY24KPj4+ICBTZW50IDAgYnl0ZXMg MCBwa3QgKGRyb3BwZWQgMCwgb3ZlcmxpbWl0cyAwIHJlcXVldWVzIDApCj4+PiAgYmFja2xvZyAw YiAwcCByZXF1ZXVlcyAwCj4+PiAgIG1heHBhY2tldCAwIGRyb3Bfb3ZlcmxpbWl0IDAgbmV3X2Zs b3dfY291bnQgMCBlY25fbWFyayAwCj4+PiAgIG5ld19mbG93c19sZW4gMCBvbGRfZmxvd3NfbGVu IDAKPj4+IHFkaXNjIGZxX2NvZGVsIDgwMDI6IHBhcmVudCA6MiBsaW1pdCAxMDI0cCBmbG93cyAx NiBxdWFudHVtIDE1MTQKPj4+IHRhcmdldCA4MC4wbXMgY2VfdGhyZXNob2xkIDMydXMgaW50ZXJ2 YWwgMTAwLjBtcyBlY24KPj4+ICBTZW50IDAgYnl0ZXMgMCBwa3QgKGRyb3BwZWQgMCwgb3Zlcmxp bWl0cyAwIHJlcXVldWVzIDApCj4+PiAgYmFja2xvZyAwYiAwcCByZXF1ZXVlcyAwCj4+PiAgIG1h eHBhY2tldCAwIGRyb3Bfb3ZlcmxpbWl0IDAgbmV3X2Zsb3dfY291bnQgMCBlY25fbWFyayAwCj4+ PiAgIG5ld19mbG93c19sZW4gMCBvbGRfZmxvd3NfbGVuIDAKPj4+IHFkaXNjIGZxX2NvZGVsIDgw MDM6IHBhcmVudCA6MyBsaW1pdCAxMDI0cCBmbG93cyAxNiBxdWFudHVtIDE1MTQKPj4+IHRhcmdl dCA4MC4wbXMgY2VfdGhyZXNob2xkIDMydXMgaW50ZXJ2YWwgMTAwLjBtcyBlY24KPj4+ICBTZW50 IDMwODQ5OTYwNTIgYnl0ZXMgMjAzNzc0NCBwa3QgKGRyb3BwZWQgMjc3MDE3Niwgb3ZlcmxpbWl0 cyAwIHJlcXVldWVzIDI4KQo+Pj4gIGJhY2tsb2cgMGIgMHAgcmVxdWV1ZXMgMjgKPj4+ICAgbWF4 cGFja2V0IDE1MTQgZHJvcF9vdmVybGltaXQgMjc3MDE3NiBuZXdfZmxvd19jb3VudCA2NCBlY25f bWFyayAwCj4+PiAgIG5ld19mbG93c19sZW4gMCBvbGRfZmxvd3NfbGVuIDEKPj4+IHFkaXNjIGZx X2NvZGVsIDgwMDQ6IHBhcmVudCA6NCBsaW1pdCAxMDI0cCBmbG93cyAxNiBxdWFudHVtIDE1MTQK Pj4+IHRhcmdldCA4MC4wbXMgY2VfdGhyZXNob2xkIDMydXMgaW50ZXJ2YWwgMTAwLjBtcyBlY24K Pj4+ICBTZW50IDAgYnl0ZXMgMCBwa3QgKGRyb3BwZWQgMCwgb3ZlcmxpbWl0cyAwIHJlcXVldWVz IDApCj4+PiAgYmFja2xvZyAwYiAwcCByZXF1ZXVlcyAwCj4+PiAgIG1heHBhY2tldCAwIGRyb3Bf b3ZlcmxpbWl0IDAgbmV3X2Zsb3dfY291bnQgMCBlY25fbWFyayAwCj4+PiAgIG5ld19mbG93c19s ZW4gMCBvbGRfZmxvd3NfbGVuIDAKPj4+Cj4+Pgo+Pj4+IElGIHlvdSBhcmUgZG9pbmcgYnVpbGRz IGZvciB0aGUgYXJjaGVyIGM3djIsIEkgY2FuIGpvaW4gaW4gb24gdGhpcy4uLiAoPykKPj4+Cj4+ PiBJJ20gbm90IGJ1dCBJIGhhdmUgYzcgc29tZXdoZXJlLCBzbyBJIGNhbiBkbyBhIGJ1aWxkIGZv ciBpdCBhbmQgYWxzbwo+Pj4gdGVzdCwgc28gd2UgYXJlIG9uIHRoZSBzYW1lIHBhZ2UuCj4+Pgo+ Pj4+IEkgZGlkIGRvIGEgdGVzdCBvZiB0aGUgYXRoMTBrICJiZWZvcmUiLCBmcV9jb2RlbCAqbmV2 ZXIgZW5nYWdlZCosIGFuZAo+Pj4+IHRjcCBpbmR1Y2VkIGxhdGVuY2llcyB1bmRlciBsb2FkLCBl IGF0IDEwMG1iaXQsIGNyYWNrZWQgNjAwbXMsIHdoaWxlCj4+Pj4gc3RheWluZyBmbGF0ICgyMG1z KSBhdCAxMDBtYml0LiAobm90IHRoZSBzYW1lIHBhdGNoZXMgeW91IGFyZSB0ZXN0aW5nKQo+Pj4+ IG9uIHg4Ni4gSSBoYXZlIGdvdCB0Y3AgMzAwTWJpdCBvdXQgb2YgYW4gb3N4IGJveCwgc2ltaWxh ciBsYXRlbmN5LAo+Pj4+IGhhdmUgeWV0IHRvIGdldCBhbnl0aGluZyBtb3JlIG9uIGFueXRoaW5n IEkgY3VycmVudGx5IGhhdmUKPj4+PiBiZWZvcmUvYWZ0ZXIgcGF0Y2hzZXRzLgo+Pj4+Cj4+Pj4g SSdsbCBnbyBhZGQgZmxvb2RpbmcgdG8gdGhlIHRlc3RzLCBJIGp1c3QgZmluaXNoZWQgYSBzZXJp ZXMgY29tcGFyaW5nCj4+Pj4gdHdvIGRpZmZlcmVudCBzcGVlZCBzdGF0aW9ucyBhbmQgbGlmZSB3 YXMgZ29vZCBvbiB0aGF0Lgo+Pj4+Cj4+Pj4gImJlZm9yZSIgLSBmcV9jb2RlbCBuZXZlciBlbmdh Z2VzLCB3ZSBzZWUgc2Vjb25kcyBvZiBsYXRlbmN5IHVuZGVyIGxvYWQuCj4+Pj4KPj4+PiByb290 QGFwdTI6fiMgdGMgLXMgcWRpc2Mgc2hvdyBkZXYgd2xwNHMwCj4+Pj4gcWRpc2MgbXEgMDogcm9v dAo+Pj4+ICBTZW50IDg1NzA1NjM4OTMgYnl0ZXMgNjMyNjk4MyBwa3QgKGRyb3BwZWQgMCwgb3Zl cmxpbWl0cyAwIHJlcXVldWVzIDApCj4+Pj4gIGJhY2tsb2cgMGIgMHAgcmVxdWV1ZXMgMAo+Pj4+ IHFkaXNjIGZxX2NvZGVsIDA6IHBhcmVudCA6MSBsaW1pdCAxMDI0MHAgZmxvd3MgMTAyNCBxdWFu dHVtIDE1MTQKPj4+PiB0YXJnZXQgNS4wbXMgaW50ZXJ2YWwgMTAwLjBtcyBlY24KPj4+PiAgU2Vu dCAyMjYyIGJ5dGVzIDE3IHBrdCAoZHJvcHBlZCAwLCBvdmVybGltaXRzIDAgcmVxdWV1ZXMgMCkK Pj4+PiAgYmFja2xvZyAwYiAwcCByZXF1ZXVlcyAwCj4+Pj4gICBtYXhwYWNrZXQgMCBkcm9wX292 ZXJsaW1pdCAwIG5ld19mbG93X2NvdW50IDAgZWNuX21hcmsgMAo+Pj4+ICAgbmV3X2Zsb3dzX2xl biAwIG9sZF9mbG93c19sZW4gMAo+Pj4+IHFkaXNjIGZxX2NvZGVsIDA6IHBhcmVudCA6MiBsaW1p dCAxMDI0MHAgZmxvd3MgMTAyNCBxdWFudHVtIDE1MTQKPj4+PiB0YXJnZXQgNS4wbXMgaW50ZXJ2 YWwgMTAwLjBtcyBlY24KPj4+PiAgU2VudCAyMjA0ODY1NjkgYnl0ZXMgMTUyMDU4IHBrdCAoZHJv cHBlZCAwLCBvdmVybGltaXRzIDAgcmVxdWV1ZXMgMCkKPj4+PiAgYmFja2xvZyAwYiAwcCByZXF1 ZXVlcyAwCj4+Pj4gICBtYXhwYWNrZXQgMTgxNjggZHJvcF9vdmVybGltaXQgMCBuZXdfZmxvd19j b3VudCAxIGVjbl9tYXJrIDAKPj4+PiAgIG5ld19mbG93c19sZW4gMCBvbGRfZmxvd3NfbGVuIDEK Pj4+PiBxZGlzYyBmcV9jb2RlbCAwOiBwYXJlbnQgOjMgbGltaXQgMTAyNDBwIGZsb3dzIDEwMjQg cXVhbnR1bSAxNTE0Cj4+Pj4gdGFyZ2V0IDUuMG1zIGludGVydmFsIDEwMC4wbXMgZWNuCj4+Pj4g IFNlbnQgODM0MDU0NjUwOSBieXRlcyA2MTYzNDMxIHBrdCAoZHJvcHBlZCAwLCBvdmVybGltaXRz IDAgcmVxdWV1ZXMgMCkKPj4+PiAgYmFja2xvZyAwYiAwcCByZXF1ZXVlcyAwCj4+Pj4gICBtYXhw YWNrZXQgNjgxMzAgZHJvcF9vdmVybGltaXQgMCBuZXdfZmxvd19jb3VudCAxMjAwNTAgZWNuX21h cmsgMAo+Pj4+ICAgbmV3X2Zsb3dzX2xlbiAxIG9sZF9mbG93c19sZW4gMwo+Pj4+IHFkaXNjIGZx X2NvZGVsIDA6IHBhcmVudCA6NCBsaW1pdCAxMDI0MHAgZmxvd3MgMTAyNCBxdWFudHVtIDE1MTQK Pj4+PiB0YXJnZXQgNS4wbXMgaW50ZXJ2YWwgMTAwLjBtcyBlY24KPj4+PiAgU2VudCA5NTI4NTUz IGJ5dGVzIDExNDc3IHBrdCAoZHJvcHBlZCAwLCBvdmVybGltaXRzIDAgcmVxdWV1ZXMgMCkKPj4+ PiAgYmFja2xvZyAwYiAwcCByZXF1ZXVlcyAwCj4+Pj4gICBtYXhwYWNrZXQgNjYgZHJvcF9vdmVy bGltaXQgMCBuZXdfZmxvd19jb3VudCAxIGVjbl9tYXJrIDAKPj4+PiAgIG5ld19mbG93c19sZW4g MSBvbGRfZmxvd3NfbGVuIDAKPj4+PiAgIGBgYAo+Pj4+Cj4+Pj4KPj4+Pj4+IFRoaXMgaXMgY2Vy dGFpbmx5IGJldHRlciB0aGFuIDMwTWJwcyBidXQgc3RpbGwgbW9yZSB0aGFuIHR3byB0aW1lcwo+ Pj4+Pj4gbGVzcyB0aGFuIGJlZm9yZSAoOTAwKS4KPj4+Pgo+Pj4+IFRoZSBudW1iZXIgdGhhdCBJ IHN0aWxsIGFtIG5vdCBzdXJlIHdlIGdvdCBpcyB0aGF0IHlvdSB3ZXJlIHNlbmRpbmcKPj4+PiA5 MDBtYml0IHVkcCBhbmQgcmVjaWV2aW5nIDkwMG1iaXQgb24gdGhlIHByaW9yIHRlc3RzPwo+Pj4K Pj4+IDkwMCB3YXMgc2VuZGluZywgQVAgUE9WICh3aWZpIGNsaWVudCBpcyBkb3dubG9hZGluZykK Pj4+Cj4+Pj4+PiBUQ1AgYWxzbyBpbXByb3ZlZCBhIGxpdHRsZSAoNTUwIHRvIH41OTApLgo+Pj4+ Cj4+Pj4gVGhlIGxpbWl0IGlzIHByb2JhYmx5IGEgYml0IGxvdywgYWxzby4gIFlvdSBtaWdodCB3 YW50IHRvIHRyeSB0YXJnZXQKPj4+PiAyMG1zIGFzIHdlbGwuCj4+Pgo+Pj4gSSd2ZSB0cmllZCBs aW1pdCB1cCB0byAxMDI0IGFuZCB0YXJnZXQgdXAgdG8gODBtcwo+Pj4KPj4+Pj4+Cj4+Pj4+PiBG ZWxpeCwgb3RoZXJzLCBkbyB5b3Ugd2FudCB0byBzZWUgdGhlIHBvcnRlZCBwYXRjaCwgbWF5YmUg SSBkaWQgc29tZXRoaW5nIHdyb25nPwo+Pj4+Pj4gRG9lc24ndCBsb29rIGxpa2UgaXQgd2lsbCBz YXZlIGF0aDEwayBmcm9tIHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24uCj4+Pj4KPj4+PiB3aGF0IHdh cyB0Y3AgImJlZm9yZSI/IChJJ20gc29ycnksIHN1Y2ggYSBsb25nIHRocmVhZCkKPj4+Cj4+PiA3 NTBNYnBzCj4+Cj4+IE1pY2hhbCwgYWZ0ZXIgcmV0ZXN0aW5nIHdpdGggeW91ciBwYXRjaCAoc29y cnksIGl0IHdhcyBsYXRlIHllc3RlcmRheSwKPj4gY29uZnVzZWQgY29tcGF0LXdpcmVsZXNzIGFy Y2hpdmVzKSBJIHNhdyB0aGUgZGlmZmVyZW5jZS4KPj4gU28gdGhlIHByb2dyZXNzIGxvb2tzIGxp a2UgdGhpcyAoYWxsIHdpdGggZnFfY29kZWwgZmxvd3MgMTYgbGltaXQgMTAyNAo+PiB0YXJnZXQg MjBtcyk6Cj4+IG5vIHBhdGNoZXM6IDM4ME1icHMgVURQLCA1NTAgVENQCj4+IEVyaWMncyAoZnFf Y29kZWwgZHJvcCkgcGF0Y2g6IDQyME1icHMgVURQLCA1OTAgVENQICgrNDBNYnBzKSwgbGF0ZW5j eQo+PiA1LTZtcyBkdXJpbmcgdGVzdAo+PiBNaWNoYWwncyAoaW1wcm92ZSB0eCBzY2hlZHVsaW5n KSBwYXRjaDogNTgwTWJwcyBVRFAsIDY2MCBUQ1AsIGxhdGVuY3kKPj4gdXAgdG8gMzAtNDBtcyBk dXJpbmcgdGVzdAo+PiBhZnRlciBSYWprdW1hcidzIHByb3Bvc2FsIHRvICJ0cnkgd2l0aG91dCBy ZWdpc3RlcmluZyB3YWtlX3R4X3F1ZXVlCj4+IGNhbGxiYWNrIjogODIwTWJwcyBVRFAsIDY5MCBU Q1AuCj4KPiBBbmQgdGhlIHNpbXVsdGFuZW91cyBwaW5nIG9uIHRoZSBsYXN0IHRlc3Qgd2FzPwoK c2FtZSBhcyBwcmV2aW91czogMzAtNDBtcwoKUmVnYXJkcywKUm9tYW4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQ29kZWwgbWFpbGluZyBsaXN0CkNvZGVs QGxpc3RzLmJ1ZmZlcmJsb2F0Lm5ldApodHRwczovL2xpc3RzLmJ1ZmZlcmJsb2F0Lm5ldC9saXN0 aW5mby9jb2RlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b2OU5-0004Pe-Tg for ath10k@lists.infradead.org; Mon, 16 May 2016 19:47:23 +0000 Received: by mail-oi0-x22a.google.com with SMTP id k142so285270601oib.1 for ; Mon, 16 May 2016 12:47:00 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1462125592.5535.194.camel@edumazet-glaptop3.roam.corp.google.com> <865DA393-262D-40B6-A9D3-1B978CD5F6C6@gmail.com> <1462128385.5535.200.camel@edumazet-glaptop3.roam.corp.google.com> <1462136140.5535.219.camel@edumazet-glaptop3.roam.corp.google.com> <1462201620.5535.250.camel@edumazet-glaptop3.roam.corp.google.com> <1462205669.5535.254.camel@edumazet-glaptop3.roam.corp.google.com> <1462464776.13075.18.camel@edumazet-glaptop3.roam.corp.google.com> <1462476207.13075.20.camel@edumazet-glaptop3.roam.corp.google.com> <20160506114243.4eb4f95e@redhat.com> <20160506144740.210901f5@redhat.com> Date: Mon, 16 May 2016 22:46:59 +0300 Message-ID: Subject: Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood) From: Roman Yeryomin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Dave Taht Cc: Rajkumar Manoharan , make-wifi-fast@lists.bufferbloat.net, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , ath10k , "netdev@vger.kernel.org" , "codel@lists.bufferbloat.net" , Michal Kazior , Jesper Dangaard Brouer , Jonathan Morton , OpenWrt Development List , Felix Fietkau On 16 May 2016 at 19:04, Dave Taht wrote: > On Mon, May 16, 2016 at 1:14 AM, Roman Yeryomin wrote: >> On 16 May 2016 at 01:34, Roman Yeryomin wrote: >>> On 6 May 2016 at 22:43, Dave Taht wrote: >>>> On Fri, May 6, 2016 at 11:56 AM, Roman Yeryomin wrote: >>>>> On 6 May 2016 at 21:43, Roman Yeryomin wrote: >>>>>> On 6 May 2016 at 15:47, Jesper Dangaard Brouer wrote: >>>>>>> >>>>>>> I've created a OpenWRT ticket[1] on this issue, as it seems that someone[2] >>>>>>> closed Felix'es OpenWRT email account (bad choice! emails bouncing). >>>>>>> Sounds like OpenWRT and the LEDE https://www.lede-project.org/ project >>>>>>> is in some kind of conflict. >>>>>>> >>>>>>> OpenWRT ticket [1] https://dev.openwrt.org/ticket/22349 >>>>>>> >>>>>>> [2] http://thread.gmane.org/gmane.comp.embedded.openwrt.devel/40298/focus=40335 >>>>>> >>>>>> OK, so, after porting the patch to 4.1 openwrt kernel and playing a >>>>>> bit with fq_codel limits I was able to get 420Mbps UDP like this: >>>>>> tc qdisc replace dev wlan0 parent :1 fq_codel flows 16 limit 256 >>>>> >>>>> Forgot to mention, I've reduced drop_batch_size down to 32 >>>> >>>> 0) Not clear to me if that's the right line, there are 4 wifi queues, >>>> and the third one >>>> is the BE queue. >>> >>> That was an example, sorry, should have stated that. I've applied same >>> settings to all 4 queues. >>> >>>> That is too low a limit, also, for normal use. And: >>>> for the purpose of this particular UDP test, flows 16 is ok, but not >>>> ideal. >>> >>> I played with different combinations, it doesn't make any >>> (significant) difference: 20-30Mbps, not more. >>> What numbers would you propose? >>> >>>> 1) What's the tcp number (with a simultaneous ping) with this latest patchset? >>>> (I care about tcp performance a lot more than udp floods - surviving a >>>> udp flood yes, performance, no) >>> >>> During the test (both TCP and UDP) it's roughly 5ms in average, not >>> running tests ~2ms. Actually I'm now wondering if target is working at >>> all, because I had same result with target 80ms.. >>> So, yes, latency is good, but performance is poor. >>> >>>> before/after? >>>> >>>> tc -s qdisc show dev wlan0 during/after results? >>> >>> during the test: >>> >>> qdisc mq 0: root >>> Sent 1600496000 bytes 1057194 pkt (dropped 1421568, overlimits 0 requeues 17) >>> backlog 1545794b 1021p requeues 17 >>> qdisc fq_codel 8001: parent :1 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >>> backlog 0b 0p requeues 0 >>> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 >>> new_flows_len 0 old_flows_len 0 >>> qdisc fq_codel 8002: parent :2 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >>> backlog 0b 0p requeues 0 >>> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 >>> new_flows_len 0 old_flows_len 0 >>> qdisc fq_codel 8003: parent :3 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 1601271168 bytes 1057706 pkt (dropped 1422304, overlimits 0 requeues 17) >>> backlog 1541252b 1018p requeues 17 >>> maxpacket 1514 drop_overlimit 1422304 new_flow_count 35 ecn_mark 0 >>> new_flows_len 0 old_flows_len 1 >>> qdisc fq_codel 8004: parent :4 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >>> backlog 0b 0p requeues 0 >>> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 >>> new_flows_len 0 old_flows_len 0 >>> >>> >>> after the test (60sec): >>> >>> qdisc mq 0: root >>> Sent 3084996052 bytes 2037744 pkt (dropped 2770176, overlimits 0 requeues 28) >>> backlog 0b 0p requeues 28 >>> qdisc fq_codel 8001: parent :1 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >>> backlog 0b 0p requeues 0 >>> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 >>> new_flows_len 0 old_flows_len 0 >>> qdisc fq_codel 8002: parent :2 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >>> backlog 0b 0p requeues 0 >>> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 >>> new_flows_len 0 old_flows_len 0 >>> qdisc fq_codel 8003: parent :3 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 3084996052 bytes 2037744 pkt (dropped 2770176, overlimits 0 requeues 28) >>> backlog 0b 0p requeues 28 >>> maxpacket 1514 drop_overlimit 2770176 new_flow_count 64 ecn_mark 0 >>> new_flows_len 0 old_flows_len 1 >>> qdisc fq_codel 8004: parent :4 limit 1024p flows 16 quantum 1514 >>> target 80.0ms ce_threshold 32us interval 100.0ms ecn >>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >>> backlog 0b 0p requeues 0 >>> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 >>> new_flows_len 0 old_flows_len 0 >>> >>> >>>> IF you are doing builds for the archer c7v2, I can join in on this... (?) >>> >>> I'm not but I have c7 somewhere, so I can do a build for it and also >>> test, so we are on the same page. >>> >>>> I did do a test of the ath10k "before", fq_codel *never engaged*, and >>>> tcp induced latencies under load, e at 100mbit, cracked 600ms, while >>>> staying flat (20ms) at 100mbit. (not the same patches you are testing) >>>> on x86. I have got tcp 300Mbit out of an osx box, similar latency, >>>> have yet to get anything more on anything I currently have >>>> before/after patchsets. >>>> >>>> I'll go add flooding to the tests, I just finished a series comparing >>>> two different speed stations and life was good on that. >>>> >>>> "before" - fq_codel never engages, we see seconds of latency under load. >>>> >>>> root@apu2:~# tc -s qdisc show dev wlp4s0 >>>> qdisc mq 0: root >>>> Sent 8570563893 bytes 6326983 pkt (dropped 0, overlimits 0 requeues 0) >>>> backlog 0b 0p requeues 0 >>>> qdisc fq_codel 0: parent :1 limit 10240p flows 1024 quantum 1514 >>>> target 5.0ms interval 100.0ms ecn >>>> Sent 2262 bytes 17 pkt (dropped 0, overlimits 0 requeues 0) >>>> backlog 0b 0p requeues 0 >>>> maxpacket 0 drop_overlimit 0 new_flow_count 0 ecn_mark 0 >>>> new_flows_len 0 old_flows_len 0 >>>> qdisc fq_codel 0: parent :2 limit 10240p flows 1024 quantum 1514 >>>> target 5.0ms interval 100.0ms ecn >>>> Sent 220486569 bytes 152058 pkt (dropped 0, overlimits 0 requeues 0) >>>> backlog 0b 0p requeues 0 >>>> maxpacket 18168 drop_overlimit 0 new_flow_count 1 ecn_mark 0 >>>> new_flows_len 0 old_flows_len 1 >>>> qdisc fq_codel 0: parent :3 limit 10240p flows 1024 quantum 1514 >>>> target 5.0ms interval 100.0ms ecn >>>> Sent 8340546509 bytes 6163431 pkt (dropped 0, overlimits 0 requeues 0) >>>> backlog 0b 0p requeues 0 >>>> maxpacket 68130 drop_overlimit 0 new_flow_count 120050 ecn_mark 0 >>>> new_flows_len 1 old_flows_len 3 >>>> qdisc fq_codel 0: parent :4 limit 10240p flows 1024 quantum 1514 >>>> target 5.0ms interval 100.0ms ecn >>>> Sent 9528553 bytes 11477 pkt (dropped 0, overlimits 0 requeues 0) >>>> backlog 0b 0p requeues 0 >>>> maxpacket 66 drop_overlimit 0 new_flow_count 1 ecn_mark 0 >>>> new_flows_len 1 old_flows_len 0 >>>> ``` >>>> >>>> >>>>>> This is certainly better than 30Mbps but still more than two times >>>>>> less than before (900). >>>> >>>> The number that I still am not sure we got is that you were sending >>>> 900mbit udp and recieving 900mbit on the prior tests? >>> >>> 900 was sending, AP POV (wifi client is downloading) >>> >>>>>> TCP also improved a little (550 to ~590). >>>> >>>> The limit is probably a bit low, also. You might want to try target >>>> 20ms as well. >>> >>> I've tried limit up to 1024 and target up to 80ms >>> >>>>>> >>>>>> Felix, others, do you want to see the ported patch, maybe I did something wrong? >>>>>> Doesn't look like it will save ath10k from performance regression. >>>> >>>> what was tcp "before"? (I'm sorry, such a long thread) >>> >>> 750Mbps >> >> Michal, after retesting with your patch (sorry, it was late yesterday, >> confused compat-wireless archives) I saw the difference. >> So the progress looks like this (all with fq_codel flows 16 limit 1024 >> target 20ms): >> no patches: 380Mbps UDP, 550 TCP >> Eric's (fq_codel drop) patch: 420Mbps UDP, 590 TCP (+40Mbps), latency >> 5-6ms during test >> Michal's (improve tx scheduling) patch: 580Mbps UDP, 660 TCP, latency >> up to 30-40ms during test >> after Rajkumar's proposal to "try without registering wake_tx_queue >> callback": 820Mbps UDP, 690 TCP. > > And the simultaneous ping on the last test was? same as previous: 30-40ms Regards, Roman _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k