All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Tulak <jtulak@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] xfstests: Fix installation for extended names
Date: Thu, 30 Jun 2016 17:19:53 +0200	[thread overview]
Message-ID: <CACj3i70ZOVyMiw9z0RJSDAgpWHgLGFSbBFD=xL9OZrV6XAca9w@mail.gmail.com> (raw)
In-Reply-To: <20160630133346.GE23649@eguan.usersys.redhat.com>

On Thu, Jun 30, 2016 at 3:33 PM, Eryu Guan <eguan@redhat.com> wrote:
> On Thu, Jun 30, 2016 at 10:35:10AM +0200, Jan Tulak wrote:
>> xfstests supports extended test names like 314-foo-bar, but installation of
>> these tests was skipped (not matching a regexp). So this patch fixes the
>> makefiles in tests directories.
>>
>> Signed-off-by: Jan Tulak <jtulak@redhat.com>
>> ---
>> UPDATE:
>>   * install failed when no extended name was present, so suppress errors for
>>     extended names
>
> Hmm, this looks ugly to me :) I was thinking about it too, but didn't
> work out a better idea. Now I tend to add this installation support to
> tests/xfs/Makefile only, and we can add the support to other tests when
> needed. What do you think?
>

Yeah. I thought about better regexp, but unfortunately, whatever sh
Make uses, it has just limited support for that, unlike bash. So, yes,
add it for xfs tests only... Should I send another patch for that?

Thanks,
Jan

-- 
Jan Tulak
jtulak@redhat.com / jan@tulak.me

  reply	other threads:[~2016-06-30 15:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 14:57 [PATCH] xfstests: Fix installation for extended names Jan Tulak
2016-06-30  3:38 ` Eryu Guan
2016-06-30  8:32   ` Jan Tulak
2016-06-30  8:35 ` [PATCH v2] " Jan Tulak
2016-06-30 13:33   ` Eryu Guan
2016-06-30 15:19     ` Jan Tulak [this message]
2016-06-30 15:35       ` Eryu Guan
2016-06-30 16:06 ` [PATCH v3] xfstests: Fix installation for extended Jan Tulak
2016-06-30 16:08   ` Jan Tulak
2016-06-30 16:21     ` Eryu Guan
2016-07-01  1:16   ` Dave Chinner
2016-07-01 15:51     ` Jan Tulak
2016-07-14 12:43 [PATCH 0/6 v3] xfstests: some small fixes and mkfs validation test Jan Tulak
2016-07-18  8:47 ` [PATCH v2] xfstests: Fix installation for extended names Jan Tulak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACj3i70ZOVyMiw9z0RJSDAgpWHgLGFSbBFD=xL9OZrV6XAca9w@mail.gmail.com' \
    --to=jtulak@redhat.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.