From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751569AbaHTOYH (ORCPT ); Wed, 20 Aug 2014 10:24:07 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:37716 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbaHTOYF (ORCPT ); Wed, 20 Aug 2014 10:24:05 -0400 MIME-Version: 1.0 In-Reply-To: <1408473119.5604.4.camel@edumazet-glaptop2.roam.corp.google.com> References: <1408459784-9385-1-git-send-email-jonas.jensen@gmail.com> <1408459784-9385-2-git-send-email-jonas.jensen@gmail.com> <1408473119.5604.4.camel@edumazet-glaptop2.roam.corp.google.com> Date: Wed, 20 Aug 2014 16:24:04 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy() From: Jonas Jensen To: Eric Dumazet Cc: netdev , davem , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Florian Fainelli Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19 August 2014 20:31, Eric Dumazet wrote: > Instead of : > > priv->rx_buf_size = RX_BUF_SIZE + > SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); > > I think rx_buf_size can now be RX_BUF_SIZE You're right, that's now a remnant, see update in v5. > Another point is that priv->stats seems not needed, as ndev->stats could > be used instead (and remove moxart_mac_get_stats()) I will fix that. I can add it to patches adding support for ethtool / stats and PHY. I think I'm supposed to post those closer to the merge window, which would keep this set about bug fixes only. Regards, Jonas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonas Jensen Subject: Re: [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy() Date: Wed, 20 Aug 2014 16:24:04 +0200 Message-ID: References: <1408459784-9385-1-git-send-email-jonas.jensen@gmail.com> <1408459784-9385-2-git-send-email-jonas.jensen@gmail.com> <1408473119.5604.4.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: netdev , davem , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Florian Fainelli To: Eric Dumazet Return-path: Received: from mail-ig0-f182.google.com ([209.85.213.182]:37716 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbaHTOYF (ORCPT ); Wed, 20 Aug 2014 10:24:05 -0400 In-Reply-To: <1408473119.5604.4.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On 19 August 2014 20:31, Eric Dumazet wrote: > Instead of : > > priv->rx_buf_size = RX_BUF_SIZE + > SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); > > I think rx_buf_size can now be RX_BUF_SIZE You're right, that's now a remnant, see update in v5. > Another point is that priv->stats seems not needed, as ndev->stats could > be used instead (and remove moxart_mac_get_stats()) I will fix that. I can add it to patches adding support for ethtool / stats and PHY. I think I'm supposed to post those closer to the merge window, which would keep this set about bug fixes only. Regards, Jonas From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonas.jensen@gmail.com (Jonas Jensen) Date: Wed, 20 Aug 2014 16:24:04 +0200 Subject: [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy() In-Reply-To: <1408473119.5604.4.camel@edumazet-glaptop2.roam.corp.google.com> References: <1408459784-9385-1-git-send-email-jonas.jensen@gmail.com> <1408459784-9385-2-git-send-email-jonas.jensen@gmail.com> <1408473119.5604.4.camel@edumazet-glaptop2.roam.corp.google.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 19 August 2014 20:31, Eric Dumazet wrote: > Instead of : > > priv->rx_buf_size = RX_BUF_SIZE + > SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); > > I think rx_buf_size can now be RX_BUF_SIZE You're right, that's now a remnant, see update in v5. > Another point is that priv->stats seems not needed, as ndev->stats could > be used instead (and remove moxart_mac_get_stats()) I will fix that. I can add it to patches adding support for ethtool / stats and PHY. I think I'm supposed to post those closer to the merge window, which would keep this set about bug fixes only. Regards, Jonas