From: George Hilliard <thirtythreeforty@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a single time during probe
Date: Tue, 26 Mar 2019 19:46:36 -0600 [thread overview]
Message-ID: <CACmrr9iqK-g8o3tAAHD3NDy+9BiOkoXH+vFMT+stG37iZ2Zp5g@mail.gmail.com> (raw)
In-Reply-To: <20190327004603.GA28785@kroah.com>
On Tue, Mar 26, 2019 at 6:46 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Mar 26, 2019 at 09:21:39AM -0600, George Hilliard wrote:
> > - init_completion(&host->cmd_done);
> > + // The completion should have been consumed by the previous command
> > + // response handler, because the mmc requests should be serialized
> > + if(completion_done(&host->cmd_done))
>
> Did you run your patch through checkpatch.pl? It should have reported
> an error here :(
No, I didn't. My mistake, sorry. Will fix up and resend again.
George
prev parent reply other threads:[~2019-03-27 1:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:21 [PATCH v4 0/2] staging: mt7621-mmc: correctness fixes George Hilliard
2019-03-26 15:21 ` [PATCH v4 1/2] staging: mt7621-mmc: Remove obsolete Kconfig flags George Hilliard
2019-03-26 15:21 ` [PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a single time during probe George Hilliard
2019-03-27 0:46 ` Greg Kroah-Hartman
2019-03-27 1:46 ` George Hilliard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACmrr9iqK-g8o3tAAHD3NDy+9BiOkoXH+vFMT+stG37iZ2Zp5g@mail.gmail.com \
--to=thirtythreeforty@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.