From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751570AbdB1UpR (ORCPT ); Tue, 28 Feb 2017 15:45:17 -0500 Received: from mail-ot0-f169.google.com ([74.125.82.169]:33266 "EHLO mail-ot0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdB1UpO (ORCPT ); Tue, 28 Feb 2017 15:45:14 -0500 MIME-Version: 1.0 In-Reply-To: <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> References: <1488313886-17155-1-git-send-email-jon.mason@broadcom.com> <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Tue, 28 Feb 2017 21:43:09 +0100 Message-ID: Subject: Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT To: Jon Mason Cc: Hauke Mehrtens , Rob Herring , Mark Rutland , Florian Fainelli , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , bcm-kernel-feedback-list , Jon Mason Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1SKjLuk008211 On 28 February 2017 at 21:31, Jon Mason wrote: > @@ -70,10 +70,19 @@ > clocks = <&periph_clk>; > }; > > - local-timer@20600 { > + timer@20600 { Is there a reason for this rename? I don't really have preference for any name, it's just we shouldn't keep renaming this depending of personal preferences. It also doesn't seem like adjusting to any schema: bcm63138.dtsi uses local-timer@1e600 bcm-nsp.dtsi uses twd-timer@20600 berlin2cd.dtsi uses local-timer@ad0600 berlin2.dtsi uses local-timer@ad0600 berlin2q.dtsi uses local-timer@ad0600 > compatible = "arm,cortex-a9-twd-timer"; > - reg = <0x20600 0x100>; > - interrupts = ; > + reg = <0x20600 0x20>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + clocks = <&periph_clk>; > + }; The rest looks OK, thanks! :) -- Rafał From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT Date: Tue, 28 Feb 2017 21:43:09 +0100 Message-ID: References: <1488313886-17155-1-git-send-email-jon.mason@broadcom.com> <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jon Mason Cc: Mark Rutland , "devicetree@vger.kernel.org" , Florian Fainelli , Jon Mason , Hauke Mehrtens , Linux Kernel Mailing List , Rob Herring , bcm-kernel-feedback-list , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org T24gMjggRmVicnVhcnkgMjAxNyBhdCAyMTozMSwgSm9uIE1hc29uIDxqb24ubWFzb25AYnJvYWRj b20uY29tPiB3cm90ZToKPiBAQCAtNzAsMTAgKzcwLDE5IEBACj4gICAgICAgICAgICAgICAgICAg ICAgICAgY2xvY2tzID0gPCZwZXJpcGhfY2xrPjsKPiAgICAgICAgICAgICAgICAgfTsKPgo+IC0g ICAgICAgICAgICAgICBsb2NhbC10aW1lckAyMDYwMCB7Cj4gKyAgICAgICAgICAgICAgIHRpbWVy QDIwNjAwIHsKCklzIHRoZXJlIGEgcmVhc29uIGZvciB0aGlzIHJlbmFtZT8gSSBkb24ndCByZWFs bHkgaGF2ZSBwcmVmZXJlbmNlIGZvcgphbnkgbmFtZSwgaXQncyBqdXN0IHdlIHNob3VsZG4ndCBr ZWVwIHJlbmFtaW5nIHRoaXMgZGVwZW5kaW5nIG9mCnBlcnNvbmFsIHByZWZlcmVuY2VzLgoKSXQg YWxzbyBkb2Vzbid0IHNlZW0gbGlrZSBhZGp1c3RpbmcgdG8gYW55IHNjaGVtYToKYmNtNjMxMzgu ZHRzaSB1c2VzIGxvY2FsLXRpbWVyQDFlNjAwCmJjbS1uc3AuZHRzaSB1c2VzIHR3ZC10aW1lckAy MDYwMApiZXJsaW4yY2QuZHRzaSB1c2VzIGxvY2FsLXRpbWVyQGFkMDYwMApiZXJsaW4yLmR0c2kg dXNlcyBsb2NhbC10aW1lckBhZDA2MDAKYmVybGluMnEuZHRzaSB1c2VzIGxvY2FsLXRpbWVyQGFk MDYwMAoKCj4gICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJhcm0sY29ydGV4 LWE5LXR3ZC10aW1lciI7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MjA2MDAg MHgxMDA+Owo+IC0gICAgICAgICAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1BQSSAx MyBJUlFfVFlQRV9MRVZFTF9ISUdIPjsKPiArICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8 MHgyMDYwMCAweDIwPjsKPiArICAgICAgICAgICAgICAgICAgICAgICBpbnRlcnJ1cHRzID0gPEdJ Q19QUEkgMTMgKEdJQ19DUFVfTUFTS19TSU1QTEUoMikgfAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSVJRX1RZUEVfTEVWRUxfSElHSCk+Owo+ICsg ICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmcGVyaXBoX2Nsaz47Cj4gKyAgICAgICAg ICAgICAgIH07CgpUaGUgcmVzdCBsb29rcyBPSywgdGhhbmtzISA6KQoKLS0gClJhZmHFggoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: zajec5@gmail.com (=?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?=) Date: Tue, 28 Feb 2017 21:43:09 +0100 Subject: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT In-Reply-To: <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> References: <1488313886-17155-1-git-send-email-jon.mason@broadcom.com> <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28 February 2017 at 21:31, Jon Mason wrote: > @@ -70,10 +70,19 @@ > clocks = <&periph_clk>; > }; > > - local-timer at 20600 { > + timer at 20600 { Is there a reason for this rename? I don't really have preference for any name, it's just we shouldn't keep renaming this depending of personal preferences. It also doesn't seem like adjusting to any schema: bcm63138.dtsi uses local-timer at 1e600 bcm-nsp.dtsi uses twd-timer at 20600 berlin2cd.dtsi uses local-timer at ad0600 berlin2.dtsi uses local-timer at ad0600 berlin2q.dtsi uses local-timer at ad0600 > compatible = "arm,cortex-a9-twd-timer"; > - reg = <0x20600 0x100>; > - interrupts = ; > + reg = <0x20600 0x20>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + clocks = <&periph_clk>; > + }; The rest looks OK, thanks! :) -- Rafa?