From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH v2 07/10] spi: bcm53xx: Implement the spi_mem interface Date: Mon, 7 May 2018 11:35:23 +0200 Message-ID: References: <20180410224439.9260-1-boris.brezillon@bootlin.com> <20180410224439.9260-8-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Yogesh Gaur , Vignesh R , Kamal Dasu , Richard Weinberger , Miquel Raynal , linux-spi , Peter Pan , Marek Vasut , Frieder Schrempf , Mark Brown , linux-mtd@lists.infradead.org, Cyrille Pitchen , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Maxime Chevallier , Sourav Poddar , Brian Norris , David Woodhouse To: Boris Brezillon Return-path: In-Reply-To: <20180410224439.9260-8-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org On 11 April 2018 at 00:44, Boris Brezillon wrote: > The spi_mem interface is meant to replace the spi_flash_read() one. > Implement the ->exec_op() method so that we can smoothly get rid of the > old interface. > > Note that the current ->flash_read() implementation looks a bit fragile > since it does not take the ->read_opcode passed by the spi-nor layer > into account, which means if might not work with all kind of NORs. > > Anyway, I left the logic unchanged and added a few extra checks to make > sure we're receiving something that looks like a NOR read operation. > > Signed-off-by: Boris Brezillon Actually, I've just sent [PATCH] spi: remove the older/duplicated bcm53xx driver https://patchwork.kernel.org/patch/10383719/ This patch can be probably dropped, as I expect spi-bcm53xx.c to disappear soon. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fFcYS-0006f6-Aj for linux-mtd@lists.infradead.org; Mon, 07 May 2018 09:35:37 +0000 Received: by mail-wm0-x243.google.com with SMTP id j5-v6so14136698wme.5 for ; Mon, 07 May 2018 02:35:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180410224439.9260-8-boris.brezillon@bootlin.com> References: <20180410224439.9260-1-boris.brezillon@bootlin.com> <20180410224439.9260-8-boris.brezillon@bootlin.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Mon, 7 May 2018 11:35:23 +0200 Message-ID: Subject: Re: [PATCH v2 07/10] spi: bcm53xx: Implement the spi_mem interface To: Boris Brezillon Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org, Miquel Raynal , Mark Brown , linux-spi , Yogesh Gaur , Vignesh R , Kamal Dasu , Maxime Chevallier , Peter Pan , Frieder Schrempf , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Sourav Poddar Content-Type: text/plain; charset="UTF-8" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11 April 2018 at 00:44, Boris Brezillon wrote: > The spi_mem interface is meant to replace the spi_flash_read() one. > Implement the ->exec_op() method so that we can smoothly get rid of the > old interface. > > Note that the current ->flash_read() implementation looks a bit fragile > since it does not take the ->read_opcode passed by the spi-nor layer > into account, which means if might not work with all kind of NORs. > > Anyway, I left the logic unchanged and added a few extra checks to make > sure we're receiving something that looks like a NOR read operation. > > Signed-off-by: Boris Brezillon Actually, I've just sent [PATCH] spi: remove the older/duplicated bcm53xx driver https://patchwork.kernel.org/patch/10383719/ This patch can be probably dropped, as I expect spi-bcm53xx.c to disappear soon.