From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbcANIpq (ORCPT ); Thu, 14 Jan 2016 03:45:46 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:33473 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbcANIpp (ORCPT ); Thu, 14 Jan 2016 03:45:45 -0500 MIME-Version: 1.0 In-Reply-To: <8128014.DbbgBtKY3z@wuerfel> References: <8128014.DbbgBtKY3z@wuerfel> Date: Thu, 14 Jan 2016 09:45:44 +0100 Message-ID: Subject: Re: [PATCH] ssb: host_soc depends on sprom From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Arnd Bergmann Cc: Kalle Valo , Hauke Mehrtens , Michael Buesch , "linux-mips@linux-mips.org" , Linux Kernel Mailing List , Network Development , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13 January 2016 at 23:51, Arnd Bergmann wrote: > Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' > from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in > a build failure unless at least one of the other drivers that selects > it is enabled: > > drivers/built-in.o: In function `ssb_host_soc_get_invariants': > (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' > > This adds the same select statement that is used elsewhere. > > Signed-off-by: Arnd Bergmann > Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") I missed this dependency, thanks, patch looks OK. From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH] ssb: host_soc depends on sprom Date: Thu, 14 Jan 2016 09:45:44 +0100 Message-ID: References: <8128014.DbbgBtKY3z@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Kalle Valo , Hauke Mehrtens , Michael Buesch , "linux-mips@linux-mips.org" , Linux Kernel Mailing List , Network Development , "linux-arm-kernel@lists.infradead.org" To: Arnd Bergmann Return-path: In-Reply-To: <8128014.DbbgBtKY3z@wuerfel> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: List-Id: netdev.vger.kernel.org On 13 January 2016 at 23:51, Arnd Bergmann wrote: > Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' > from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in > a build failure unless at least one of the other drivers that selects > it is enabled: > > drivers/built-in.o: In function `ssb_host_soc_get_invariants': > (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' > > This adds the same select statement that is used elsewhere. > > Signed-off-by: Arnd Bergmann > Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") I missed this dependency, thanks, patch looks OK. From mboxrd@z Thu Jan 1 00:00:00 1970 From: zajec5@gmail.com (=?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?=) Date: Thu, 14 Jan 2016 09:45:44 +0100 Subject: [PATCH] ssb: host_soc depends on sprom In-Reply-To: <8128014.DbbgBtKY3z@wuerfel> References: <8128014.DbbgBtKY3z@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13 January 2016 at 23:51, Arnd Bergmann wrote: > Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' > from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in > a build failure unless at least one of the other drivers that selects > it is enabled: > > drivers/built-in.o: In function `ssb_host_soc_get_invariants': > (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' > > This adds the same select statement that is used elsewhere. > > Signed-off-by: Arnd Bergmann > Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") I missed this dependency, thanks, patch looks OK.