From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from mail-pz0-f42.google.com ([209.85.210.42]:53082 "EHLO
	mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754198Ab1HZJTG convert rfc822-to-8bit (ORCPT
	<rfc822;linux-wireless@vger.kernel.org>);
	Fri, 26 Aug 2011 05:19:06 -0400
MIME-Version: 1.0
In-Reply-To: <1314349357.9624.3.camel@Joe-Laptop>
References: <927eab8b5c950c13991911cd4c16457a5d618bc7.1314252671.git.joe@perches.com>
	<CACna6ryWtZG9obyj0w=d5jrF-y1pYNmanhkze2F429kHCLCi=A@mail.gmail.com>
	<1314349357.9624.3.camel@Joe-Laptop>
Date: Fri, 26 Aug 2011 11:19:05 +0200
Message-ID: <CACna6rwvaxd4i0Gh0hFRsXhHKBBLgn+SeMEdM62qf=mT7aCzpA@mail.gmail.com> (sfid-20110826_111923_628549_F2FA031A)
Subject: Re: [PATCH] staging: brcmfmac: Consolidate debugging macros
From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Henry Ptasinski <henryp@broadcom.com>,
	linux-kernel@vger.kernel.org, Brett Rudley <brudley@broadcom.com>,
	Arend Van Spriel <arend@broadcom.com>,
	Roland Vossen <rvossen@broadcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
	devel@linuxdriverproject.org, Greg KH <gregkh@suse.de>,
	Kan Yan <kanyan@broadcom.com>, linux-wireless@vger.kernel.org,
	devel@driverdev.osuosl.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

W dniu 26 sierpnia 2011 11:02 użytkownik Joe Perches <joe@perches.com> napisał:
> On Fri, 2011-08-26 at 10:55 +0200, Rafał Miłecki wrote:
>> 2011/8/25 Joe Perches <joe@perches.com>:
>> > Convert multiple BRCMF_<debug_level> macros to a single
>> > brcmf_dbg(level, fmt, ...) macro.
>> I'm not sure if that "_dbg" suffix is a really good choice. You use
>> "_dbg" for all the kinds of messages, while "DEBUG" is already one
>> kind of messages.
>
> No, not really.  These _are_ debugging uses.
>
> The #include is called dhd_dbg.h and
> the whole block is guarded by
>
> #if defined(BCMDBG)
>
>> We have also other types like EMERG, ALERT, CRIT,
>> ERR, WARNING, NOTICE, INFO and DEBUG.
>
> Except for the last, those aren't debugging uses,
> these are.

It makes sense, maybe some messages should be just always printed. It
seems some of they may be important for common-user having problem
with his card. Just few random ones:
brcmf_dbg(ERROR, "device attach failed\n");
brcmf_dbg(ERROR, "Failed to enable F1 Err: 0x%08x\n", err_ret);
brcmf_dbg(ERROR, "MACEVENT: %s [unsupported version --> brcmf
version:%d dongle version:%d]\n",
brcmf_dbg(ERROR, "mismatched OUI, bailing\n");
brcmf_dbg(ERROR, "brcmf_net_attach failed, err %d\n",
brcmf_dbg(ERROR, "failed to bring up cfg80211\n");
brcmf_dbg(ERROR, "HT Avail request error: %d\n", err);

-- 
Rafał