From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752804AbbCPIfE (ORCPT ); Mon, 16 Mar 2015 04:35:04 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:34850 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbbCPIfB convert rfc822-to-8bit (ORCPT ); Mon, 16 Mar 2015 04:35:01 -0400 MIME-Version: 1.0 In-Reply-To: <1426493782-3791-1-git-send-email-vndao@altera.com> References: <1426493782-3791-1-git-send-email-vndao@altera.com> Date: Mon, 16 Mar 2015 09:35:00 +0100 Message-ID: Subject: Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Viet Nga Dao Cc: Brian Norris , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , "linux-mtd@lists.infradead.org" , David Woodhouse , Nga Chi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16 March 2015 at 09:16, wrote: > +static struct flash_device flash_devices[] = { > + FLASH_ID("epcq16-nonjedec", 2, 0x15), > + FLASH_ID("epcq32-nonjedec", 2, 0x16), > + FLASH_ID("epcq64-nonjedec", 2, 0x17), > + FLASH_ID("epcq128-nonjedec", 2, 0x18), > + FLASH_ID("epcq256-nonjedec", 2, 0x19), > + FLASH_ID("epcq512-nonjedec", 2, 0x20), You could probably use EPCQ_OPCODE_ID > + > + FLASH_ID("epcs16-nonjedec", 1, 0x14), > + FLASH_ID("epcs64-nonjedec", 1, 0x16), > + FLASH_ID("epcs128-nonjedec", 1, 0x18), And EPCS_OPCODE_ID here. > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 43bb552..ad0c274 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -683,6 +683,17 @@ static const struct spi_device_id spi_nor_ids[] = { > { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, > { "cat25c17", CAT25_INFO( 256, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, > { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, > + > + /* Altera EPCQ/EPCS Flashes */ > + { "epcq16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, > + { "epcq32-nonjedec", INFO(0, 0, 0x10000, 64, 0) }, > + { "epcq64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, > + { "epcq128-nonjedec", INFO(0, 0, 0x10000, 256, 0) }, > + { "epcq256-nonjedec", INFO(0, 0, 0x10000, 512, 0) }, > + { "epcq512-nonjedec", INFO(0, 0, 0x10000, 1024, 0) }, > + { "epcs16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, > + { "epcs64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, > + { "epcs128-nonjedec", INFO(0, 0, 0x40000, 256, 0) }, > { }, > }; But mostly, I just wanted to say I like your integration with spi-nor. Nice work :) -- Rafał From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver Date: Mon, 16 Mar 2015 09:35:00 +0100 Message-ID: References: <1426493782-3791-1-git-send-email-vndao@altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1426493782-3791-1-git-send-email-vndao-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Viet Nga Dao Cc: Brian Norris , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , David Woodhouse , Nga Chi List-Id: devicetree@vger.kernel.org On 16 March 2015 at 09:16, wrote: > +static struct flash_device flash_devices[] =3D { > + FLASH_ID("epcq16-nonjedec", 2, 0x15), > + FLASH_ID("epcq32-nonjedec", 2, 0x16), > + FLASH_ID("epcq64-nonjedec", 2, 0x17), > + FLASH_ID("epcq128-nonjedec", 2, 0x18), > + FLASH_ID("epcq256-nonjedec", 2, 0x19), > + FLASH_ID("epcq512-nonjedec", 2, 0x20), You could probably use EPCQ_OPCODE_ID > + > + FLASH_ID("epcs16-nonjedec", 1, 0x14), > + FLASH_ID("epcs64-nonjedec", 1, 0x16), > + FLASH_ID("epcs128-nonjedec", 1, 0x18), And EPCS_OPCODE_ID here. > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-= nor.c > index 43bb552..ad0c274 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -683,6 +683,17 @@ static const struct spi_device_id spi_nor_ids[] = =3D { > { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | S= PI_NOR_NO_FR) }, > { "cat25c17", CAT25_INFO( 256, 8, 32, 2, SPI_NOR_NO_ERASE | S= PI_NOR_NO_FR) }, > { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | S= PI_NOR_NO_FR) }, > + > + /* Altera EPCQ/EPCS Flashes */ > + { "epcq16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, > + { "epcq32-nonjedec", INFO(0, 0, 0x10000, 64, 0) }, > + { "epcq64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, > + { "epcq128-nonjedec", INFO(0, 0, 0x10000, 256, 0) }, > + { "epcq256-nonjedec", INFO(0, 0, 0x10000, 512, 0) }, > + { "epcq512-nonjedec", INFO(0, 0, 0x10000, 1024, 0) }, > + { "epcs16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, > + { "epcs64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, > + { "epcs128-nonjedec", INFO(0, 0, 0x40000, 256, 0) }, > { }, > }; But mostly, I just wanted to say I like your integration with spi-nor. Nice work :) --=20 Rafa=C5=82 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ig0-x22a.google.com ([2607:f8b0:4001:c05::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YXQUe-0002ZJ-Qj for linux-mtd@lists.infradead.org; Mon, 16 Mar 2015 08:35:25 +0000 Received: by ignm3 with SMTP id m3so28214736ign.0 for ; Mon, 16 Mar 2015 01:35:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1426493782-3791-1-git-send-email-vndao@altera.com> References: <1426493782-3791-1-git-send-email-vndao@altera.com> Date: Mon, 16 Mar 2015 09:35:00 +0100 Message-ID: Subject: Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Viet Nga Dao Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "devicetree@vger.kernel.org" , Linux Kernel Mailing List , "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , Nga Chi List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 16 March 2015 at 09:16, wrote: > +static struct flash_device flash_devices[] =3D { > + FLASH_ID("epcq16-nonjedec", 2, 0x15), > + FLASH_ID("epcq32-nonjedec", 2, 0x16), > + FLASH_ID("epcq64-nonjedec", 2, 0x17), > + FLASH_ID("epcq128-nonjedec", 2, 0x18), > + FLASH_ID("epcq256-nonjedec", 2, 0x19), > + FLASH_ID("epcq512-nonjedec", 2, 0x20), You could probably use EPCQ_OPCODE_ID > + > + FLASH_ID("epcs16-nonjedec", 1, 0x14), > + FLASH_ID("epcs64-nonjedec", 1, 0x16), > + FLASH_ID("epcs128-nonjedec", 1, 0x18), And EPCS_OPCODE_ID here. > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.= c > index 43bb552..ad0c274 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -683,6 +683,17 @@ static const struct spi_device_id spi_nor_ids[] =3D = { > { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_N= OR_NO_FR) }, > { "cat25c17", CAT25_INFO( 256, 8, 32, 2, SPI_NOR_NO_ERASE | SPI_N= OR_NO_FR) }, > { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI_N= OR_NO_FR) }, > + > + /* Altera EPCQ/EPCS Flashes */ > + { "epcq16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, > + { "epcq32-nonjedec", INFO(0, 0, 0x10000, 64, 0) }, > + { "epcq64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, > + { "epcq128-nonjedec", INFO(0, 0, 0x10000, 256, 0) }, > + { "epcq256-nonjedec", INFO(0, 0, 0x10000, 512, 0) }, > + { "epcq512-nonjedec", INFO(0, 0, 0x10000, 1024, 0) }, > + { "epcs16-nonjedec", INFO(0, 0, 0x10000, 32, 0) }, > + { "epcs64-nonjedec", INFO(0, 0, 0x10000, 128, 0) }, > + { "epcs128-nonjedec", INFO(0, 0, 0x40000, 256, 0) }, > { }, > }; But mostly, I just wanted to say I like your integration with spi-nor. Nice work :) --=20 Rafa=C5=82