From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbbCMFpa (ORCPT ); Fri, 13 Mar 2015 01:45:30 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:33745 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbbCMFp0 convert rfc822-to-8bit (ORCPT ); Fri, 13 Mar 2015 01:45:26 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 13 Mar 2015 06:45:25 +0100 Message-ID: Subject: Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Viet Nga Dao Cc: Brian Norris , David Woodhouse , "devicetree@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , nga_chi86 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 March 2015 at 09:41, Viet Nga Dao wrote: > On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: >> Ok. I will modify the code the way you suggest. > > I just realize that the opcode for RDID is handled by hardware in my > case, therefore i dont really need to worry about 0xab opcode. Nice :) Maybe just put a comment in code so ppl will know (in future) why we don't strictly follow specs. > Is there any other comments about the modified part i did the lock and > unlock in spi-nor.c? I can't, I don't know spi-nor well enough :| -- Rafał From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver Date: Fri, 13 Mar 2015 06:45:25 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Viet Nga Dao Cc: Brian Norris , David Woodhouse , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , nga_chi86 List-Id: devicetree@vger.kernel.org On 11 March 2015 at 09:41, Viet Nga Dao wrote: > On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrot= e: >> Ok. I will modify the code the way you suggest. > > I just realize that the opcode for RDID is handled by hardware in my > case, therefore i dont really need to worry about 0xab opcode. Nice :) Maybe just put a comment in code so ppl will know (in future) why we don't strictly follow specs. > Is there any other comments about the modified part i did the lock an= d > unlock in spi-nor.c? I can't, I don't know spi-nor well enough :| --=20 Rafa=C5=82 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ie0-x230.google.com ([2607:f8b0:4001:c03::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YWIPr-0006oC-9h for linux-mtd@lists.infradead.org; Fri, 13 Mar 2015 05:45:47 +0000 Received: by ieclw3 with SMTP id lw3so85105954iec.2 for ; Thu, 12 Mar 2015 22:45:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 13 Mar 2015 06:45:25 +0100 Message-ID: Subject: Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Viet Nga Dao Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , nga_chi86 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11 March 2015 at 09:41, Viet Nga Dao wrote: > On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: >> Ok. I will modify the code the way you suggest. > > I just realize that the opcode for RDID is handled by hardware in my > case, therefore i dont really need to worry about 0xab opcode. Nice :) Maybe just put a comment in code so ppl will know (in future) why we don't strictly follow specs. > Is there any other comments about the modified part i did the lock and > unlock in spi-nor.c? I can't, I don't know spi-nor well enough :| --=20 Rafa=C5=82