All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Brett Rudley <brudley@broadcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
	Hante Meuleman <meuleman@broadcom.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	brcm80211 development <brcm80211-dev-list@broadcom.com>
Subject: Re: [RFC PATCH] brcmfmac: set WIPHY_FLAG_HAVE_AP_SME
Date: Tue, 26 Jan 2016 07:52:19 +0100	[thread overview]
Message-ID: <CACna6ryPq+O2yBrKG-9sZYqQ5rhqP2VV81u5qha5WVrP3QmE7Q@mail.gmail.com> (raw)
In-Reply-To: <56A5EFBD.5070400@broadcom.com>

On 25 January 2016 at 10:49, Arend van Spriel <arend@broadcom.com> wrote:
> On 20-1-2016 13:47, Rafał Miłecki wrote:
>> Now, the problem with brcmfmac is that it doesn't report support for any
>> management frames in AP mode. It supports sending ACTION (and maybe
>> PROBE_RESP) frames, but it can't pass ACTION to the cfg80211. So even if
>> we report we can send ACTION (as it seems we do), it won't fix the
>> problem.
>>
>> So this patch will trigger another code path in hostapd that due to
>> brcmfmac missing support for receiving & passing ACTION will fail.
>>
>> Do you have any idea how to handle this?
>
> The mgmt_tx callback in brcmfmac was added for P2P functionality. So if
> anything, a check should be added to assure it is only used on P2P
> interfaces.
>
>> Should hostapd drop depndency on ACTION frames? Should brcmfmac fake
>> support for receiving & passing ACTION frames? Or should support for
>> ACTION frames be added indeed?
>
> So why not stick with the current implementation. It may not seem
> optimal to first try one thing and fallback to another, but at least it
> works. I was thinking about trying with use_monitor=0, but looking in
> the code nl80211_setup_ap() that will not resolve it either.

I don't like current implementation as it depends on some failure,
fallback & inconsistent code in hostapd. It seems hacky to me and I
can imagine things going wrong on some simple hostapd change. I beliee
it also doesn't allow brcmfmac to implement monitor mode, because once
it's done, hostapd won't hit the same fallback path.

      reply	other threads:[~2016-01-26  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 12:47 [RFC PATCH] brcmfmac: set WIPHY_FLAG_HAVE_AP_SME Rafał Miłecki
2016-01-25  9:49 ` Arend van Spriel
2016-01-26  6:52   ` Rafał Miłecki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACna6ryPq+O2yBrKG-9sZYqQ5rhqP2VV81u5qha5WVrP3QmE7Q@mail.gmail.com \
    --to=zajec5@gmail.com \
    --cc=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=frankyl@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=meuleman@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.