All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Henry Ptasinski <henryp@broadcom.com>,
	linux-kernel@vger.kernel.org, Brett Rudley <brudley@broadcom.com>,
	Arend Van Spriel <arend@broadcom.com>,
	Roland Vossen <rvossen@broadcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
	devel@linuxdriverproject.org, Greg KH <gregkh@suse.de>,
	Kan Yan <kanyan@broadcom.com>,
	linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: brcmfmac: Consolidate debugging macros
Date: Fri, 26 Aug 2011 10:55:17 +0200	[thread overview]
Message-ID: <CACna6ryWtZG9obyj0w=d5jrF-y1pYNmanhkze2F429kHCLCi=A@mail.gmail.com> (raw)
In-Reply-To: <927eab8b5c950c13991911cd4c16457a5d618bc7.1314252671.git.joe@perches.com>

2011/8/25 Joe Perches <joe@perches.com>:
> Convert multiple BRCMF_<debug_level> macros to a single
> brcmf_dbg(level, fmt, ...) macro.

I'm not sure if that "_dbg" suffix is a really good choice. You use
"_dbg" for all the kinds of messages, while "DEBUG" is already one
kind of messages. We have also other types like EMERG, ALERT, CRIT,
ERR, WARNING, NOTICE, INFO and DEBUG.

You choice makes it messy according to me.

Wouldn't something like brcmf_print be much better choice?

I really don't like such a mixing dbg&DEBUG, dbd&ERR, etc.

-- 
Rafał

  parent reply	other threads:[~2011-08-26  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-25  6:16 [PATCH] staging: brcmfmac: Consolidate debugging macros Joe Perches
2011-08-25 15:47 ` Greg KH
2011-08-26  8:57   ` Rafał Miłecki
2011-08-26  9:05     ` Joe Perches
2011-08-26  8:55 ` Rafał Miłecki [this message]
2011-08-26  9:02   ` Joe Perches
2011-08-26  9:19     ` Rafał Miłecki
2011-08-26  9:24       ` Arend van Spriel
2011-08-27  7:29         ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACna6ryWtZG9obyj0w=d5jrF-y1pYNmanhkze2F429kHCLCi=A@mail.gmail.com' \
    --to=zajec5@gmail.com \
    --cc=arend@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devel@linuxdriverproject.org \
    --cc=frankyl@broadcom.com \
    --cc=gregkh@suse.de \
    --cc=henryp@broadcom.com \
    --cc=joe@perches.com \
    --cc=kanyan@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rvossen@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.