From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 1/2] Documentation: devicetree: m25p80: add "nor-jedec" binding Date: Sun, 22 Mar 2015 00:30:05 +0100 Message-ID: References: <1426111046-29900-1-git-send-email-computersforpeace@gmail.com> <20150312105824.GD30145@leverpostej> <20150320191258.GW32500@ld-irv-0074> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150320191258.GW32500@ld-irv-0074> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris Cc: Mark Rutland , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ezequiel Garcia , Marek Vasut List-Id: devicetree@vger.kernel.org On 20 March 2015 at 20:12, Brian Norris wrote: > Yes, and that is an eventual goal I suppose, but the current list is > excessive and is most likely not currently relied on by any one. So I > don't just want to C&P the entire list into this binding immediately. > > I guess my plan looks like this: > > 1. add "nor-jedec" binding, to provide lowest common denominator binding > (this series) > > 2. stop adding to the m25p_ids[] table unless necessary (enabled by this > series) > > 3. gauge whether we can remove certain entries from m25p_ids[] (e.g., if > they were only used in platform_data, not DT; or if they were very > recently added just to synchronize with spi-nor.c) Why we can't remove (slowly) all entries from m25p_ids that don't need any extra handling? If we'll have DT with "spansion,m25p80", "nor-jedec" and then m25p80.c will handle both: "m25p80" and "nor-jedec" without any difference, what's the point of keeping "m25p80" entry? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ie0-x233.google.com ([2607:f8b0:4001:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YZSqZ-00073h-S6 for linux-mtd@lists.infradead.org; Sat, 21 Mar 2015 23:30:28 +0000 Received: by iedm5 with SMTP id m5so13342530ied.3 for ; Sat, 21 Mar 2015 16:30:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20150320191258.GW32500@ld-irv-0074> References: <1426111046-29900-1-git-send-email-computersforpeace@gmail.com> <20150312105824.GD30145@leverpostej> <20150320191258.GW32500@ld-irv-0074> Date: Sun, 22 Mar 2015 00:30:05 +0100 Message-ID: Subject: Re: [PATCH 1/2] Documentation: devicetree: m25p80: add "nor-jedec" binding From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Brian Norris Content-Type: text/plain; charset=UTF-8 Cc: Mark Rutland , "devicetree@vger.kernel.org" , Marek Vasut , "linux-mtd@lists.infradead.org" , Ezequiel Garcia List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 20 March 2015 at 20:12, Brian Norris wrote: > Yes, and that is an eventual goal I suppose, but the current list is > excessive and is most likely not currently relied on by any one. So I > don't just want to C&P the entire list into this binding immediately. > > I guess my plan looks like this: > > 1. add "nor-jedec" binding, to provide lowest common denominator binding > (this series) > > 2. stop adding to the m25p_ids[] table unless necessary (enabled by this > series) > > 3. gauge whether we can remove certain entries from m25p_ids[] (e.g., if > they were only used in platform_data, not DT; or if they were very > recently added just to synchronize with spi-nor.c) Why we can't remove (slowly) all entries from m25p_ids that don't need any extra handling? If we'll have DT with "spansion,m25p80", "nor-jedec" and then m25p80.c will handle both: "m25p80" and "nor-jedec" without any difference, what's the point of keeping "m25p80" entry?