From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 1/3] of: mtd: add helper reading "nand-ecc-algo" from DT Date: Fri, 26 Feb 2016 22:24:21 +0100 Message-ID: References: <1455300685-27009-1-git-send-email-zajec5@gmail.com> <20160224144652.14068468@bbrezillon> <20160225210946.6c842f4b@bbrezillon> <20160226175506.75d6c7b0@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160226175506.75d6c7b0@bbrezillon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boris Brezillon Cc: Brian Norris , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Kamal Dasu , Hauke Mehrtens , Rob Herring , Grant Likely , Frank Rowand List-Id: devicetree@vger.kernel.org On 26 February 2016 at 17:55, Boris Brezillon wrote: > On Fri, 26 Feb 2016 17:30:47 +0100 > Rafa=C5=82 Mi=C5=82ecki wrote: >> What about: >> 1) Adding new nand-ecc-algo as this patch does >> 2) Deprecating "soft_bch" value from nand-ecc-mode property >> > > Sounds good to me. I have problems understanding "soft" values which maps to the NAND_ECC_SOFT. What exactly algorithm is that? It uses functions from drivers/mtd/nand/nand_ecc.c but this file isn't really helpful. I was only able to find "3-byte ECC" phase. Kconfig config MTD_NAND_ECC also doesn't have any description. I also tried looking at Documentation/mtd/nand_ecc.txt but still no luck. Does this algorithm has any name? --=20 Rafa=C5=82 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ig0-x236.google.com ([2607:f8b0:4001:c05::236]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aZPsQ-0002kL-Tf for linux-mtd@lists.infradead.org; Fri, 26 Feb 2016 21:24:43 +0000 Received: by mail-ig0-x236.google.com with SMTP id y8so44197251igp.1 for ; Fri, 26 Feb 2016 13:24:22 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20160226175506.75d6c7b0@bbrezillon> References: <1455300685-27009-1-git-send-email-zajec5@gmail.com> <20160224144652.14068468@bbrezillon> <20160225210946.6c842f4b@bbrezillon> <20160226175506.75d6c7b0@bbrezillon> Date: Fri, 26 Feb 2016 22:24:21 +0100 Message-ID: Subject: Re: [PATCH 1/3] of: mtd: add helper reading "nand-ecc-algo" from DT From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Boris Brezillon Cc: Brian Norris , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , Kamal Dasu , Hauke Mehrtens , Rob Herring , Grant Likely , Frank Rowand Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 26 February 2016 at 17:55, Boris Brezillon wrote: > On Fri, 26 Feb 2016 17:30:47 +0100 > Rafa=C5=82 Mi=C5=82ecki wrote: >> What about: >> 1) Adding new nand-ecc-algo as this patch does >> 2) Deprecating "soft_bch" value from nand-ecc-mode property >> > > Sounds good to me. I have problems understanding "soft" values which maps to the NAND_ECC_SOFT. What exactly algorithm is that? It uses functions from drivers/mtd/nand/nand_ecc.c but this file isn't really helpful. I was only able to find "3-byte ECC" phase. Kconfig config MTD_NAND_ECC also doesn't have any description. I also tried looking at Documentation/mtd/nand_ecc.txt but still no luck. Does this algorithm has any name? --=20 Rafa=C5=82