From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759411AbcHYMm4 (ORCPT ); Thu, 25 Aug 2016 08:42:56 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35933 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754080AbcHYMmy (ORCPT ); Thu, 25 Aug 2016 08:42:54 -0400 MIME-Version: 1.0 In-Reply-To: <20160823195528.GA17844@rob-hp-laptop> References: <20160823061745.8162-1-zajec5@gmail.com> <20160823062613.13865-1-zajec5@gmail.com> <20160823195528.GA17844@rob-hp-laptop> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Thu, 25 Aug 2016 14:42:52 +0200 Message-ID: Subject: Re: [PATCH V5] clk: bcm: Add driver for BCM53573 ILP clock To: Rob Herring Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, bcm-kernel-feedback-list , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Mark Rutland , Eric Anholt , Jon Mason , Florian Fainelli , Stephen Warren , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u7PCh0Fb004406 On 23 August 2016 at 21:55, Rob Herring wrote: > On Tue, Aug 23, 2016 at 08:25:59AM +0200, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> This clock is present on BCM53573 devices (including BCM47189) that use >> Cortex-A7. ILP is a part of PMU (Power Management Unit) and so it should >> be defined as one of its subnodes (subdevices). For more details see >> Documentation entry. >> >> Unfortunately there isn't a set of registers related to ILP clock only. >> We use registers 0x66c, 0x674 and 0x6dc and between them there are e.g. >> "retention*" and "control_ext" regs. This is why this driver maps all >> 0x1000 B of space. > > Then describe the block as a syscon which has several functions of > which clocks are one. This isn't clear to me, sorry, could you describe it? Would you like me to update commit message or documentation? Is code fine as is? From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V5] clk: bcm: Add driver for BCM53573 ILP clock Date: Thu, 25 Aug 2016 14:42:52 +0200 Message-ID: References: <20160823061745.8162-1-zajec5@gmail.com> <20160823062613.13865-1-zajec5@gmail.com> <20160823195528.GA17844@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20160823195528.GA17844@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Michael Turquette , Stephen Boyd , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Mark Rutland , Eric Anholt , Jon Mason , Florian Fainelli , Stephen Warren , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org On 23 August 2016 at 21:55, Rob Herring wrote: > On Tue, Aug 23, 2016 at 08:25:59AM +0200, Rafa=C5=82 Mi=C5=82ecki wrote: >> From: Rafa=C5=82 Mi=C5=82ecki >> >> This clock is present on BCM53573 devices (including BCM47189) that use >> Cortex-A7. ILP is a part of PMU (Power Management Unit) and so it should >> be defined as one of its subnodes (subdevices). For more details see >> Documentation entry. >> >> Unfortunately there isn't a set of registers related to ILP clock only. >> We use registers 0x66c, 0x674 and 0x6dc and between them there are e.g. >> "retention*" and "control_ext" regs. This is why this driver maps all >> 0x1000 B of space. > > Then describe the block as a syscon which has several functions of > which clocks are one. This isn't clear to me, sorry, could you describe it? Would you like me to update commit message or documentation? Is code fine as is? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20160823195528.GA17844@rob-hp-laptop> References: <20160823061745.8162-1-zajec5@gmail.com> <20160823062613.13865-1-zajec5@gmail.com> <20160823195528.GA17844@rob-hp-laptop> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Thu, 25 Aug 2016 14:42:52 +0200 Message-ID: Subject: Re: [PATCH V5] clk: bcm: Add driver for BCM53573 ILP clock To: Rob Herring Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, bcm-kernel-feedback-list , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Mark Rutland , Eric Anholt , Jon Mason , Florian Fainelli , Stephen Warren , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Content-Type: text/plain; charset=UTF-8 List-ID: On 23 August 2016 at 21:55, Rob Herring wrote: > On Tue, Aug 23, 2016 at 08:25:59AM +0200, Rafa=C5=82 Mi=C5=82ecki wrote: >> From: Rafa=C5=82 Mi=C5=82ecki >> >> This clock is present on BCM53573 devices (including BCM47189) that use >> Cortex-A7. ILP is a part of PMU (Power Management Unit) and so it should >> be defined as one of its subnodes (subdevices). For more details see >> Documentation entry. >> >> Unfortunately there isn't a set of registers related to ILP clock only. >> We use registers 0x66c, 0x674 and 0x6dc and between them there are e.g. >> "retention*" and "control_ext" regs. This is why this driver maps all >> 0x1000 B of space. > > Then describe the block as a syscon which has several functions of > which clocks are one. This isn't clear to me, sorry, could you describe it? Would you like me to update commit message or documentation? Is code fine as is?