All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaud Lacombe <lacombar@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-media@vger.kernel.org, mchehab@infradead.org
Subject: Re: [PATCH 2/9] media/radio: fix aimslab CONFIG IO PORT
Date: Thu, 14 Jul 2011 21:44:48 -0400	[thread overview]
Message-ID: <CACqU3MXTahX6oSsyfmejPHBL_7Fv1AKJz663k6hDQs7jCDGvtg@mail.gmail.com> (raw)
In-Reply-To: <20110710125356.b6cb17c2.rdunlap@xenotime.net>

Hi,

2 to 7 will be not needed. I screwed up a autoconf.h generation while
refactoring the code. This is being addressed in the kbuild tree by:

https://patchwork.kernel.org/patch/975652/

My bad,
 - Arnaud

On Sun, Jul 10, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Modify radio-aimslab to use HEX_STRING(CONFIG_RADIO_RTRACK_PORT)
> so that the correct IO port value is used.
>
> Fixes this error message when CONFIG_RADIO_RTRACK_PORT=20f:
> drivers/media/radio/radio-aimslab.c:49:17: error: invalid suffix "f" on integer constant
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/media/radio/radio-aimslab.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> --- linux-next-20110707.orig/drivers/media/radio/radio-aimslab.c
> +++ linux-next-20110707/drivers/media/radio/radio-aimslab.c
> @@ -32,6 +32,7 @@
>  #include <linux/init.h>                /* Initdata                     */
>  #include <linux/ioport.h>      /* request_region               */
>  #include <linux/delay.h>       /* msleep                       */
> +#include <linux/stringify.h>
>  #include <linux/videodev2.h>   /* kernel radio structs         */
>  #include <linux/io.h>          /* outb, outb_p                 */
>  #include <media/v4l2-device.h>
> @@ -43,10 +44,12 @@ MODULE_LICENSE("GPL");
>  MODULE_VERSION("0.0.3");
>
>  #ifndef CONFIG_RADIO_RTRACK_PORT
> -#define CONFIG_RADIO_RTRACK_PORT -1
> +#define __RADIO_RTRACK_PORT -1
> +#else
> +#define __RADIO_RTRACK_PORT HEX_STRING(CONFIG_RADIO_RTRACK_PORT)
>  #endif
>
> -static int io = CONFIG_RADIO_RTRACK_PORT;
> +static int io = __RADIO_RTRACK_PORT;
>  static int radio_nr = -1;
>
>  module_param(io, int, 0);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

  reply	other threads:[~2011-07-15  1:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-10 19:51 [PATCH 1/9] stringify: add HEX_STRING() Randy Dunlap
2011-07-10 19:53 ` [PATCH 2/9] media/radio: fix aimslab CONFIG IO PORT Randy Dunlap
2011-07-15  1:44   ` Arnaud Lacombe [this message]
2011-07-10 19:54 ` [PATCH 3/9] media/radio: fix aztech " Randy Dunlap
2011-07-10 19:55 ` [PATCH 4/9] media/radio: fix gemtek " Randy Dunlap
2011-07-10 19:56 ` [PATCH 5/9] media/radio: fix rtrack2 " Randy Dunlap
2011-07-10 19:57 ` [PATCH 6/9] media/radio: fix terratec " Randy Dunlap
2011-07-10 19:58 ` [PATCH 7/9] media/radio: fix trust " Randy Dunlap
2011-07-10 19:59 ` [PATCH 8/9] media/radio: fix typhoon " Randy Dunlap
2011-07-10 19:59 ` [PATCH 9/9] media/radio: fix zoltrix " Randy Dunlap
2011-07-13 21:05 ` [PATCH 1/9] stringify: add HEX_STRING() Mauro Carvalho Chehab
2011-07-13 21:11   ` Randy Dunlap
2011-07-13 22:04   ` Randy Dunlap
2011-07-13 21:49 ` Arnaud Lacombe
2011-07-13 22:00   ` Randy Dunlap
2011-07-13 22:06     ` Arnaud Lacombe
2011-07-13 22:08       ` Randy Dunlap
2011-07-13 22:13         ` Arnaud Lacombe
2011-07-13 22:17           ` Randy Dunlap
2011-07-14  4:03             ` Arnaud Lacombe
2011-07-14 17:26             ` [PATCH] media/Kconfig: fix hexadecimal prefix for `hex' symbols Arnaud Lacombe
2011-07-14 18:16               ` Mauro Carvalho Chehab
2011-07-14 18:47                 ` Arnaud Lacombe
2011-07-14 23:32                 ` Arnaud Lacombe
2011-07-15  0:01                   ` Mauro Carvalho Chehab
2011-07-15  1:39                     ` Arnaud Lacombe
2011-07-24 21:38               ` Arnaud Lacombe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACqU3MXTahX6oSsyfmejPHBL_7Fv1AKJz663k6hDQs7jCDGvtg@mail.gmail.com \
    --to=lacombar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.