All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaud Lacombe <lacombar@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-ext4@vger.kernel.org, linux-next@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Aug 30 (jbd2 + bug.h)
Date: Thu, 1 Sep 2011 16:30:47 -0400	[thread overview]
Message-ID: <CACqU3MXZ52fM_xFFxmPm3wby8bD9isAsomxbvh_Dj+bBb9uFdg@mail.gmail.com> (raw)
In-Reply-To: <201109011343.22014.arnd@arndb.de>

Hi,

On Thu, Sep 1, 2011 at 7:43 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 31 August 2011, Randy Dunlap wrote:
>> On Tue, 30 Aug 2011 17:16:05 +1000 Stephen Rothwell wrote:
>>
>> > Hi all,
>>
>> [Sorry about the delay.  My build machine is being slow.
>> If this is alread fixed, sorry about the noise.]
>>
>>
>> When CONFIG_BUG is not enabled (I see this on x86_64):
>>
>> fs/jbd2/transaction.c: In function 'jbd2_journal_dirty_metadata':
>> fs/jbd2/transaction.c:1176: error: implicit declaration of function '__WARN'
>>
>>
>> asm-generic/bug.h does not provide a version of __WARN() when
>> CONFIG_BUG is not enabled...
>>
>
> Hmm, my feeling is that we shouldn't do that either, and that jbd2 should
> be changed. If we want a function that does what __WARN() does today, we
> should probably make a conscious decision about what we want it to be called
> and not have it start with "__".
>
Why is WARN_ON() not used here ?

 - Arnaud

>        Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2011-09-01 20:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30  7:16 linux-next: Tree for Aug 30 Stephen Rothwell
2011-08-31 20:14 ` linux-next: Tree for Aug 30 (jbd2 + bug.h) Randy Dunlap
2011-09-01 11:43   ` Arnd Bergmann
2011-09-01 20:30     ` Arnaud Lacombe [this message]
2011-08-31 20:45 ` linux-next: Tree for Aug 30 (scsi/qla4xxx) Randy Dunlap
2011-09-01  2:53   ` Mike Christie
2011-09-01 16:20     ` Randy Dunlap
2011-09-01 17:17     ` Vikas Chaudhary
2011-09-01 17:15   ` Vikas Chaudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACqU3MXZ52fM_xFFxmPm3wby8bD9isAsomxbvh_Dj+bBb9uFdg@mail.gmail.com \
    --to=lacombar@gmail.com \
    --cc=arnd@arndb.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.