From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA5tR-0007XS-7R for qemu-devel@nongnu.org; Wed, 23 Jul 2014 19:24:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA5tP-0000WV-UY for qemu-devel@nongnu.org; Wed, 23 Jul 2014 19:24:17 -0400 Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:63495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA5tP-0000WR-PC for qemu-devel@nongnu.org; Wed, 23 Jul 2014 19:24:15 -0400 Received: by mail-qg0-f48.google.com with SMTP id i50so2339064qgf.35 for ; Wed, 23 Jul 2014 16:24:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <53D01B2D.2020107@weilnetz.de> References: <1406044070-25667-1-git-send-email-tamlokveer@gmail.com> <1406044070-25667-2-git-send-email-tamlokveer@gmail.com> <53D01B2D.2020107@weilnetz.de> Date: Thu, 24 Jul 2014 07:24:15 +0800 Message-ID: From: Le Tan Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/3] intel-iommu: introduce Intel IOMMU (VT-d) emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: "Michael S. Tsirkin" , Knut Omang , qemu-devel , Alex Williamson , Jan Kiszka , Anthony Liguori , Paolo Bonzini Hi Stefan, 2014-07-24 4:29 GMT+08:00 Stefan Weil : > Am 22.07.2014 17:47, schrieb Le Tan: >> Add support for emulating Intel IOMMU according to the VT-d specification for >> the q35 chipset machine. Implement the logic for DMAR (DMA remapping) without >> PASID support. Use register-based invalidation for context-cache invalidation >> and IOTLB invalidation. >> Basic fault reporting and caching are not implemented yet. >> >> Signed-off-by: Le Tan >> --- >> hw/i386/Makefile.objs | 1 + >> hw/i386/intel_iommu.c | 1139 +++++++++++++++++++++++++++++++++++++++++ >> include/hw/i386/intel_iommu.h | 350 +++++++++++++ >> 3 files changed, 1490 insertions(+) >> create mode 100644 hw/i386/intel_iommu.c >> create mode 100644 include/hw/i386/intel_iommu.h >> > [...] >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c >> new file mode 100644 >> index 0000000..3ba0e1e >> --- /dev/null >> +++ b/hw/i386/intel_iommu.c >> @@ -0,0 +1,1139 @@ >> +/* >> + * QEMU emulation of an Intel IOMMU (VT-d) >> + * (DMA Remapping device) >> + * >> + * Copyright (c) 2013 Knut Omang, Oracle >> + * Copyright (C) 2014 Le Tan, >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >> + */ >> + > > I suggest replacing the FSF address here (and in other files) by the URL: > > * You should have received a copy of the GNU General Public License along > * with this program; if not, see . > > This is the standard used for most GPL text in QEMU source files. Get it. I copied it from the Linux kernel tree. Thanks very much! > Regards > Stefan W. > Regards, Le