From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Jonathan Niedier <jrnieder@gmail.com>
Subject: Re: [PATCH v3] branch: show rebase/bisect info when possible instead of "(no branch)"
Date: Thu, 14 Feb 2013 16:46:21 +0700 [thread overview]
Message-ID: <CACsJy8Ah5PvtD_AXL+tiZp-eQvzfcmvciUEK=yyOPKv-Es9YCA@mail.gmail.com> (raw)
In-Reply-To: <7v1ucq3b7e.fsf@alter.siamese.dyndns.org>
On Sat, Feb 9, 2013 at 1:35 AM, Junio C Hamano <gitster@pobox.com> wrote:
> We may want to refactor wt_status_print_state() and its callee a bit
> so that it and this part can share the logic without duplication and
> risk implementing subtly different decision. wt_status used to have
> clean separation between collection phase and presentation phase,
> but the wall between the phases seems deteriorated over time as more
> "in progress" crufts have been piled on top.
>
> Such a refactoring may look larger than necessary, but on the other
> hand, I do not see this feature very useful if it can over time
> drift away from what we will see in "git status", so...
OK. I'll wait until nd/status-show-in-progress is merged to master,
then rework this patch on top.
--
Duy
next prev parent reply other threads:[~2013-02-14 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 12:12 [PATCH] branch: show (rebasing) or (bisecting) instead of (no branch) when possible Nguyễn Thái Ngọc Duy
2013-01-29 19:13 ` Jonathan Nieder
2013-02-03 5:48 ` [PATCH v2] branch: show rebase/bisect info when possible instead of "(no branch)" Nguyễn Thái Ngọc Duy
2013-02-03 21:23 ` Matthieu Moy
2013-02-03 21:58 ` Junio C Hamano
2013-02-03 22:00 ` Junio C Hamano
2013-02-04 13:13 ` Matthieu Moy
2013-02-04 16:18 ` Junio C Hamano
2013-02-04 7:14 ` Duy Nguyen
2013-02-04 7:17 ` Duy Nguyen
2013-02-08 10:09 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2013-02-08 18:35 ` Junio C Hamano
2013-02-14 9:46 ` Duy Nguyen [this message]
2013-02-11 19:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8Ah5PvtD_AXL+tiZp-eQvzfcmvciUEK=yyOPKv-Es9YCA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.