From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Move test-* to t/helper/ subdirectory
Date: Tue, 3 May 2016 07:15:38 +0700 [thread overview]
Message-ID: <CACsJy8B16SWsu5xTHdPcR4dz4_z+Br5EGGbJ+B5SChA=sWo-bg@mail.gmail.com> (raw)
In-Reply-To: <xmqqk2jcuzx7.fsf@gitster.mtv.corp.google.com>
On Tue, May 3, 2016 at 12:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> I may have rushed to judgement. wrap-for-bin.sh has always been the
>> dependency for bin-wrappers/*. If we force that file to change, then
>> bin-wrappers/* will be recreated when switching branches. So how about
>> this?
>
> I do not think you are "force updating wrap-for-bin" in any way in
> the patch, though. You are building it in such a way that it does
> not have to get updated within the revision that contains e6e7530
> (assuming that this will be queued directly on top it and merged to
> everywhere e6e7530 is contained).
Yep.
> The new case/esac looks somewhat bad (its knowing that where test-*
> lives, test-* is the only thing that is special, etc. troubles me at
> the same time that case/esac is funnily formated).
We could just make some random changes in this file. That would have
the same effect.
> Where does "@@PATH@@" come from and who rewrites it? Is that a
> misspelt "@@PROG@@"?
Yep. Should have run make distclean before testing :(
--
Duy
next prev parent reply other threads:[~2016-05-03 0:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 13:22 [PATCH] Move test-* to t/helper/ subdirectory Nguyễn Thái Ngọc Duy
2016-04-15 15:09 ` Junio C Hamano
2016-04-15 17:06 ` Junio C Hamano
2016-04-16 0:08 ` Duy Nguyen
2016-04-26 22:07 ` Junio C Hamano
2016-04-27 0:52 ` Duy Nguyen
2016-04-27 10:18 ` Duy Nguyen
2016-04-27 16:15 ` Junio C Hamano
2016-05-01 0:28 ` Duy Nguyen
2016-05-01 6:00 ` Duy Nguyen
2016-05-02 17:34 ` Junio C Hamano
2016-05-03 0:15 ` Duy Nguyen [this message]
2016-05-08 9:51 ` Duy Nguyen
2016-05-09 16:03 ` Junio C Hamano
2016-05-10 11:58 ` Duy Nguyen
2016-05-10 20:23 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 22:15 [PATCH/RFC] Move test-*.c to test/ subdirectory Junio C Hamano
2011-02-10 2:14 ` [PATCH] Move test-* to t/helper/ subdirectory Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8B16SWsu5xTHdPcR4dz4_z+Br5EGGbJ+B5SChA=sWo-bg@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.