From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
Denton Liu <liu.denton@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>,
Joel Teichroeb <joel@teichroeb.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
Matthew Kraai <mkraai@its.jnj.com>
Subject: Re: [REGRESSION ps/stash-in-c] git stash show -v
Date: Wed, 20 Mar 2019 16:30:13 +0700 [thread overview]
Message-ID: <CACsJy8BMdjR9cS4qDVaNXtW-U0cQt5e3au2y5PsW7eKQdd3xJA@mail.gmail.com> (raw)
In-Reply-To: <20190320050449.GA6401@sigill.intra.peff.net>
On Wed, Mar 20, 2019 at 12:06 PM Jeff King <peff@peff.net> wrote:
>
> On Tue, Mar 19, 2019 at 11:18:26PM +0000, Thomas Gummerer wrote:
>
> > From a quick search I couldn't find where 'git diff' actually parses
> > the '-v' argument, but I wonder if we should actually disallow it, in
> > case we want to use it for something else in the future? It's not
> > documented anywhere in the docs either.
>
> It's a bit interesting, actually. git-diff uses setup_revisions() to
> parse its arguments, which picks up any diff options, as well as parsing
> the revs and pathspecs.
>
> ...
>
> - we may want to teach the "diff" porcelain not to accept useless
> revision options. I suspect it may be a bit tricky, just because of
> the way the code takes advantage of setup_revisions.
This is actually in my TODO list. Once the parseopt conversion for
revision.c and diff.c is done, "git diff --help" would be _very_ long
because of this exact problem. But then once the conversion is over, I
think removing unused options is quite simple (by manipulating 'struct
option[]' array before calling parse_options).
--
Duy
next prev parent reply other threads:[~2019-03-20 9:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 19:05 [REGRESSION ps/stash-in-c] git stash show -v Denton Liu
2019-03-19 23:18 ` Thomas Gummerer
2019-03-20 1:00 ` Junio C Hamano
2019-03-20 21:45 ` Thomas Gummerer
2019-03-20 1:04 ` Junio C Hamano
2019-03-20 5:04 ` Jeff King
2019-03-20 9:30 ` Duy Nguyen [this message]
2019-03-20 21:59 ` Thomas Gummerer
2019-03-20 22:49 ` [PATCH v2] stash: setup default diff output format if necessary Thomas Gummerer
2019-03-20 23:04 ` Denton Liu
2019-03-20 23:09 ` Denton Liu
2019-03-28 20:45 ` Thomas Gummerer
2019-03-21 9:51 ` Jeff King
2019-03-22 3:25 ` Junio C Hamano
2019-03-22 3:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8BMdjR9cS4qDVaNXtW-U0cQt5e3au2y5PsW7eKQdd3xJA@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joel@teichroeb.net \
--cc=liu.denton@gmail.com \
--cc=mkraai@its.jnj.com \
--cc=peff@peff.net \
--cc=t.gummerer@gmail.com \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.