All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>, Tom Miller <jackerran@gmail.com>
Subject: Re: [PATCH] fetch: document that pruning happens before fetching
Date: Tue, 14 Jun 2016 17:36:35 +0700	[thread overview]
Message-ID: <CACsJy8Bbd0=vnbaj4-2m7WKfvWG6PfyXLg1h+970HPsak1hnMQ@mail.gmail.com> (raw)
In-Reply-To: <20160614102210.GA14357@sigill.intra.peff.net>

On Tue, Jun 14, 2016 at 5:22 PM, Jeff King <peff@peff.net> wrote:
> I think the documentation should be updated either way. This is not
> about the ordering in the status table, but rather about the order of
> the real operations. The user may care about that ordering if they want
> to know what races are possible

Good point.

> or what would happen if the packfile
> fetch failed (we'd already have deleted the old refs, but wouldn't fetch
> the new ones).

Off topic, but this sounds like a bug to me. We could have kept ref
update more consistent (maybe at some point we could even do atomic
transaction update for all refs if there's a need for it).
-- 
Duy

  reply	other threads:[~2016-06-14 10:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 23:58 [PATCH] fetch: document that pruning happens before fetching Jeff King
2016-06-14  6:14 ` Jacob Keller
2016-06-14  6:17   ` Jeff King
2016-06-14  6:18     ` Jacob Keller
2016-06-14  9:36 ` Duy Nguyen
2016-06-14 10:22   ` Jeff King
2016-06-14 10:36     ` Duy Nguyen [this message]
2016-06-15  3:46       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8Bbd0=vnbaj4-2m7WKfvWG6PfyXLg1h+970HPsak1hnMQ@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jackerran@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.