All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Pasha Bolokhov <pasha.bolokhov@gmail.com>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
	"Jakub Narębski" <jnareb@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH v5] Add an explicit GIT_DIR to the list of excludes
Date: Wed, 11 Jun 2014 17:48:31 +0700	[thread overview]
Message-ID: <CACsJy8Cgu792Tamej3+_9w=Krg8nezYYA6k604gikebHG=yVUg@mail.gmail.com> (raw)
In-Reply-To: <CAKpPgveXen9sQefo8dva1Uy4YOyroT6cPXLzgUvxj93Zqw13zw@mail.gmail.com>

On Tue, Jun 10, 2014 at 10:18 AM, Pasha Bolokhov
<pasha.bolokhov@gmail.com> wrote:
>> On Thu, Jun 5, 2014 at 3:15 AM, Pasha Bolokhov <pasha.bolokhov@gmail.com> wrote:
>>> +       /* only add it if GIT_DIR does not end with '.git' or '/.git' */
>>> +       if (len < 4 || strcmp(n_git + len - 4, ".git") ||
>>> +           (len > 4 && n_git[len - 5] != '/')) {
>>
>> Hmm.. should we exclude "foobar.git" as well?
>
>     Why wouldn't we? Everything that has basename ".git" is hard-wired
> to be excluded, but everything else, including "foobar.git" should be
> added to the excludes manually... How is it better than just "foobar"?

Yes everything except ".git" should be excluded. And you do exactly
that. I misread the code (probably better to write "if (!(<basename is
".git>))", maybe)
-- 
Duy

  reply	other threads:[~2014-06-11 10:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 20:15 [PATCH v5] Add an explicit GIT_DIR to the list of excludes Pasha Bolokhov
2014-06-08 10:17 ` Duy Nguyen
2014-06-10  3:18   ` Pasha Bolokhov
2014-06-11 10:48     ` Duy Nguyen [this message]
2014-06-11 23:28       ` [PATCH v6] " Pasha Bolokhov
2014-06-12  6:19         ` Johannes Sixt
2014-06-13 16:10           ` Pasha Bolokhov
2014-06-13 16:50             ` Junio C Hamano
2014-06-14 19:16               ` [PATCH v8] " Pasha Bolokhov
2014-06-13 16:32           ` [PATCH v7] " Pasha Bolokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8Cgu792Tamej3+_9w=Krg8nezYYA6k604gikebHG=yVUg@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=jrnieder@gmail.com \
    --cc=pasha.bolokhov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.