From: Duy Nguyen <pclouds@gmail.com>
To: lersek@redhat.com
Cc: leif.lindholm@linaro.org, Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] format-patch: respect --stat when explicitly specified
Date: Tue, 6 Nov 2018 17:20:25 +0100 [thread overview]
Message-ID: <CACsJy8CqfApePPY4zA9f=KOSTsA8pUA2ez_3KiXeOJQqtSNb7Q@mail.gmail.com> (raw)
In-Reply-To: <0171b18f-0732-48fa-b4be-efbc9ba22f85@redhat.com>
On Tue, Nov 6, 2018 at 5:18 PM Laszlo Ersek <lersek@redhat.com> wrote:
> >> + opts.stat_width = MAIL_DEFAULT_WRAP;
> >
> > How about a test to make sure this will not be broken in future?
>
> Oh, looks like I won't have to test this patch at all! ;)
>
> (Just kidding, I'll test the next iteration.)
Just to be clear I didn't mean you didn't test it. I meant adding a
new test case to our test suite.
--
Duy
next prev parent reply other threads:[~2018-11-06 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 10:48 [PATCH] format-patch: respect --stat when explicitly specified Leif Lindholm
2018-11-06 15:56 ` Duy Nguyen
2018-11-06 16:17 ` Laszlo Ersek
2018-11-06 16:20 ` Duy Nguyen [this message]
2018-11-06 16:31 ` Leif Lindholm
2018-11-06 17:13 ` Duy Nguyen
2018-11-06 17:25 ` Leif Lindholm
2018-11-06 17:27 ` Duy Nguyen
2018-11-07 16:49 ` [PATCH v2] format-patch: respect --stat in cover letter's diffstat Nguyễn Thái Ngọc Duy
2018-11-07 22:21 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8CqfApePPY4zA9f=KOSTsA8pUA2ez_3KiXeOJQqtSNb7Q@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=leif.lindholm@linaro.org \
--cc=lersek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.