All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings
Date: Fri, 26 Feb 2016 16:33:44 +0700	[thread overview]
Message-ID: <CACsJy8Dc1dHp7kGgz_pY1uoXum-k3gnzD0AHFsaLQzuZihUKcw@mail.gmail.com> (raw)
In-Reply-To: <17AFC0E6-FC83-4BD4-9C19-43A6B9103866@gmail.com>

On Fri, Feb 26, 2016 at 4:30 PM, Lars Schneider
<larsxschneider@gmail.com> wrote:
>
>> On 26 Feb 2016, at 10:26, Duy Nguyen <pclouds@gmail.com> wrote:
>>
>> On Thu, Feb 25, 2016 at 3:42 PM,  <larsxschneider@gmail.com> wrote:
>>> +ifdef DEVELOPER
>>> +       CFLAGS +=       -Werror \
>>> +                               -Wdeclaration-after-statement \
>>> +                               -Wno-format-zero-length \
>>> +                               -Wold-style-definition \
>>> +                               -Woverflow \
>>> +                               -Wpointer-arith \
>>> +                               -Wstrict-prototypes \
>>> +                               -Wunused \
>>> +                               -Wvla
>>
>> With the exception of $(SCRIPTS) in Makefile, I think we prefer to
>> avoid \ and have one addition per statement
>>
> I guessed that because I actually looked through the makefile to find how you deal with line
> brakes. The problem here was that this line gets really long and then it is hard to see what
> warnings are enabled.
> Would you be OK with using \ for readability here?

Probably misunderstanding. I meant something like this

CFLAGS += -Werror
CFLAGS += -Wdecl..
CFLAGS += -Wno-form..
-- 
Duy

  reply	other threads:[~2016-02-26  9:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  8:42 [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings larsxschneider
2016-02-25  9:26 ` Matthieu Moy
2016-02-25 10:20 ` Michael Haggerty
2016-02-25 17:40 ` Junio C Hamano
2016-02-26  9:26   ` Lars Schneider
2016-02-26  9:26 ` Duy Nguyen
2016-02-26  9:30   ` Lars Schneider
2016-02-26  9:33     ` Duy Nguyen [this message]
2016-02-28 10:35       ` Lars Schneider
2016-02-28 10:49         ` Duy Nguyen
2017-05-02 13:22 ` Ævar Arnfjörð Bjarmason
2017-05-10  4:59   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACsJy8Dc1dHp7kGgz_pY1uoXum-k3gnzD0AHFsaLQzuZihUKcw@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=larsxschneider@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.