From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgios Amanakis Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Date: Tue, 24 Apr 2018 11:32:00 -0400 Message-ID: References: <1512338775-3270-1-git-send-email-dave.taht@gmail.com> <20180424114407.5939-1-toke@toke.dk> <20180424081406.5127f1bc@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Cake List , netdev@vger.kernel.org To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:33518 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbeDXPcC (ORCPT ); Tue, 24 Apr 2018 11:32:02 -0400 Received: by mail-lf0-f68.google.com with SMTP id m18-v6so3665461lfb.0 for ; Tue, 24 Apr 2018 08:32:01 -0700 (PDT) In-Reply-To: <20180424081406.5127f1bc@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 24 Apr 2018 13:44:06 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > +config NET_SCH_CAKE > + tristate "Common Applications Kept Enhanced (CAKE)" > + help > + Say Y here if you want to use the Common Applications Kept Enha= nced > + (CAKE) queue management algorithm. > + > + To compile this driver as a module, choose M here: the module > + will be called sch_cake. In net/sched/Kconfig we should probably add NF_CONNTRACK as a dependency: "depends on NF_CONNTRACK" Otherwise if NET_SCH_CAKE=3Dy and NF_CONNTRACK=3Dm compilation fails with: net/sched/sch_cake.o: In function `cake_enqueue': sch_cake.c:(.text+0x3e10): undefined reference to `nf_ct_get_tuplepr' sch_cake.c:(.text+0x3e3a): undefined reference to `nf_conntrack_find_get' make: *** [Makefile:1041: vmlinux] Error 1