All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Grytsov <al1img@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>
Subject: xl: common_domname issue
Date: Wed, 5 Apr 2017 16:13:42 +0300	[thread overview]
Message-ID: <CACvf2oU24Sa8=5tV7x3AfFppaX0+6GEVzM7y3++d1Yfpk-fVNw@mail.gmail.com> (raw)

Hi All,

There is global variable common_domname in xl.c.
It is used for domain migration. But there is an issue with it in
following use case:
if for example I call find_domain in xl_parse.c to find backend id for
a device parameter and then
issue reboot command for this domain, reboot fails as common_domname set to
the backend name.
Fail occurs due to following lines in xl_vmcontrol.c:

                if (common_domname
                    && strcmp(d_config.c_info.name, common_domname)) {
                    d_config.c_info.name = strdup(common_domname);
                }

It means that find_domain can be used only in specific places and only
for domain that
is currently handled. Is it expected behavior?

Thanks.
-- 
Best Regards,
Oleksandr Grytsov.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

             reply	other threads:[~2017-04-05 13:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 13:13 Oleksandr Grytsov [this message]
2017-04-05 16:07 ` xl: common_domname issue Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACvf2oU24Sa8=5tV7x3AfFppaX0+6GEVzM7y3++d1Yfpk-fVNw@mail.gmail.com' \
    --to=al1img@gmail.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.