From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oleksandr Grytsov <al1img@gmail.com>
Subject: Re: [PATCH 0/4] libxl: use libxl__device_kind string to
	access device
Date: Tue, 24 Oct 2017 10:41:04 +0300
Message-ID: <CACvf2oUD_tfwHvCK8+TjEMskjuuzJpeuh_WNyVVDfr6UhLeO6w@mail.gmail.com>
References: <1507195848-18346-1-git-send-email-al1img@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6538550618327872863=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <al1img@gmail.com>) id 1e6tpk-0007jT-GX
 for xen-devel@lists.xenproject.org; Tue, 24 Oct 2017 07:41:08 +0000
Received: by mail-it0-f65.google.com with SMTP id p138so8885699itp.2
 for <xen-devel@lists.xenproject.org>; Tue, 24 Oct 2017 00:41:06 -0700 (PDT)
In-Reply-To: <1507195848-18346-1-git-send-email-al1img@gmail.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Oleksandr Grytsov <oleksandr_grytsov@epam.com>
List-Id: xen-devel@lists.xenproject.org

--===============6538550618327872863==
Content-Type: multipart/alternative; boundary="001a113f9f6cbe9c76055c460fd2"

--001a113f9f6cbe9c76055c460fd2
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 5, 2017 at 12:30 PM, Oleksandr Grytsov <al1img@gmail.com> wrote:

> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
>
> In current implementation the path of device XS entry is created with
> string from libxl__device_kind enum. But access to the device entry
> usually done with hardcoded path. This is source of potential errors.
> This patchset changes hardcoded device name in the XS path to string
> representation of libxl__device_kind enum. Also it changes "type" field
> in libxl__..._devtype structure to keep libxl__device_kind. It allows
> to move some duplicated functions to macros.
>
> Oleksandr Grytsov (4):
>   libxl: use libxl__device_kind to get device XS entry
>   libxl: use libxl__device_kind in LIBXL_DEFINE_UPDATE_DEVID
>   libxl: move libxl__device_from_ to LIBXL_DEFINE_DEVICE_FROM_TYPE
>   libxl: move ibxl_devid_to_device_... to LIBXL_DEFINE_DEVID_TO_DEVICE
>
>  tools/libxl/libxl_9pfs.c      | 21 +++---------
>  tools/libxl/libxl_colo_nic.c  |  6 ++--
>  tools/libxl/libxl_console.c   | 36 +++++++++-----------
>  tools/libxl/libxl_create.c    |  4 +--
>  tools/libxl/libxl_device.c    | 10 +++---
>  tools/libxl/libxl_disk.c      | 28 +++++++++++-----
>  tools/libxl/libxl_domain.c    |  2 +-
>  tools/libxl/libxl_internal.h  | 77 ++++++++++++++++++++++++++++++
> ++++++-------
>  tools/libxl/libxl_netbuffer.c |  6 ++--
>  tools/libxl/libxl_nic.c       | 55 +++++++------------------------
>  tools/libxl/libxl_pci.c       | 21 ++++++++----
>  tools/libxl/libxl_usb.c       | 52 +++++++++++++++++++----------
>  tools/libxl/libxl_vdispl.c    | 62 ++++++----------------------------
>  tools/libxl/libxl_vkb.c       | 61 +++++-----------------------------
>  tools/libxl/libxl_vsnd.c      | 62 ++++++----------------------------
>  tools/libxl/libxl_vtpm.c      | 33 +++++++------------
>  16 files changed, 222 insertions(+), 314 deletions(-)
>
> --
> 2.7.4
>
>
ping

-- 
Best Regards,
Oleksandr Grytsov.

--001a113f9f6cbe9c76055c460fd2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On T=
hu, Oct 5, 2017 at 12:30 PM, Oleksandr Grytsov <span dir=3D"ltr">&lt;<a hre=
f=3D"mailto:al1img@gmail.com" target=3D"_blank">al1img@gmail.com</a>&gt;</s=
pan> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex">From: Oleksandr Grytsov &lt;<=
a href=3D"mailto:oleksandr_grytsov@epam.com">oleksandr_grytsov@epam.com</a>=
&gt;<br>
<br>
In current implementation the path of device XS entry is created with<br>
string from libxl__device_kind enum. But access to the device entry<br>
usually done with hardcoded path. This is source of potential errors.<br>
This patchset changes hardcoded device name in the XS path to string<br>
representation of libxl__device_kind enum. Also it changes &quot;type&quot;=
 field<br>
in libxl__..._devtype structure to keep libxl__device_kind. It allows<br>
to move some duplicated functions to macros.<br>
<br>
Oleksandr Grytsov (4):<br>
=C2=A0 libxl: use libxl__device_kind to get device XS entry<br>
=C2=A0 libxl: use libxl__device_kind in LIBXL_DEFINE_UPDATE_DEVID<br>
=C2=A0 libxl: move libxl__device_from_ to LIBXL_DEFINE_DEVICE_FROM_TYPE<br>
=C2=A0 libxl: move ibxl_devid_to_device_... to LIBXL_DEFINE_DEVID_TO_DEVICE=
<br>
<br>
=C2=A0tools/libxl/libxl_9pfs.c=C2=A0 =C2=A0 =C2=A0 | 21 +++---------<br>
=C2=A0tools/libxl/libxl_colo_nic.c=C2=A0 |=C2=A0 6 ++--<br>
=C2=A0tools/libxl/libxl_console.c=C2=A0 =C2=A0| 36 +++++++++-----------<br>
=C2=A0tools/libxl/libxl_create.c=C2=A0 =C2=A0 |=C2=A0 4 +--<br>
=C2=A0tools/libxl/libxl_device.c=C2=A0 =C2=A0 | 10 +++---<br>
=C2=A0tools/libxl/libxl_disk.c=C2=A0 =C2=A0 =C2=A0 | 28 +++++++++++-----<br=
>
=C2=A0tools/libxl/libxl_domain.c=C2=A0 =C2=A0 |=C2=A0 2 +-<br>
=C2=A0tools/libxl/libxl_internal.h=C2=A0 | 77 +++++++++++++++++++++++++++++=
+<wbr>++++++-------<br>
=C2=A0tools/libxl/libxl_netbuffer.c |=C2=A0 6 ++--<br>
=C2=A0tools/libxl/libxl_nic.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 55 +++++++-------=
----------------<wbr>-<br>
=C2=A0tools/libxl/libxl_pci.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 21 ++++++++----<b=
r>
=C2=A0tools/libxl/libxl_usb.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 52 ++++++++++++++=
+++++----------<br>
=C2=A0tools/libxl/libxl_vdispl.c=C2=A0 =C2=A0 | 62 ++++++------------------=
------<wbr>----<br>
=C2=A0tools/libxl/libxl_vkb.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 61 +++++---------=
----------------<wbr>----<br>
=C2=A0tools/libxl/libxl_vsnd.c=C2=A0 =C2=A0 =C2=A0 | 62 ++++++-------------=
-----------<wbr>----<br>
=C2=A0tools/libxl/libxl_vtpm.c=C2=A0 =C2=A0 =C2=A0 | 33 +++++++------------=
<br>
=C2=A016 files changed, 222 insertions(+), 314 deletions(-)<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
2.7.4<br>
<br>
</font></span></blockquote></div><br></div><div class=3D"gmail_extra">ping<=
br clear=3D"all"></div><div class=3D"gmail_extra"><br>-- <br><div class=3D"=
gmail_signature" data-smartmail=3D"gmail_signature">Best Regards,<br>Oleksa=
ndr Grytsov.</div>
</div></div>

--001a113f9f6cbe9c76055c460fd2--


--===============6538550618327872863==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============6538550618327872863==--