All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Vinay Simha B N <simhavcs@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Robert Chiras <robert.chiras@nxp.com>,
	Thierry Reding <treding@nvidia.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline
Date: Thu, 7 May 2020 17:18:09 +0100	[thread overview]
Message-ID: <CACvgo50=scDC32UrWQQ0QLXFTh1e8w8GcPFs52f6+jNMwesGOQ@mail.gmail.com> (raw)
In-Reply-To: <CAGWqDJ4rAmwMzb6Q61Ou9ZLNA2M-i-JhOSokVUkHYHa_-ZxCTw@mail.gmail.com>

On Thu, 7 May 2020 at 13:29, Vinay Simha B N <simhavcs@gmail.com> wrote:
>
> Emil,
>
> Reply inline
>
> On Tue, 5 May 2020 at 9:35 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>>
>> From: Emil Velikov <emil.velikov@collabora.com>
>>
>> The helper uses the MIPI_DCS_SET_TEAR_SCANLINE, although it's currently
>> using the generic write. This does not look right.
>>
>> Perhaps some platforms don't distinguish between the two writers?
>>
>> Cc: Robert Chiras <robert.chiras@nxp.com>
>> Cc: Vinay Simha BN <simhavcs@gmail.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Thierry Reding <treding@nvidia.com>
>> Fixes: e83950816367 ("drm/dsi: Implement set tear scanline")
>> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
>> ---
>> Robert, can you please test this against the only user - the Raydium
>> RM67191 panel driver that you introduced.
>>
>> Thanks
>>
>> Vinay, can you confirm if this is a genuine typo or there's something
>> really subtle happening.
>
> this has been tested on nexus 7 with jdi panel.
The jdi panel (JDI LT070ME05000 I believe) does not use the function, hmm.

Looking through the ML archive - the call in the first 4 revisions of the patch.
Then with v5 it has magically disappeared alongside mipi_dsi_dcs_set_tear_on().

No comment explaining why though - does the driver work w/o both of those?

> I did not understand what is the typo here?
> We need to use DC’s write instead of generic write?

I believe the clue is in the command name - MIPI_DSI_DCS. I was going
to double-check with the spec although it's members only :-\
Based on the usage in DRM, all DCS commands are issued via
mipi_dsi_dcs_{read,write}

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-05-07 16:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 16:03 [PATCH 1/3] drm/dsi: use stack buffer in mipi_dsi_dcs_write() Emil Velikov
2020-05-05 16:03 ` [PATCH 2/3] drm/panel: use mipi_dsi_dcs_write_buffer where possible Emil Velikov
2020-05-11 11:28   ` Emil Velikov
2020-06-29  7:46     ` Sam Ravnborg
2020-05-05 16:03 ` [PATCH 3/3] drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline Emil Velikov
2020-05-07 12:29   ` Vinay Simha B N
2020-05-07 16:18     ` Emil Velikov [this message]
2020-05-13  9:44       ` Emil Velikov
2020-06-07 16:17         ` Vinay Simha B N
2020-06-05 17:36   ` Thierry Reding
2020-06-29  7:47   ` Sam Ravnborg
2020-05-28 16:47 ` [PATCH 1/3] drm/dsi: use stack buffer in mipi_dsi_dcs_write() Emil Velikov
2020-06-05 17:37   ` Thierry Reding
2020-06-05 17:26 ` Thierry Reding
2020-06-29  7:46 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACvgo50=scDC32UrWQQ0QLXFTh1e8w8GcPFs52f6+jNMwesGOQ@mail.gmail.com' \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=robert.chiras@nxp.com \
    --cc=simhavcs@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.