From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC530C433DF for ; Thu, 28 May 2020 15:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B32702053B for ; Thu, 28 May 2020 15:54:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+6c+/zy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404793AbgE1Pyp (ORCPT ); Thu, 28 May 2020 11:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404774AbgE1Pyk (ORCPT ); Thu, 28 May 2020 11:54:40 -0400 Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D25EC08C5C6 for ; Thu, 28 May 2020 08:54:40 -0700 (PDT) Received: by mail-vk1-xa43.google.com with SMTP id r11so6847969vkf.11 for ; Thu, 28 May 2020 08:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eD9Q69yAidIqs4JbIyrQRrLyc1rX+qPaojDMR0joP5U=; b=C+6c+/zy8X6oTdVUsHMPt6wtqdA0tC4QkpLSWdowQI9DkamTI3pEeTTNwx05CUF3Ck j9QffXYNwLwSAwzGnNt5/ybY54h7uLZdbuPeEvcHeqdlowZRVJZ2u0Z8z9fGW66IR/Ec g1E8wcwTUs1kkq97e0xEC+nhTHjbKMwHHKRvv2bi+dJDaUvPB6Eyi5bItg1rvvrgB26l 1pPdNkR6iMiN1GoI7/dpaQeKS3596mUhoP/w6UbOIPxD2QsREiYbX/29PTbKxGMG/Gtr voApI0UepKgzJ5C9/b+P2vRerTtJqf0vDAVf1Oo7UvGcpfMU4ZqjBtYzbYTZLa/rS/fE b/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eD9Q69yAidIqs4JbIyrQRrLyc1rX+qPaojDMR0joP5U=; b=RxkjLz8J7Wxke2xY10N6gCktze5tFS4tR9MkNLF4oUYg8eLZQlKKxaPF91jCey69Yx 0AqNJbqdVz0/X/7GajQwBB8N2qmLmw//r8ScdgYUUkpTzt+YyPuBd5otkL2orFrzLuUs P6orfGtX4roxRps6Yrfv01tqJMf86SR14k+R2ksMEEwmbamN/7anDSiWB8hHonT4lA6g hgAMnrDj0+5JDSIN9e23gmE0skefgYXhRKdz3uQQ/cuCDpCeTk/tk+eibdTzBJw5XRFD N7k+PK+WSKEKULCNRHhx/TnpsSoQt8r2/EBoEQ3N2ysQIVkfQ307UieW92WOEnfM/tgi aDyg== X-Gm-Message-State: AOAM530Wu302h7gg55qiMVfnZOxIsSbDVAcyU2UpqFzzO4eicsP0G/uR TNMgmCbpyQQ0biFZkFe/rTRAFnYfp5/n0Zs/uow= X-Google-Smtp-Source: ABdhPJw8Xk8oV6L3uEur2x175XF+krnVvLBDXMAI0SFt0rkatKFthbfQqghuLCvU+aV4LiyrGoasfZr/GxwSNaGmR1s= X-Received: by 2002:a1f:a3c1:: with SMTP id m184mr2268337vke.38.1590681279501; Thu, 28 May 2020 08:54:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Emil Velikov Date: Thu, 28 May 2020 16:51:31 +0100 Message-ID: Subject: Re: [PATCH v3 066/105] drm/vc4: txp: Turn the TXP into a CRTC of its own To: Maxime Ripard Cc: Nicolas Saenz Julienne , Eric Anholt , Tim Gover , Dave Stevenson , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , LAKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, Have you considered splitting the series into several parts and focusing on merging one at a time? IIRC this the longest series _ever_ submitted to dri-devel, plus it seems to be growing with each revision. Due to the sheer volume, it's likely to miss various points - large or small (like below). On Thu, 28 May 2020 at 08:47, Maxime Ripard wrote: > +static int vc4_txp_enable_vblank(struct drm_crtc *crtc) > +{ > + return 0; > +} > + > +static void vc4_txp_disable_vblank(struct drm_crtc *crtc) {} > + Core should handle if these are NULL, so the stubs should not be needed. HTH Emil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6DEC433E0 for ; Thu, 28 May 2020 15:54:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A2102071A for ; Thu, 28 May 2020 15:54:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kPf9HUFc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+6c+/zy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A2102071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LknVLdo63U82/bnerO1OvXebNPiugJ2hZUZbvMtmNvQ=; b=kPf9HUFcwS2t6q JSJlwVcTLQgmlrYAq/YNsaZcxhE9Yn0NBz8CBjHB618Ernreh9GKLVA7IT15Ljod4fH9asOULL8V3 HJAuas0DJpIsLl3qYWfVL05zE9kmcI7oTvM1yZ5jJgGXwQbs0BChMCgSKVclj8kWcEtH5RKZ5vKXw asaiQNjk2RDB7UuxXCQj7lxYlQ1nM46kqvRZEvShQ3KjYLTP1Us4NHYUh0Cy7ZV+l8OdZ6/2rEeOu 73SrL3E6gP49n3woO4qkxsMnDvBB2clsyhgi3OpDNys3cK4QDbpdaAbNhMlbZ3JkS5+w2PpGMmEDG nMBy41LNA9wzrDc1Pf5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKrm-00089t-BK; Thu, 28 May 2020 15:54:46 +0000 Received: from mail-vk1-xa41.google.com ([2607:f8b0:4864:20::a41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKrj-0007nV-5v; Thu, 28 May 2020 15:54:44 +0000 Received: by mail-vk1-xa41.google.com with SMTP id j28so6868111vkn.8; Thu, 28 May 2020 08:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eD9Q69yAidIqs4JbIyrQRrLyc1rX+qPaojDMR0joP5U=; b=C+6c+/zy8X6oTdVUsHMPt6wtqdA0tC4QkpLSWdowQI9DkamTI3pEeTTNwx05CUF3Ck j9QffXYNwLwSAwzGnNt5/ybY54h7uLZdbuPeEvcHeqdlowZRVJZ2u0Z8z9fGW66IR/Ec g1E8wcwTUs1kkq97e0xEC+nhTHjbKMwHHKRvv2bi+dJDaUvPB6Eyi5bItg1rvvrgB26l 1pPdNkR6iMiN1GoI7/dpaQeKS3596mUhoP/w6UbOIPxD2QsREiYbX/29PTbKxGMG/Gtr voApI0UepKgzJ5C9/b+P2vRerTtJqf0vDAVf1Oo7UvGcpfMU4ZqjBtYzbYTZLa/rS/fE b/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eD9Q69yAidIqs4JbIyrQRrLyc1rX+qPaojDMR0joP5U=; b=Pv1X2+9pCr3F+pd1Z/iCYmLf4+vidWRVpBO8KU/zoEfvaIsPINzKzOQENUc8pKWqaH DAjedzd89nIvkx8hMlrEm46za3/6c/fWg2U4oPZs2axoOU6YvhSAZT5sTxd0DcxJvWTy OWLvvcL/tjUIqLwdwQ8k7VQdejaLNgK8O6njfEkQPJPco4k/7G6zjDJTCWXNTzY7jq70 jcehfzsZQLYIbEYTc+Lq7py31pDXIvpFXF7ALWv58hn59u0Vgy/+FSOkF9sb31ujvqtw 79WUyKScFwM//Pv/oFtRrk1tedpGe+vtIyeuVn0jOzWluVCiDg5s38mdG614AwEpcfks W3ow== X-Gm-Message-State: AOAM5313QW1elMdkk8srAI/0y7B6AbC6uPIBexPEwOMUPBoCCYp8rvxR sbtucl5cMjPm3SjCmhAweLC+zkRNZJ8Qjzhya1c= X-Google-Smtp-Source: ABdhPJw8Xk8oV6L3uEur2x175XF+krnVvLBDXMAI0SFt0rkatKFthbfQqghuLCvU+aV4LiyrGoasfZr/GxwSNaGmR1s= X-Received: by 2002:a1f:a3c1:: with SMTP id m184mr2268337vke.38.1590681279501; Thu, 28 May 2020 08:54:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Emil Velikov Date: Thu, 28 May 2020 16:51:31 +0100 Message-ID: Subject: Re: [PATCH v3 066/105] drm/vc4: txp: Turn the TXP into a CRTC of its own To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_085443_246361_5A7C530D X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LAKML , Tim Gover , Dave Stevenson , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, Have you considered splitting the series into several parts and focusing on merging one at a time? IIRC this the longest series _ever_ submitted to dri-devel, plus it seems to be growing with each revision. Due to the sheer volume, it's likely to miss various points - large or small (like below). On Thu, 28 May 2020 at 08:47, Maxime Ripard wrote: > +static int vc4_txp_enable_vblank(struct drm_crtc *crtc) > +{ > + return 0; > +} > + > +static void vc4_txp_disable_vblank(struct drm_crtc *crtc) {} > + Core should handle if these are NULL, so the stubs should not be needed. HTH Emil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3B9C433DF for ; Thu, 28 May 2020 15:54:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DFE62053B for ; Thu, 28 May 2020 15:54:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+6c+/zy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DFE62053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D27A86E152; Thu, 28 May 2020 15:54:40 +0000 (UTC) Received: from mail-vk1-xa42.google.com (mail-vk1-xa42.google.com [IPv6:2607:f8b0:4864:20::a42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BC9D6E152 for ; Thu, 28 May 2020 15:54:40 +0000 (UTC) Received: by mail-vk1-xa42.google.com with SMTP id e1so2207527vkd.1 for ; Thu, 28 May 2020 08:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eD9Q69yAidIqs4JbIyrQRrLyc1rX+qPaojDMR0joP5U=; b=C+6c+/zy8X6oTdVUsHMPt6wtqdA0tC4QkpLSWdowQI9DkamTI3pEeTTNwx05CUF3Ck j9QffXYNwLwSAwzGnNt5/ybY54h7uLZdbuPeEvcHeqdlowZRVJZ2u0Z8z9fGW66IR/Ec g1E8wcwTUs1kkq97e0xEC+nhTHjbKMwHHKRvv2bi+dJDaUvPB6Eyi5bItg1rvvrgB26l 1pPdNkR6iMiN1GoI7/dpaQeKS3596mUhoP/w6UbOIPxD2QsREiYbX/29PTbKxGMG/Gtr voApI0UepKgzJ5C9/b+P2vRerTtJqf0vDAVf1Oo7UvGcpfMU4ZqjBtYzbYTZLa/rS/fE b/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eD9Q69yAidIqs4JbIyrQRrLyc1rX+qPaojDMR0joP5U=; b=ZnmzWJrZr5j0Sm87oZ6lLLJ06es5v83UvqVpK6QCfCcq9pwmHwg3Y+wt3yT0ARFZYG lt7PsZGxpJTFflMxJTxVr2rscr8Gye1AUpoTpTu7fiV6mCkC7asmwgahoQGPOy+tTyIE OPsnThKz7fFDKsxjfjoiMqrc/IQnNb2wpWzfHbiwfT24QK6gBMKYgi+BMQ3LFaLxA8kE 2g0eSdeoH8dYCseFwS5GX3wC0UKx0dNyAqmFBcRR5SyhUfYy9Vv96GVZSF8nxmbXdvt8 lEPTwzW+CYGmmrSevOg1nzKVPgiiUB/vMlGwWSTFCeSUfbAl38Y3L4rH+/P2bZnG5bxR ur3Q== X-Gm-Message-State: AOAM5329bvg4HwZSBEBJqSI79mwuvwfIqj0k9utJMoypDsdXwlAButgR ZSst8t6ZWyl1FTs8Nu4vAlPP+bkSyvGrzsf9S38= X-Google-Smtp-Source: ABdhPJw8Xk8oV6L3uEur2x175XF+krnVvLBDXMAI0SFt0rkatKFthbfQqghuLCvU+aV4LiyrGoasfZr/GxwSNaGmR1s= X-Received: by 2002:a1f:a3c1:: with SMTP id m184mr2268337vke.38.1590681279501; Thu, 28 May 2020 08:54:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Emil Velikov Date: Thu, 28 May 2020 16:51:31 +0100 Message-ID: Subject: Re: [PATCH v3 066/105] drm/vc4: txp: Turn the TXP into a CRTC of its own To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LAKML , Tim Gover , Dave Stevenson , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, Have you considered splitting the series into several parts and focusing on merging one at a time? IIRC this the longest series _ever_ submitted to dri-devel, plus it seems to be growing with each revision. Due to the sheer volume, it's likely to miss various points - large or small (like below). On Thu, 28 May 2020 at 08:47, Maxime Ripard wrote: > +static int vc4_txp_enable_vblank(struct drm_crtc *crtc) > +{ > + return 0; > +} > + > +static void vc4_txp_disable_vblank(struct drm_crtc *crtc) {} > + Core should handle if these are NULL, so the stubs should not be needed. HTH Emil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel