From: Emil Velikov <emil.l.velikov@gmail.com>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH libdrm] autogen.sh: set format.subjectPrefix and sendemail.to if needed
Date: Tue, 13 Dec 2016 16:00:53 +0000 [thread overview]
Message-ID: <CACvgo50s=RhEU54ALCgRNXrsPyr-O-O-17fU9v1K8xa5AEGYtA@mail.gmail.com> (raw)
In-Reply-To: <20161213154227.GD29253@imgtec.com>
On 13 December 2016 at 15:42, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> On Tuesday, 2016-12-13 16:16:50 +0200, Jani Nikula wrote:
>> On Tue, 13 Dec 2016, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> > Just set the rules automatically rather than asking each contributor to
>> > update thing locally.
>> >
>> > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
>> > ---
>> > autogen.sh | 6 ++++++
>> > 1 file changed, 6 insertions(+)
>> >
>> > diff --git a/autogen.sh b/autogen.sh
>> > index c896097..e936f04 100755
>> > --- a/autogen.sh
>> > +++ b/autogen.sh
>> > @@ -9,6 +9,12 @@ cd "$srcdir"
>> > autoreconf --force --verbose --install || exit 1
>> > cd "$ORIGDIR" || exit $?
>> >
>> > +git config --local --get format.subjectPrefix ||
>> > + git config --local format.subjectPrefix "PATCH libdrm"
>> > +
>> > +git config --local --get sendemail.to ||
>> > + git config --local sendemail.to "dri-devel@lists.freedesktop.org"
>> > +
>>
>> So I don't really play with libdrm source much, but can you expect this
>> to only be run in a git repo? How about source/distro/tarball releases?
>
> These will print an error like this and not do anything, so it should be
> fine:
> error: could not lock config file .git/config: No such file or directory
>
> These errors should be hidden though, as we don't care about such
> failures, and the config reads should also be silenced as they will
> print the previously set values.
>
> With that fixed:
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
>
Actually we don't ship autogen.sh within the tarball, but regardless.
With a simple "2>/dev/null" things seems to be fine ...
Thanks
Emil
P.S. I wonder if we really shouldn't do this for wayland/weston, Xorg,
and dozens of others ;-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-13 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 13:09 [PATCH libdrm] autogen.sh: set format.subjectPrefix and sendemail.to if needed Emil Velikov
2016-12-13 14:16 ` Jani Nikula
2016-12-13 15:42 ` Eric Engestrom
2016-12-13 16:00 ` Emil Velikov [this message]
2016-12-14 7:04 ` Michel Dänzer
2016-12-14 17:08 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo50s=RhEU54ALCgRNXrsPyr-O-O-17fU9v1K8xa5AEGYtA@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.engestrom@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.