From: Emil Velikov <emil.l.velikov@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, David Airlie <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
Jonathan Corbet <corbet@lwn.net>,
Thierry Reding <thierry.reding@gmail.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [Intel-gfx] [PATCH v6 0/4] New debugfs API for capturing CRC of frames
Date: Thu, 8 Sep 2016 14:38:12 +0100 [thread overview]
Message-ID: <CACvgo50t933bwstnzB6JTNLv5ZyWXDzhZuVo5xQSDqO6trjfuA@mail.gmail.com> (raw)
In-Reply-To: <1473244056-10157-1-git-send-email-tomeu.vizoso@collabora.com>
On 7 September 2016 at 11:27, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> Hi,
>
> this series basically takes the facility for continuously capturing CRCs
> of frames from the i915 driver and into the DRM core.
>
> The idea is that test suites such as IGT use this information to check
> that frames that are exected to be identical, also have identical CRC
> values.
>
> Other drivers for hardware that can provide frame CRCs (including eDP
> panels that support self-refresh) can easily implement the new callback
> and provide userspace with the CRC values.
>
> Thanks,
>
> Tomeu
>
> Tomeu Vizoso (4):
> drm/i915/debugfs: Move out pipe CRC code
> drm: Add API for capturing frame CRCs
> drm/i915: Use new CRC debugfs API
> drm/i915: Put "cooked" vlank counters in frame CRC lines
>
Thanks for the nice work and addressing my suggestions Tomeu. I think
I've spotted a bug in 2/4, plus there's a couple of trivial nitpicks
in 2/4 and 3/4 - either of which can be fixed as a follow up (if I
haven't lost it of course).
With the bug trivially fixed the series is:
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
-Emil
prev parent reply other threads:[~2016-09-08 13:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 10:27 [PATCH v6 0/4] New debugfs API for capturing CRC of frames Tomeu Vizoso
2016-09-07 10:27 ` Tomeu Vizoso
2016-09-07 10:27 ` [PATCH v6 1/4] drm/i915/debugfs: Move out pipe CRC code Tomeu Vizoso
2016-09-07 10:27 ` Tomeu Vizoso
2016-09-07 10:27 ` [PATCH v6 2/4] drm: Add API for capturing frame CRCs Tomeu Vizoso
2016-09-07 10:27 ` Tomeu Vizoso
2016-09-08 13:24 ` Emil Velikov
2016-09-08 13:24 ` Emil Velikov
2016-09-08 14:49 ` Tomeu Vizoso
2016-09-08 14:49 ` Tomeu Vizoso
2016-09-08 15:08 ` Emil Velikov
2016-09-08 15:08 ` Emil Velikov
2016-09-07 10:27 ` [PATCH v6 3/4] drm/i915: Use new CRC debugfs API Tomeu Vizoso
2016-09-07 10:27 ` Tomeu Vizoso
2016-09-08 13:35 ` [Intel-gfx] " Emil Velikov
2016-09-08 13:35 ` Emil Velikov
2016-09-08 14:47 ` Tomeu Vizoso
2016-09-07 10:27 ` [PATCH v6 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines Tomeu Vizoso
2016-09-07 10:27 ` Tomeu Vizoso
2016-09-08 13:38 ` Emil Velikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo50t933bwstnzB6JTNLv5ZyWXDzhZuVo5xQSDqO6trjfuA@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=corbet@lwn.net \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.