From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <1473081421-16555-18-git-send-email-peter.griffin@linaro.org> <20160920083251.GB26093@griffinp-ThinkPad-X1-Carbon-2nd> <8760pqncee.fsf@intel.com> <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> From: Emil Velikov Date: Thu, 6 Oct 2016 11:45:41 +0100 Message-ID: Subject: Re: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To: Peter Griffin Cc: Jani Nikula , Arnd Bergmann , Ohad Ben-Cohen , devicetree , kernel@stlinux.com, vinod.koul@intel.com, Lee Jones , linux-remoteproc@vger.kernel.org, patrice.chotard@st.com, ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , Gerd Hoffmann , dmaengine@vger.kernel.org, dan.j.williams@intel.com, Bjorn Andersson , "open list:VIRTIO GPU DRIVER" , LAKML List-ID: On 6 October 2016 at 10:37, Peter Griffin wrote: > In fact the help text for VIRTIO even states this option should be select= ed > by any driver which implements virtio. > Almost but not quite. It says: "This option is selected by any driver which implements the virtio _bus_" REMOTEPROC obviously does that while the ST SLIM driver does not. Thus the latter should _not_ select, be that explicitly or implicitly via REMOTEPROC, the symbol. >> >> People tend to abuse select because it's "convenient". If you depend, >> but some of your dependencies aren't met, you're in for some digging >> through Kconfig to find the missing deps. Just to make the option you >> want visible in menuconfig. If you instead select something with >> dependencies, it'll be right most of the time, and it's "convenient", >> until it breaks. (And hey, it usually breaks for someone else with some >> other config, so it's still convenient for you.) > > I'm sure they do but in this case it is actually the use of 'depends on' > which has caused the breakage and inconvenience for somebody else and sad= ly this > inconvienice is still on-going due to this patch not being applied or get= ting an > acked-by from the appropriate maintainers. > Surely you're not saying that pre-existing driver following the documentation, is 'causing breakage' for a new driver {ab,mis}using a feature ? This reminds me an old saying: "If the shoe doesn=E2=80=99t fit, it doesn= =E2=80=99t mean there is anything wrong with your feet." You seem to be suggesting the opposite ? >> >> Perhaps kconfig should complain about selecting visible symbols and >> symbols with dependencies. > > That sounds like it would be a useful addition. > > Is it possible to get this patch applied or an acked-by to avoid further = delay > to the fdma series? > Please don't apply duct tape, especially where it's _not_ needed. $ sed -i s/select REMOTEPROC/depends on REMOTEPROC/ drivers/remoteproc/Kcon= fig ... will resolve things in the right place. The alternative will lead to random issues in other subsystems. Regards, Emil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755465AbcJFKpx (ORCPT ); Thu, 6 Oct 2016 06:45:53 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35507 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbcJFKpp (ORCPT ); Thu, 6 Oct 2016 06:45:45 -0400 MIME-Version: 1.0 In-Reply-To: <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <1473081421-16555-18-git-send-email-peter.griffin@linaro.org> <20160920083251.GB26093@griffinp-ThinkPad-X1-Carbon-2nd> <8760pqncee.fsf@intel.com> <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> From: Emil Velikov Date: Thu, 6 Oct 2016 11:45:41 +0100 Message-ID: Subject: Re: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue. To: Peter Griffin Cc: Jani Nikula , Arnd Bergmann , Ohad Ben-Cohen , devicetree , kernel@stlinux.com, vinod.koul@intel.com, Lee Jones , linux-remoteproc@vger.kernel.org, patrice.chotard@st.com, ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , Gerd Hoffmann , dmaengine@vger.kernel.org, dan.j.williams@intel.com, Bjorn Andersson , "open list:VIRTIO GPU DRIVER" , LAKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u96AlWeD019247 On 6 October 2016 at 10:37, Peter Griffin wrote: > In fact the help text for VIRTIO even states this option should be selected > by any driver which implements virtio. > Almost but not quite. It says: "This option is selected by any driver which implements the virtio _bus_" REMOTEPROC obviously does that while the ST SLIM driver does not. Thus the latter should _not_ select, be that explicitly or implicitly via REMOTEPROC, the symbol. >> >> People tend to abuse select because it's "convenient". If you depend, >> but some of your dependencies aren't met, you're in for some digging >> through Kconfig to find the missing deps. Just to make the option you >> want visible in menuconfig. If you instead select something with >> dependencies, it'll be right most of the time, and it's "convenient", >> until it breaks. (And hey, it usually breaks for someone else with some >> other config, so it's still convenient for you.) > > I'm sure they do but in this case it is actually the use of 'depends on' > which has caused the breakage and inconvenience for somebody else and sadly this > inconvienice is still on-going due to this patch not being applied or getting an > acked-by from the appropriate maintainers. > Surely you're not saying that pre-existing driver following the documentation, is 'causing breakage' for a new driver {ab,mis}using a feature ? This reminds me an old saying: "If the shoe doesn’t fit, it doesn’t mean there is anything wrong with your feet." You seem to be suggesting the opposite ? >> >> Perhaps kconfig should complain about selecting visible symbols and >> symbols with dependencies. > > That sounds like it would be a useful addition. > > Is it possible to get this patch applied or an acked-by to avoid further delay > to the fdma series? > Please don't apply duct tape, especially where it's _not_ needed. $ sed -i s/select REMOTEPROC/depends on REMOTEPROC/ drivers/remoteproc/Kconfig ... will resolve things in the right place. The alternative will lead to random issues in other subsystems. Regards, Emil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue. Date: Thu, 6 Oct 2016 11:45:41 +0100 Message-ID: References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <1473081421-16555-18-git-send-email-peter.griffin@linaro.org> <20160920083251.GB26093@griffinp-ThinkPad-X1-Carbon-2nd> <8760pqncee.fsf@intel.com> <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Griffin Cc: Jani Nikula , Arnd Bergmann , Ohad Ben-Cohen , devicetree , kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Lee Jones , linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, patrice.chotard-qxv4g6HH51o@public.gmane.org, ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , Gerd Hoffmann , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Bjorn Andersson , "open list:VIRTIO GPU DRIVER" , LAKML List-Id: devicetree@vger.kernel.org On 6 October 2016 at 10:37, Peter Griffin wrote: > In fact the help text for VIRTIO even states this option should be select= ed > by any driver which implements virtio. > Almost but not quite. It says: "This option is selected by any driver which implements the virtio _bus_" REMOTEPROC obviously does that while the ST SLIM driver does not. Thus the latter should _not_ select, be that explicitly or implicitly via REMOTEPROC, the symbol. >> >> People tend to abuse select because it's "convenient". If you depend, >> but some of your dependencies aren't met, you're in for some digging >> through Kconfig to find the missing deps. Just to make the option you >> want visible in menuconfig. If you instead select something with >> dependencies, it'll be right most of the time, and it's "convenient", >> until it breaks. (And hey, it usually breaks for someone else with some >> other config, so it's still convenient for you.) > > I'm sure they do but in this case it is actually the use of 'depends on' > which has caused the breakage and inconvenience for somebody else and sad= ly this > inconvienice is still on-going due to this patch not being applied or get= ting an > acked-by from the appropriate maintainers. > Surely you're not saying that pre-existing driver following the documentation, is 'causing breakage' for a new driver {ab,mis}using a feature ? This reminds me an old saying: "If the shoe doesn=E2=80=99t fit, it doesn= =E2=80=99t mean there is anything wrong with your feet." You seem to be suggesting the opposite ? >> >> Perhaps kconfig should complain about selecting visible symbols and >> symbols with dependencies. > > That sounds like it would be a useful addition. > > Is it possible to get this patch applied or an acked-by to avoid further = delay > to the fdma series? > Please don't apply duct tape, especially where it's _not_ needed. $ sed -i s/select REMOTEPROC/depends on REMOTEPROC/ drivers/remoteproc/Kcon= fig ... will resolve things in the right place. The alternative will lead to random issues in other subsystems. Regards, Emil -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: emil.l.velikov@gmail.com (Emil Velikov) Date: Thu, 6 Oct 2016 11:45:41 +0100 Subject: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue. In-Reply-To: <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <1473081421-16555-18-git-send-email-peter.griffin@linaro.org> <20160920083251.GB26093@griffinp-ThinkPad-X1-Carbon-2nd> <8760pqncee.fsf@intel.com> <20161006093721.GA436@griffinp-ThinkPad-X1-Carbon-2nd> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 6 October 2016 at 10:37, Peter Griffin wrote: > In fact the help text for VIRTIO even states this option should be selected > by any driver which implements virtio. > Almost but not quite. It says: "This option is selected by any driver which implements the virtio _bus_" REMOTEPROC obviously does that while the ST SLIM driver does not. Thus the latter should _not_ select, be that explicitly or implicitly via REMOTEPROC, the symbol. >> >> People tend to abuse select because it's "convenient". If you depend, >> but some of your dependencies aren't met, you're in for some digging >> through Kconfig to find the missing deps. Just to make the option you >> want visible in menuconfig. If you instead select something with >> dependencies, it'll be right most of the time, and it's "convenient", >> until it breaks. (And hey, it usually breaks for someone else with some >> other config, so it's still convenient for you.) > > I'm sure they do but in this case it is actually the use of 'depends on' > which has caused the breakage and inconvenience for somebody else and sadly this > inconvienice is still on-going due to this patch not being applied or getting an > acked-by from the appropriate maintainers. > Surely you're not saying that pre-existing driver following the documentation, is 'causing breakage' for a new driver {ab,mis}using a feature ? This reminds me an old saying: "If the shoe doesn?t fit, it doesn?t mean there is anything wrong with your feet." You seem to be suggesting the opposite ? >> >> Perhaps kconfig should complain about selecting visible symbols and >> symbols with dependencies. > > That sounds like it would be a useful addition. > > Is it possible to get this patch applied or an acked-by to avoid further delay > to the fdma series? > Please don't apply duct tape, especially where it's _not_ needed. $ sed -i s/select REMOTEPROC/depends on REMOTEPROC/ drivers/remoteproc/Kconfig ... will resolve things in the right place. The alternative will lead to random issues in other subsystems. Regards, Emil