From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCH libdrm 04/10] xf86drm: Allocate drmDevicePtr's on stack Date: Thu, 28 Jun 2018 18:07:36 +0100 Message-ID: References: <20180625173626.8046-1-emil.l.velikov@gmail.com> <20180625173626.8046-4-emil.l.velikov@gmail.com> <221120fd-4719-c2c1-99fb-83c2a1a62c02@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEE2F6EE18 for ; Thu, 28 Jun 2018 17:07:38 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id e69-v6so7627365wme.2 for ; Thu, 28 Jun 2018 10:07:38 -0700 (PDT) In-Reply-To: <221120fd-4719-c2c1-99fb-83c2a1a62c02@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Robert Foss Cc: ML dri-devel List-Id: dri-devel@lists.freedesktop.org SGkgUm9iLAoKT24gMjggSnVuZSAyMDE4IGF0IDEzOjUyLCBSb2JlcnQgRm9zcyA8cm9iZXJ0LmZv c3NAY29sbGFib3JhLmNvbT4gd3JvdGU6Cj4gSGV5IEVtaWwsCj4KPiBPbiAyMDE4LTA2LTI1IDE5 OjM2LCBFbWlsIFZlbGlrb3Ygd3JvdGU6Cj4+Cj4+IEZyb206IEVtaWwgVmVsaWtvdiA8ZW1pbC52 ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4+Cj4+IEN1cnJlbnRseSB3ZSBkeW5hbWljYWxseSBhbGxv Y2F0ZSAxNiBwb2ludGVycyBhbmQgcmVhbGxvY2F0ZSBtb3JlIGFzCj4+IG5lZWRlZC4KPj4KPj4g SW5zdGVhZCwgYWxsb2NhdGUgdGhlIG1heGltdW0gbnVtYmVyICgyNTYpIG9uIHN0YWNrIC0gdGhl IG51bWJlciBpcwo+PiBzbWFsbCBlbm91Z2ggYW5kIGlzIHVubGlrZWx5IHRvIGNoYW5nZSBpbiB0 aGUgZm9yZXNlZWFibGUgZnV0dXJlLgo+Pgo+PiBUaGlzIGFsbG93cyB1cyB0byBzaW1wbGlmeSB0 aGUgZXJyb3IgaGFuZGxpbmcgYW5kIGV2ZW4gc2hlZCBhIGZldyBieXRlcwo+PiBvZmYgdGhlIGZp bmFsIGJpbmFyeS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogRW1pbCBWZWxpa292IDxlbWlsLnZlbGlr b3ZAY29sbGFib3JhLmNvbT4KPj4gLS0tCj4+ICAgeGY4NmRybS5jIHwgNjQgKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBj aGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDU4IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0 IGEveGY4NmRybS5jIGIveGY4NmRybS5jCj4+IGluZGV4IDExNGNmODU1Li5kNDgxMDc0MCAxMDA2 NDQKPj4gLS0tIGEveGY4NmRybS5jCj4+ICsrKyBiL3hmODZkcm0uYwo+PiBAQCAtMzg0Niw3ICsz ODQ2LDcgQEAgaW50IGRybUdldERldmljZTIoaW50IGZkLCB1aW50MzJfdCBmbGFncywKPj4gZHJt RGV2aWNlUHRyICpkZXZpY2UpCj4+ICAgICAgICAgcmV0dXJuIDA7Cj4+ICAgI2Vsc2UKPj4gLSAg ICBkcm1EZXZpY2VQdHIgKmxvY2FsX2RldmljZXM7Cj4+ICsgICAgZHJtRGV2aWNlUHRyIGxvY2Fs X2RldmljZXNbMjU2XTsKPgo+Cj4gVGhpcyBudW1iZXIgaXMgc2VlbiBsYXRlciBvbiBpbiB0aGlz IHBhdGNoLCBtYXliZSBpdCBzaG91bGQgYmUgYnJva2VuIG91dAo+IGludG8gYQo+IGRlZmluZSwg c2luY2UgaXQncyByZXVzZWQgbGF0ZXIgb24gdG9vIGF0IFsxXS4KPgpTdXJlIHRoaW5nLiBUaGUg bGFtZSBNQVhfRFJNX05PREVTIGNvbWVzIHRvIG1pbmQsIHNvIGFsdGVybmF0aXZlcyBhcmUgd2Vs Y29tZS4KCj4KPj4gICAgICAgZHJtRGV2aWNlUHRyIGQ7Cj4+ICAgICAgIERJUiAqc3lzZGlyOwo+ PiAgICAgICBzdHJ1Y3QgZGlyZW50ICpkZW50Owo+PiBAQCAtMzg1NCw3ICszODU0LDYgQEAgaW50 IGRybUdldERldmljZTIoaW50IGZkLCB1aW50MzJfdCBmbGFncywKPj4gZHJtRGV2aWNlUHRyICpk ZXZpY2UpCj4+ICAgICAgIGludCBzdWJzeXN0ZW1fdHlwZTsKPj4gICAgICAgaW50IG1haiwgbWlu Owo+PiAgICAgICBpbnQgcmV0LCBpLCBub2RlX2NvdW50Owo+PiAtICAgIGludCBtYXhfY291bnQg PSAxNjsKPj4gICAgICAgZGV2X3QgZmluZF9yZGV2Owo+PiAgICAgICAgIGlmIChkcm1fZGV2aWNl X3ZhbGlkYXRlX2ZsYWdzKGZsYWdzKSkKPj4gQEAgLTM4NzcsMTUgKzM4NzYsOSBAQCBpbnQgZHJt R2V0RGV2aWNlMihpbnQgZmQsIHVpbnQzMl90IGZsYWdzLAo+PiBkcm1EZXZpY2VQdHIgKmRldmlj ZSkKPj4gICAgICAgaWYgKHN1YnN5c3RlbV90eXBlIDwgMCkKPj4gICAgICAgICAgIHJldHVybiBz dWJzeXN0ZW1fdHlwZTsKPj4gICAtICAgIGxvY2FsX2RldmljZXMgPSBjYWxsb2MobWF4X2NvdW50 LCBzaXplb2YoZHJtRGV2aWNlUHRyKSk7Cj4+IC0gICAgaWYgKGxvY2FsX2RldmljZXMgPT0gTlVM TCkKPj4gLSAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4+IC0KPj4gICAgICAgc3lzZGlyID0gb3Bl bmRpcihEUk1fRElSX05BTUUpOwo+PiAtICAgIGlmICghc3lzZGlyKSB7Cj4+IC0gICAgICAgIHJl dCA9IC1lcnJubzsKPj4gLSAgICAgICAgZ290byBmcmVlX2xvY2FsczsKPj4gLSAgICB9Cj4+ICsg ICAgaWYgKCFzeXNkaXIpCj4+ICsgICAgICAgIHJldHVybiAtZXJybm87Cj4+ICAgICAgICAgaSA9 IDA7Cj4+ICAgICAgIHdoaWxlICgoZGVudCA9IHJlYWRkaXIoc3lzZGlyKSkpIHsKPj4gQEAgLTM4 OTMsMTYgKzM4ODYsNiBAQCBpbnQgZHJtR2V0RGV2aWNlMihpbnQgZmQsIHVpbnQzMl90IGZsYWdz LAo+PiBkcm1EZXZpY2VQdHIgKmRldmljZSkKPj4gICAgICAgICAgIGlmIChyZXQpCj4+ICAgICAg ICAgICAgICAgY29udGludWU7Cj4+ICAgLSAgICAgICAgaWYgKGkgPj0gbWF4X2NvdW50KSB7Cj4K Pgo+IElzIHRoaXMgY2hlY2sgcmVhbGx5IG5vdCBuZWVkZGVkIHdoYXQgZXhhY3RseSBpcyBpdCB0 aGF0IGRlZmluZXMgMjU2IGFzIHRoZQo+IG1heGltdW0/Cj4KPiBGcm9tIHdoYXQgSSB1bmRlcnN0 YW5kIHJlYWRkaXIoc3lzZGlyKSBpcyB0aGUgY2FsbCB0aGF0IGRlZmluZXMgaG93IG1hbnkKPiBk ZXZpY2VzIHdpbGwgYmUgbG9va2VkIHRocm91Z2gsIGFuZCBhcyBmYXIgYXMgSSB1bmRlcnN0YW5k IGl0IGNhbiByZXR1cm4gYW4KPiBhcmJpdHJhcnkgbnVtYmVyIG9mIGZpbGVzLgo+ClRoZSBrZXJu ZWwgZHJtIGNvcmUgaGFzIGEgbnVtYmVyIG9mIHBsYWNlcyB0aGF0IGFzc3VtZSBtYXhpbXVtIG9m IDN4NjQKZGV2aWNlcyBub2Rlcy4KVGhhdCdzIDY0IGZvciBlYWNoIG9mIHByaW1hcnksIGNvbnRy b2wgYW5kIHJlbmRlciBub2Rlcy4gSSd2ZSByb3VuZGVkCml0IHVwIHRvIDI1NiBmb3Igc2ltcGxp Y2l0eS4KCkkgYXNzdW1lIHdlJ2xsIGJlIGFibGUgdG8gc2VlIGlmIGFueW9uZSBjaGFuZ2VzIHRo ZSBrZXJuZWwsIGFsdGhvdWdoCmJhaWxpbmcgb3V0IGp1c3QgaW4gY2FzZSBpcyBhIGdvb2QgaWRl YS4KVGhlIGlzIG9uZSBleGNpdGluZyBlcnJvciBtZXNzYWdlIC0gbGV0IG1lIGtub3cgaWYgYW55 dGhpbmcgZWxzZSBjb21lcyB0byBtaW5kLgoKaWYgKGkgPj0gTUFYX0RSTV9OT0RFUykgewogICAg ZnByaW50ZihzdGRlcnIsICJNb3JlIHRoYW4gJWQgZHJtIG5vZGVzIGRldGVjdGVkLiBQbGVhc2Ug cmVwb3J0IGEKYnVnIC0gdGhhdCBzaG91bGQgbm90IGhhcHBlbi5cblNraXBwaW5nIGV4dHJhIG5v ZGVzXG4iLApNQVhfRFJNX05PREVTKTsKICAgIGJyZWFrOwp9CgpJJ2xsIHNlbmQgb3V0IHYyIGZv ciB0aGUgcGF0Y2hlcyB0aGF0IG5lZWQgd29yayBzb21lIHRpbWUKdG9tb3Jyb3cvb3ZlciB0aGUg d2Vla2VuZC4uCgpUaGFua3MKRW1pbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK