* [PATCH] drm/i915: only disable default vga device @ 2021-05-16 17:14 ` Emil Velikov 0 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-16 17:14 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi; +Cc: intel-gfx, kernel, dri-devel From: Vivek Das Mohapatra <vivek@collabora.com> This patch is to do with seamless handover, eg when the sequence is bootloader → plymouth → desktop. It switches the vga arbiter from the "other" GPU to the default one (intel in this case), so the driver can issue some io(). Signed-off-by: Vivek Das Mohapatra <vivek@collabora.com> Signed-off-by: Emil Velikov <emil.velikov@collabora.com> --- Greetings all, This patch has been downstream for a while now yet it seems perfectly reasonable thing to have in the Linux kernel. https://github.com/ValveSoftware/steamos_kernel/commit/5431b5b1999c3d3b5efee817fb3373fbbd473063 drivers/gpu/drm/i915/display/intel_vga.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c index be333699c515..4f07b5ad5fa0 100644 --- a/drivers/gpu/drm/i915/display/intel_vga.c +++ b/drivers/gpu/drm/i915/display/intel_vga.c @@ -30,12 +30,14 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) u8 sr1; /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ - vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); - outb(SR01, VGA_SR_INDEX); - sr1 = inb(VGA_SR_DATA); - outb(sr1 | 1 << 5, VGA_SR_DATA); - vga_put(pdev, VGA_RSRC_LEGACY_IO); - udelay(300); + if (pdev == vga_default_device()) { + vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); + outb(SR01, VGA_SR_INDEX); + sr1 = inb(VGA_SR_DATA); + outb(sr1 | 1 << 5, VGA_SR_DATA); + vga_put(pdev, VGA_RSRC_LEGACY_IO); + udelay(300); + } intel_de_write(dev_priv, vga_reg, VGA_DISP_DISABLE); intel_de_posting_read(dev_priv, vga_reg); -- 2.27.0 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-05-16 17:14 ` Emil Velikov 0 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-16 17:14 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi; +Cc: intel-gfx, kernel, dri-devel From: Vivek Das Mohapatra <vivek@collabora.com> This patch is to do with seamless handover, eg when the sequence is bootloader → plymouth → desktop. It switches the vga arbiter from the "other" GPU to the default one (intel in this case), so the driver can issue some io(). Signed-off-by: Vivek Das Mohapatra <vivek@collabora.com> Signed-off-by: Emil Velikov <emil.velikov@collabora.com> --- Greetings all, This patch has been downstream for a while now yet it seems perfectly reasonable thing to have in the Linux kernel. https://github.com/ValveSoftware/steamos_kernel/commit/5431b5b1999c3d3b5efee817fb3373fbbd473063 drivers/gpu/drm/i915/display/intel_vga.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c index be333699c515..4f07b5ad5fa0 100644 --- a/drivers/gpu/drm/i915/display/intel_vga.c +++ b/drivers/gpu/drm/i915/display/intel_vga.c @@ -30,12 +30,14 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) u8 sr1; /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ - vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); - outb(SR01, VGA_SR_INDEX); - sr1 = inb(VGA_SR_DATA); - outb(sr1 | 1 << 5, VGA_SR_DATA); - vga_put(pdev, VGA_RSRC_LEGACY_IO); - udelay(300); + if (pdev == vga_default_device()) { + vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); + outb(SR01, VGA_SR_INDEX); + sr1 = inb(VGA_SR_DATA); + outb(sr1 | 1 << 5, VGA_SR_DATA); + vga_put(pdev, VGA_RSRC_LEGACY_IO); + udelay(300); + } intel_de_write(dev_priv, vga_reg, VGA_DISP_DISABLE); intel_de_posting_read(dev_priv, vga_reg); -- 2.27.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: only disable default vga device 2021-05-16 17:14 ` [Intel-gfx] " Emil Velikov (?) @ 2021-05-17 10:50 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2021-05-17 10:50 UTC (permalink / raw) To: Emil Velikov; +Cc: intel-gfx == Series Details == Series: drm/i915: only disable default vga device URL : https://patchwork.freedesktop.org/series/90213/ State : warning == Summary == $ dim checkpatch origin/drm-tip df2a974bb7e0 drm/i915: only disable default vga device -:38: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #38: FILE: drivers/gpu/drm/i915/display/intel_vga.c:39: + udelay(300); total: 0 errors, 0 warnings, 1 checks, 20 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: only disable default vga device 2021-05-16 17:14 ` [Intel-gfx] " Emil Velikov (?) (?) @ 2021-05-17 11:22 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2021-05-17 11:22 UTC (permalink / raw) To: Emil Velikov; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 15526 bytes --] == Series Details == Series: drm/i915: only disable default vga device URL : https://patchwork.freedesktop.org/series/90213/ State : success == Summary == CI Bug Log - changes from CI_DRM_10090 -> Patchwork_20134 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/index.html Known issues ------------ Here are the changes found in Patchwork_20134 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@busy@all: - fi-bsw-nick: [PASS][1] -> [FAIL][2] ([i915#3457]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-nick/igt@gem_busy@busy@all.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-nick/igt@gem_busy@busy@all.html * igt@gem_exec_fence@basic-await@bcs0: - fi-bsw-n3050: [PASS][3] -> [FAIL][4] ([i915#3457]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-n3050/igt@gem_exec_fence@basic-await@bcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-n3050/igt@gem_exec_fence@basic-await@bcs0.html * igt@gem_exec_fence@nb-await@vecs0: - fi-glk-dsi: [PASS][5] -> [FAIL][6] ([i915#3457]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-glk-dsi/igt@gem_exec_fence@nb-await@vecs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-glk-dsi/igt@gem_exec_fence@nb-await@vecs0.html - fi-bsw-kefka: [PASS][7] -> [FAIL][8] ([i915#3457]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-kefka/igt@gem_exec_fence@nb-await@vecs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-kefka/igt@gem_exec_fence@nb-await@vecs0.html * igt@gem_wait@busy@all: - fi-elk-e7500: [PASS][9] -> [FAIL][10] ([i915#3457]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-elk-e7500/igt@gem_wait@busy@all.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-elk-e7500/igt@gem_wait@busy@all.html * igt@i915_selftest@live@execlists: - fi-kbl-7500u: NOTRUN -> [DMESG-FAIL][11] ([i915#3462]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-7500u/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@hangcheck: - fi-snb-2600: [PASS][12] -> [INCOMPLETE][13] ([i915#2782]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-snb-2600/igt@i915_selftest@live@hangcheck.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-snb-2600/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@mman: - fi-kbl-7500u: NOTRUN -> [DMESG-WARN][14] ([i915#3457]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-7500u/igt@i915_selftest@live@mman.html * igt@kms_busy@basic@flip: - fi-ilk-650: [PASS][15] -> [INCOMPLETE][16] ([i915#3457]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-ilk-650/igt@kms_busy@basic@flip.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-ilk-650/igt@kms_busy@basic@flip.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-kbl-7500u: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#533]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-7500u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - fi-bsw-kefka: [PASS][18] -> [FAIL][19] ([i915#53]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-kefka/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-kefka/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-bwr-2160: [PASS][20] -> [FAIL][21] ([i915#53]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bwr-2160/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bwr-2160/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html - fi-elk-e7500: [PASS][22] -> [FAIL][23] ([i915#53]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-elk-e7500/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-elk-e7500/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_psr@primary_mmap_gtt: - fi-kbl-7500u: NOTRUN -> [SKIP][24] ([fdo#109271]) +8 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-7500u/igt@kms_psr@primary_mmap_gtt.html * igt@runner@aborted: - fi-ilk-650: NOTRUN -> [FAIL][25] ([i915#3475]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-ilk-650/igt@runner@aborted.html #### Possible fixes #### * igt@gem_exec_fence@nb-await@bcs0: - fi-bsw-nick: [FAIL][26] ([i915#3457]) -> [PASS][27] +2 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-nick/igt@gem_exec_fence@nb-await@bcs0.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-nick/igt@gem_exec_fence@nb-await@bcs0.html - fi-bsw-n3050: [FAIL][28] ([i915#3457]) -> [PASS][29] +1 similar issue [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-n3050/igt@gem_exec_fence@nb-await@bcs0.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-n3050/igt@gem_exec_fence@nb-await@bcs0.html * igt@gem_exec_fence@nb-await@vcs0: - fi-bsw-kefka: [FAIL][30] ([i915#3457]) -> [PASS][31] +3 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-kefka/igt@gem_exec_fence@nb-await@vcs0.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-kefka/igt@gem_exec_fence@nb-await@vcs0.html * igt@gem_wait@busy@all: - fi-bsw-nick: [FAIL][32] ([i915#3177] / [i915#3457]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-nick/igt@gem_wait@busy@all.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-nick/igt@gem_wait@busy@all.html - fi-glk-dsi: [FAIL][34] ([i915#3457]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-glk-dsi/igt@gem_wait@busy@all.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-glk-dsi/igt@gem_wait@busy@all.html * igt@gem_wait@wait@all: - fi-bwr-2160: [FAIL][36] ([i915#3457]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bwr-2160/igt@gem_wait@wait@all.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bwr-2160/igt@gem_wait@wait@all.html - fi-pnv-d510: [FAIL][38] ([i915#3457]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-pnv-d510/igt@gem_wait@wait@all.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-pnv-d510/igt@gem_wait@wait@all.html * igt@kms_addfb_basic@addfb25-bad-modifier: - fi-kbl-7500u: [{ABORT}][40] ([i915#1814]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-kbl-7500u/igt@kms_addfb_basic@addfb25-bad-modifier.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-7500u/igt@kms_addfb_basic@addfb25-bad-modifier.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a: - fi-bwr-2160: [FAIL][42] ([i915#53]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bwr-2160/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bwr-2160/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - fi-pnv-d510: [FAIL][44] ([i915#53]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-pnv-d510/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-pnv-d510/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a: - fi-elk-e7500: [FAIL][46] ([i915#53]) -> [PASS][47] +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html #### Warnings #### * igt@gem_exec_gttfill@basic: - fi-pnv-d510: [FAIL][48] ([i915#3472]) -> [FAIL][49] ([i915#3457] / [i915#3472]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-pnv-d510/igt@gem_exec_gttfill@basic.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-pnv-d510/igt@gem_exec_gttfill@basic.html - fi-ilk-650: [FAIL][50] ([i915#3472]) -> [FAIL][51] ([i915#3457] / [i915#3472]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-ilk-650/igt@gem_exec_gttfill@basic.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-ilk-650/igt@gem_exec_gttfill@basic.html * igt@i915_selftest@live@execlists: - fi-bsw-nick: [DMESG-FAIL][52] -> [INCOMPLETE][53] ([i915#2782] / [i915#2940]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bsw-nick/igt@i915_selftest@live@execlists.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bsw-nick/igt@i915_selftest@live@execlists.html - fi-icl-u2: [INCOMPLETE][54] ([i915#2782] / [i915#3462]) -> [DMESG-FAIL][55] ([i915#3462]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-icl-u2/igt@i915_selftest@live@execlists.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-icl-u2/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@mman: - fi-bwr-2160: [DMESG-FAIL][56] ([i915#3457]) -> [DMESG-WARN][57] ([i915#3457]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-bwr-2160/igt@i915_selftest@live@mman.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-bwr-2160/igt@i915_selftest@live@mman.html - fi-pnv-d510: [DMESG-FAIL][58] ([i915#3457]) -> [DMESG-WARN][59] ([i915#3457]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-pnv-d510/igt@i915_selftest@live@mman.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-pnv-d510/igt@i915_selftest@live@mman.html * igt@runner@aborted: - fi-icl-u2: [FAIL][60] ([i915#2782] / [i915#3363]) -> [FAIL][61] ([i915#2426] / [i915#2782] / [i915#3363]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-icl-u2/igt@runner@aborted.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-icl-u2/igt@runner@aborted.html - fi-glk-dsi: [FAIL][62] ([i915#3363] / [k.org#202321]) -> [FAIL][63] ([i915#2426] / [i915#3363] / [k.org#202321]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-glk-dsi/igt@runner@aborted.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-glk-dsi/igt@runner@aborted.html - fi-kbl-soraka: [FAIL][64] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][65] ([i915#1436] / [i915#3363]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-kbl-soraka/igt@runner@aborted.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-soraka/igt@runner@aborted.html - fi-kbl-7500u: [FAIL][66] ([i915#3363]) -> [FAIL][67] ([i915#1436] / [i915#3363]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-kbl-7500u/igt@runner@aborted.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-7500u/igt@runner@aborted.html - fi-cml-u2: [FAIL][68] ([i915#3363]) -> [FAIL][69] ([i915#2082] / [i915#2426] / [i915#3363]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-cml-u2/igt@runner@aborted.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-cml-u2/igt@runner@aborted.html - fi-cfl-guc: [FAIL][70] ([i915#2426] / [i915#3363]) -> [FAIL][71] ([i915#3363]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-cfl-guc/igt@runner@aborted.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-cfl-guc/igt@runner@aborted.html - fi-kbl-7567u: [FAIL][72] ([i915#1436] / [i915#3363]) -> [FAIL][73] ([i915#1436] / [i915#2426] / [i915#3363]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-kbl-7567u/igt@runner@aborted.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-kbl-7567u/igt@runner@aborted.html - fi-skl-6700k2: [FAIL][74] ([i915#1436] / [i915#3363]) -> [FAIL][75] ([i915#1436] / [i915#2426] / [i915#3363]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/fi-skl-6700k2/igt@runner@aborted.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/fi-skl-6700k2/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966 [i915#3177]: https://gitlab.freedesktop.org/drm/intel/issues/3177 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#3457]: https://gitlab.freedesktop.org/drm/intel/issues/3457 [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462 [i915#3472]: https://gitlab.freedesktop.org/drm/intel/issues/3472 [i915#3475]: https://gitlab.freedesktop.org/drm/intel/issues/3475 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (43 -> 38) ------------------------------ Missing (5): fi-rkl-11500t fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10090 -> Patchwork_20134 CI-20190529: 20190529 CI_DRM_10090: e28f8dd2a3f0981ebaad3056674553da7718da81 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6084: 5c5734d8ee1afac871b69c4554ff14e9b56100e4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_20134: df2a974bb7e002385d10695cadb9e2789ba90ca7 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == df2a974bb7e0 drm/i915: only disable default vga device == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/index.html [-- Attachment #1.2: Type: text/html, Size: 20815 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: only disable default vga device 2021-05-16 17:14 ` [Intel-gfx] " Emil Velikov ` (2 preceding siblings ...) (?) @ 2021-05-17 16:11 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2021-05-17 16:11 UTC (permalink / raw) To: Emil Velikov; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30264 bytes --] == Series Details == Series: drm/i915: only disable default vga device URL : https://patchwork.freedesktop.org/series/90213/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10090_full -> Patchwork_20134_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20134_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20134_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20134_full: ### IGT changes ### #### Possible regressions #### * igt@gem_mmap_gtt@fault-concurrent-y: - shard-snb: NOTRUN -> [INCOMPLETE][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb7/igt@gem_mmap_gtt@fault-concurrent-y.html #### Warnings #### * igt@gem_mmap_gtt@fault-concurrent-y: - shard-glk: [INCOMPLETE][2] ([i915#3468]) -> [INCOMPLETE][3] +1 similar issue [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk3/igt@gem_mmap_gtt@fault-concurrent-y.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk8/igt@gem_mmap_gtt@fault-concurrent-y.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@kms_plane@plane-position-covered@pipe-b-planes}: - shard-apl: [PASS][4] -> [FAIL][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-apl8/igt@kms_plane@plane-position-covered@pipe-b-planes.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl8/igt@kms_plane@plane-position-covered@pipe-b-planes.html ### Piglit changes ### #### Possible regressions #### * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 3 (NEW): - pig-glk-j5005: NOTRUN -> [INCOMPLETE][6] +3 similar issues [6]: None New tests --------- New tests have been introduced between CI_DRM_10090_full and Patchwork_20134_full: ### New Piglit tests (4) ### * spec@arb_shader_image_load_store@max-size: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 3: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 4: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 7: - Statuses : 1 incomplete(s) - Exec time: [0.0] s Known issues ------------ Here are the changes found in Patchwork_20134_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@api_intel_bb@blit-noreloc-purge-cache-random: - shard-apl: NOTRUN -> [DMESG-WARN][7] ([i915#3457]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@api_intel_bb@blit-noreloc-purge-cache-random.html - shard-tglb: NOTRUN -> [DMESG-WARN][8] ([i915#3457]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@api_intel_bb@blit-noreloc-purge-cache-random.html * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][9] ([i915#3002]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@gem_create@create-massive.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1099]) +6 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb7/igt@gem_ctx_persistence@legacy-engines-mixed.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2410] / [i915#3457]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb3/igt@gem_ctx_persistence@many-contexts.html * igt@gem_ctx_persistence@saturated-hostile@vecs0: - shard-apl: NOTRUN -> [FAIL][13] ([i915#3457]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl8/igt@gem_ctx_persistence@saturated-hostile@vecs0.html * igt@gem_ctx_persistence@smoketest: - shard-apl: NOTRUN -> [FAIL][14] ([i915#2896] / [i915#3457]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@gem_ctx_persistence@smoketest.html * igt@gem_exec_fair@basic-deadline: - shard-apl: NOTRUN -> [FAIL][15] ([i915#2846] / [i915#3457]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl3/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [PASS][16] -> [FAIL][17] ([i915#2842] / [i915#3457]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-kbl: [PASS][18] -> [FAIL][19] ([i915#2842] / [i915#3457]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-kbl1/igt@gem_exec_fair@basic-none-solo@rcs0.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl2/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842] / [i915#3457]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-tglb: [PASS][21] -> [FAIL][22] ([i915#2842] / [i915#3457]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb2/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gem_exec_fair@basic-sync@rcs0: - shard-apl: [PASS][23] -> [INCOMPLETE][24] ([i915#3457]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-apl8/igt@gem_exec_fair@basic-sync@rcs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl8/igt@gem_exec_fair@basic-sync@rcs0.html * igt@gem_exec_fence@keep-in-fence@vcs0: - shard-glk: [PASS][25] -> [INCOMPLETE][26] ([i915#3457]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk6/igt@gem_exec_fence@keep-in-fence@vcs0.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk2/igt@gem_exec_fence@keep-in-fence@vcs0.html * igt@gem_exec_fence@submit-chain: - shard-glk: NOTRUN -> [FAIL][27] ([i915#3457]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk9/igt@gem_exec_fence@submit-chain.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +325 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb7/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-apl: NOTRUN -> [FAIL][29] ([i915#2389] / [i915#3457]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@gem_exec_reloc@basic-wide-active@bcs0.html * igt@gem_exec_schedule@preempt-hang@vecs0: - shard-glk: [PASS][30] -> [FAIL][31] ([i915#3457]) +29 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk8/igt@gem_exec_schedule@preempt-hang@vecs0.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk6/igt@gem_exec_schedule@preempt-hang@vecs0.html * igt@gem_mmap_gtt@big-copy-xy: - shard-skl: [PASS][32] -> [FAIL][33] ([i915#307]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-skl7/igt@gem_mmap_gtt@big-copy-xy.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-skl7/igt@gem_mmap_gtt@big-copy-xy.html * igt@gem_mmap_gtt@cpuset-basic-small-copy: - shard-glk: [PASS][34] -> [INCOMPLETE][35] ([i915#3468]) +1 similar issue [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk5/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk6/igt@gem_mmap_gtt@cpuset-basic-small-copy.html - shard-tglb: [PASS][36] -> [INCOMPLETE][37] ([i915#3468]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-tglb8/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb6/igt@gem_mmap_gtt@cpuset-basic-small-copy.html - shard-kbl: [PASS][38] -> [INCOMPLETE][39] ([i915#3468]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-kbl7/igt@gem_mmap_gtt@cpuset-basic-small-copy.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl3/igt@gem_mmap_gtt@cpuset-basic-small-copy.html * igt@gem_mmap_gtt@cpuset-basic-small-copy-odd: - shard-snb: NOTRUN -> [INCOMPLETE][40] ([i915#3468]) +1 similar issue [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb5/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html * igt@gem_mmap_gtt@fault-concurrent-x: - shard-iclb: NOTRUN -> [INCOMPLETE][41] ([i915#3468]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@gem_mmap_gtt@fault-concurrent-x.html - shard-snb: NOTRUN -> [INCOMPLETE][42] ([i915#3468] / [i915#3485]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb2/igt@gem_mmap_gtt@fault-concurrent-x.html * igt@gem_render_copy@linear-to-vebox-yf-tiled: - shard-iclb: NOTRUN -> [SKIP][43] ([i915#768]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@gem_render_copy@linear-to-vebox-yf-tiled.html * igt@gem_render_copy@yf-tiled-ccs-to-x-tiled: - shard-apl: NOTRUN -> [INCOMPLETE][44] ([i915#3468]) +2 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl7/igt@gem_render_copy@yf-tiled-ccs-to-x-tiled.html * igt@gem_render_copy@yf-tiled-ccs-to-y-tiled: - shard-kbl: NOTRUN -> [INCOMPLETE][45] ([i915#3468]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@gem_render_copy@yf-tiled-ccs-to-y-tiled.html * igt@gem_spin_batch@spin-each: - shard-apl: NOTRUN -> [FAIL][46] ([i915#2898] / [i915#3457]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl7/igt@gem_spin_batch@spin-each.html * igt@gem_userptr_blits@input-checking: - shard-snb: NOTRUN -> [DMESG-WARN][47] ([i915#3002]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb6/igt@gem_userptr_blits@input-checking.html * igt@gem_userptr_blits@vma-merge: - shard-apl: NOTRUN -> [FAIL][48] ([i915#3318] / [i915#3457]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl3/igt@gem_userptr_blits@vma-merge.html * igt@gem_wait@await@vecs0: - shard-apl: [PASS][49] -> [FAIL][50] ([i915#3457]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-apl1/igt@gem_wait@await@vecs0.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl7/igt@gem_wait@await@vecs0.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][51] -> [DMESG-WARN][52] ([i915#180] / [i915#3457]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html * igt@gen7_exec_parse@basic-allocation: - shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109289]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@gen7_exec_parse@basic-allocation.html * igt@gen9_exec_parse@bb-large: - shard-apl: NOTRUN -> [FAIL][54] ([i915#3296]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@gen9_exec_parse@bb-large.html * igt@gen9_exec_parse@shadow-peek: - shard-iclb: NOTRUN -> [SKIP][55] ([i915#2856]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@gen9_exec_parse@shadow-peek.html * igt@i915_hangman@engine-error@vcs1: - shard-iclb: NOTRUN -> [DMESG-WARN][56] ([i915#3457]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb2/igt@i915_hangman@engine-error@vcs1.html * igt@i915_hangman@error-state-capture@bcs0: - shard-kbl: NOTRUN -> [DMESG-WARN][57] ([i915#3457]) +4 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@i915_hangman@error-state-capture@bcs0.html * igt@i915_module_load@reload: - shard-snb: NOTRUN -> [DMESG-WARN][58] ([i915#3457]) +1 similar issue [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb7/igt@i915_module_load@reload.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-tglb: NOTRUN -> [SKIP][59] ([i915#1904]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: NOTRUN -> [WARN][60] ([i915#1804] / [i915#2684]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html * igt@i915_pm_rpm@cursor: - shard-glk: [PASS][61] -> [DMESG-WARN][62] ([i915#3457]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk7/igt@i915_pm_rpm@cursor.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk4/igt@i915_pm_rpm@cursor.html * igt@i915_pm_rpm@modeset-pc8-residency-stress: - shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109293] / [fdo#109506]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@i915_pm_rpm@modeset-pc8-residency-stress.html * igt@i915_pm_rps@reset: - shard-apl: NOTRUN -> [DMESG-FAIL][64] ([i915#3457]) +3 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@i915_pm_rps@reset.html * igt@i915_selftest@live@hangcheck: - shard-snb: NOTRUN -> [INCOMPLETE][65] ([i915#2782]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@forcewake: - shard-kbl: [PASS][66] -> [DMESG-WARN][67] ([i915#180]) +3 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-kbl2/igt@i915_suspend@forcewake.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl3/igt@i915_suspend@forcewake.html * igt@kms_big_fb@linear-16bpp-rotate-0: - shard-iclb: [PASS][68] -> [DMESG-FAIL][69] ([i915#1226]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-iclb7/igt@kms_big_fb@linear-16bpp-rotate-0.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb2/igt@kms_big_fb@linear-16bpp-rotate-0.html * igt@kms_big_joiner@invalid-modeset: - shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2705]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@kms_big_joiner@invalid-modeset.html * igt@kms_chamelium@dp-audio-edid: - shard-tglb: NOTRUN -> [SKIP][71] ([fdo#109284] / [fdo#111827]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@kms_chamelium@dp-audio-edid.html * igt@kms_chamelium@dp-crc-multiple: - shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [fdo#111827]) +17 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@kms_chamelium@dp-crc-multiple.html * igt@kms_chamelium@hdmi-hpd-for-each-pipe: - shard-glk: NOTRUN -> [SKIP][73] ([fdo#109271] / [fdo#111827]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk9/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html * igt@kms_color@pipe-b-degamma: - shard-glk: [PASS][74] -> [FAIL][75] ([i915#71]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk8/igt@kms_color@pipe-b-degamma.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk3/igt@kms_color@pipe-b-degamma.html * igt@kms_color@pipe-d-degamma: - shard-tglb: NOTRUN -> [FAIL][76] ([i915#1149]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@kms_color@pipe-d-degamma.html * igt@kms_color_chamelium@pipe-a-ctm-0-25: - shard-snb: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +25 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-0-25.html * igt@kms_color_chamelium@pipe-c-ctm-0-5: - shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109284] / [fdo#111827]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_color_chamelium@pipe-c-ctm-0-5.html * igt@kms_color_chamelium@pipe-c-ctm-limited-range: - shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +4 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@kms_color_chamelium@pipe-c-ctm-limited-range.html * igt@kms_color_chamelium@pipe-d-gamma: - shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278] / [fdo#109284] / [fdo#111827]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_color_chamelium@pipe-d-gamma.html * igt@kms_content_protection@dp-mst-type-1: - shard-iclb: NOTRUN -> [SKIP][81] ([i915#3116]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_content_protection@dp-mst-type-1.html * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding: - shard-apl: [PASS][82] -> [FAIL][83] ([i915#3444] / [i915#3457]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding: - shard-apl: NOTRUN -> [FAIL][84] ([i915#3444] / [i915#3457]) +5 similar issues [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html * igt@kms_cursor_crc@pipe-a-cursor-256x256-random: - shard-snb: NOTRUN -> [FAIL][85] ([i915#3457]) +9 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-256x256-random.html * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen: - shard-skl: [PASS][86] -> [FAIL][87] ([i915#3444] / [i915#3457]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html * igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque: - shard-iclb: NOTRUN -> [FAIL][88] ([i915#3457]) +1 similar issue [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: NOTRUN -> [DMESG-FAIL][89] ([i915#180] / [i915#3457]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: - shard-tglb: [PASS][90] -> [FAIL][91] ([i915#2124] / [i915#3457]) +1 similar issue [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html * igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen: - shard-kbl: [PASS][92] -> [FAIL][93] ([i915#3444] / [i915#3457]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html * igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen: - shard-tglb: NOTRUN -> [SKIP][94] ([i915#3359] / [i915#3457]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen.html * igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen: - shard-tglb: NOTRUN -> [FAIL][95] ([i915#2124] / [i915#3457]) +1 similar issue [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen.html * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding: - shard-kbl: NOTRUN -> [FAIL][96] ([i915#3444] / [i915#3457]) +6 similar issues [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html * igt@kms_cursor_crc@pipe-c-cursor-32x10-onscreen: - shard-snb: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#3457]) +45 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb7/igt@kms_cursor_crc@pipe-c-cursor-32x10-onscreen.html * igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen: - shard-glk: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3457]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk9/igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen.html * igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen: - shard-glk: [PASS][99] -> [FAIL][100] ([i915#3444] / [i915#3457]) +3 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk8/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk6/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html * igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement: - shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109278] / [i915#3457]) +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html * igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding: - shard-tglb: NOTRUN -> [SKIP][102] ([fdo#109279] / [i915#3359] / [i915#3457]) +1 similar issue [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding.html * igt@kms_cursor_crc@pipe-d-cursor-64x64-sliding: - shard-apl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#3457]) +33 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@kms_cursor_crc@pipe-d-cursor-64x64-sliding.html * igt@kms_cursor_crc@pipe-d-cursor-suspend: - shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#3457]) +8 similar issues [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@kms_cursor_crc@pipe-d-cursor-suspend.html * igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge: - shard-glk: [PASS][105] -> [FAIL][106] ([i915#70]) +3 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk2/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk3/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic: - shard-skl: [PASS][107] -> [FAIL][108] ([i915#2346] / [i915#3457]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@pipe-d-single-move: - shard-iclb: NOTRUN -> [SKIP][109] ([fdo#109278]) +1 similar issue [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_cursor_legacy@pipe-d-single-move.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [PASS][110] -> [INCOMPLETE][111] ([i915#155] / [i915#180] / [i915#636]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-nonexisting-fb: - shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109274]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_flip@2x-nonexisting-fb.html * igt@kms_flip@flip-vs-suspend-interruptible@c-edp1: - shard-skl: [PASS][113] -> [INCOMPLETE][114] ([i915#146] / [i915#198]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-skl4/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - shard-apl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#2672]) +1 similar issue [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu: - shard-iclb: NOTRUN -> [SKIP][116] ([fdo#109280]) +2 similar issues [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt: - shard-tglb: NOTRUN -> [SKIP][117] ([fdo#111825]) +5 similar issues [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render: - shard-kbl: NOTRUN -> [SKIP][118] ([fdo#109271]) +52 similar issues [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-wc: - shard-glk: NOTRUN -> [SKIP][119] ([fdo#109271]) +3 similar issues [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk9/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c: - shard-apl: [PASS][120] -> [FAIL][121] ([i915#53]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-apl1/igt@kms_pipe_crc_basic@hang-read-crc-pipe-c.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl7/igt@kms_pipe_crc_basic@hang-read-crc-pipe-c.html * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-kbl: NOTRUN -> [FAIL][122] ([fdo#108145] / [i915#265]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-kbl1/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][123] -> [FAIL][124] ([fdo#108145] / [i915#265]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-apl: NOTRUN -> [FAIL][125] ([fdo#108145] / [i915#265]) +2 similar issues [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_cursor@pipe-b-overlay-size-128: - shard-glk: [PASS][126] -> [FAIL][127] ([i915#2657]) +1 similar issue [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk3/igt@kms_plane_cursor@pipe-b-overlay-size-128.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-glk8/igt@kms_plane_cursor@pipe-b-overlay-size-128.html - shard-snb: NOTRUN -> [FAIL][128] ([i915#2657]) +2 similar issues [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb7/igt@kms_plane_cursor@pipe-b-overlay-size-128.html * igt@kms_plane_cursor@pipe-b-primary-size-64: - shard-snb: NOTRUN -> [FAIL][129] ([i915#2657] / [i915#3457]) +1 similar issue [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard-snb2/igt@kms_plane_cursor@pipe-b-primary-size-64.html - shard-glk: [PASS][130] -> [FAIL][131] ([i915#2657] / [i915#3457]) [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10090/shard-glk1/igt@kms_plane_cursor@pipe-b-primary-size-64.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/shard == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20134/index.html [-- Attachment #1.2: Type: text/html, Size: 33691 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-05-16 17:14 ` [Intel-gfx] " Emil Velikov @ 2021-05-17 17:24 ` Ville Syrjälä -1 siblings, 0 replies; 21+ messages in thread From: Ville Syrjälä @ 2021-05-17 17:24 UTC (permalink / raw) To: Emil Velikov; +Cc: intel-gfx, dri-devel, Rodrigo Vivi, kernel On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > From: Vivek Das Mohapatra <vivek@collabora.com> > > This patch is to do with seamless handover, eg when the sequence is > bootloader → plymouth → desktop. > > It switches the vga arbiter from the "other" GPU to the default one > (intel in this case), so the driver can issue some io(). I don't understand what this commit message is trying to say. > > Signed-off-by: Vivek Das Mohapatra <vivek@collabora.com> > Signed-off-by: Emil Velikov <emil.velikov@collabora.com> > --- > Greetings all, > > This patch has been downstream for a while now yet it seems perfectly > reasonable thing to have in the Linux kernel. > > https://github.com/ValveSoftware/steamos_kernel/commit/5431b5b1999c3d3b5efee817fb3373fbbd473063 > > > drivers/gpu/drm/i915/display/intel_vga.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c > index be333699c515..4f07b5ad5fa0 100644 > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -30,12 +30,14 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > u8 sr1; > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > - vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > - outb(SR01, VGA_SR_INDEX); > - sr1 = inb(VGA_SR_DATA); > - outb(sr1 | 1 << 5, VGA_SR_DATA); > - vga_put(pdev, VGA_RSRC_LEGACY_IO); > - udelay(300); > + if (pdev == vga_default_device()) { > + vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > + outb(SR01, VGA_SR_INDEX); > + sr1 = inb(VGA_SR_DATA); > + outb(sr1 | 1 << 5, VGA_SR_DATA); > + vga_put(pdev, VGA_RSRC_LEGACY_IO); > + udelay(300); > + } > > intel_de_write(dev_priv, vga_reg, VGA_DISP_DISABLE); > intel_de_posting_read(dev_priv, vga_reg); > -- > 2.27.0 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-05-17 17:24 ` Ville Syrjälä 0 siblings, 0 replies; 21+ messages in thread From: Ville Syrjälä @ 2021-05-17 17:24 UTC (permalink / raw) To: Emil Velikov; +Cc: intel-gfx, dri-devel, kernel On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > From: Vivek Das Mohapatra <vivek@collabora.com> > > This patch is to do with seamless handover, eg when the sequence is > bootloader → plymouth → desktop. > > It switches the vga arbiter from the "other" GPU to the default one > (intel in this case), so the driver can issue some io(). I don't understand what this commit message is trying to say. > > Signed-off-by: Vivek Das Mohapatra <vivek@collabora.com> > Signed-off-by: Emil Velikov <emil.velikov@collabora.com> > --- > Greetings all, > > This patch has been downstream for a while now yet it seems perfectly > reasonable thing to have in the Linux kernel. > > https://github.com/ValveSoftware/steamos_kernel/commit/5431b5b1999c3d3b5efee817fb3373fbbd473063 > > > drivers/gpu/drm/i915/display/intel_vga.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c > index be333699c515..4f07b5ad5fa0 100644 > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -30,12 +30,14 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > u8 sr1; > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > - vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > - outb(SR01, VGA_SR_INDEX); > - sr1 = inb(VGA_SR_DATA); > - outb(sr1 | 1 << 5, VGA_SR_DATA); > - vga_put(pdev, VGA_RSRC_LEGACY_IO); > - udelay(300); > + if (pdev == vga_default_device()) { > + vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > + outb(SR01, VGA_SR_INDEX); > + sr1 = inb(VGA_SR_DATA); > + outb(sr1 | 1 << 5, VGA_SR_DATA); > + vga_put(pdev, VGA_RSRC_LEGACY_IO); > + udelay(300); > + } > > intel_de_write(dev_priv, vga_reg, VGA_DISP_DISABLE); > intel_de_posting_read(dev_priv, vga_reg); > -- > 2.27.0 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-05-17 17:24 ` [Intel-gfx] " Ville Syrjälä @ 2021-05-18 11:09 ` Emil Velikov -1 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-18 11:09 UTC (permalink / raw) To: Ville Syrjälä Cc: Intel Graphics Development, ML dri-devel, Rodrigo Vivi, kernel Hi Ville, On Mon, 17 May 2021 at 18:24, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > This patch is to do with seamless handover, eg when the sequence is > > bootloader → plymouth → desktop. > > > > It switches the vga arbiter from the "other" GPU to the default one > > (intel in this case), so the driver can issue some io(). > > I don't understand what this commit message is trying to say. > Bunch of context is lost due to the patch age, so I'm not 100% sure of the actual hardware setup where this occurs. Does the following make sense? Currently on dual GPU systems, we do not get seamless handover as the output flickers during the transition bootloader -> plymouth -> desktop. This happens as a result of switching (via the VGA arbiter) from the "other" GPU back to the default i915 one and issuing io() commands. -Emil ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-05-18 11:09 ` Emil Velikov 0 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-18 11:09 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Intel Graphics Development, ML dri-devel, kernel Hi Ville, On Mon, 17 May 2021 at 18:24, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > This patch is to do with seamless handover, eg when the sequence is > > bootloader → plymouth → desktop. > > > > It switches the vga arbiter from the "other" GPU to the default one > > (intel in this case), so the driver can issue some io(). > > I don't understand what this commit message is trying to say. > Bunch of context is lost due to the patch age, so I'm not 100% sure of the actual hardware setup where this occurs. Does the following make sense? Currently on dual GPU systems, we do not get seamless handover as the output flickers during the transition bootloader -> plymouth -> desktop. This happens as a result of switching (via the VGA arbiter) from the "other" GPU back to the default i915 one and issuing io() commands. -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-05-18 11:09 ` [Intel-gfx] " Emil Velikov @ 2021-05-18 11:17 ` Ville Syrjälä -1 siblings, 0 replies; 21+ messages in thread From: Ville Syrjälä @ 2021-05-18 11:17 UTC (permalink / raw) To: Emil Velikov Cc: Intel Graphics Development, ML dri-devel, Rodrigo Vivi, kernel On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > Hi Ville, > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > <ville.syrjala@linux.intel.com> wrote: > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > bootloader → plymouth → desktop. > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > (intel in this case), so the driver can issue some io(). > > > > I don't understand what this commit message is trying to say. > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > the actual hardware setup where this occurs. > Does the following make sense? > > Currently on dual GPU systems, we do not get seamless handover as the > output flickers during the transition bootloader -> plymouth -> > desktop. > This happens as a result of switching (via the VGA arbiter) from the > "other" GPU back to the default i915 one and issuing io() commands. Hmm. Does this work? --- a/drivers/gpu/drm/i915/display/intel_vga.c +++ b/drivers/gpu/drm/i915/display/intel_vga.c @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); u8 sr1; + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) + return; + /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); outb(SR01, VGA_SR_INDEX); -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-05-18 11:17 ` Ville Syrjälä 0 siblings, 0 replies; 21+ messages in thread From: Ville Syrjälä @ 2021-05-18 11:17 UTC (permalink / raw) To: Emil Velikov; +Cc: Intel Graphics Development, ML dri-devel, kernel On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > Hi Ville, > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > <ville.syrjala@linux.intel.com> wrote: > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > bootloader → plymouth → desktop. > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > (intel in this case), so the driver can issue some io(). > > > > I don't understand what this commit message is trying to say. > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > the actual hardware setup where this occurs. > Does the following make sense? > > Currently on dual GPU systems, we do not get seamless handover as the > output flickers during the transition bootloader -> plymouth -> > desktop. > This happens as a result of switching (via the VGA arbiter) from the > "other" GPU back to the default i915 one and issuing io() commands. Hmm. Does this work? --- a/drivers/gpu/drm/i915/display/intel_vga.c +++ b/drivers/gpu/drm/i915/display/intel_vga.c @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); u8 sr1; + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) + return; + /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); outb(SR01, VGA_SR_INDEX); -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-05-18 11:17 ` [Intel-gfx] " Ville Syrjälä @ 2021-05-18 12:39 ` Emil Velikov -1 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-18 12:39 UTC (permalink / raw) To: Ville Syrjälä Cc: Intel Graphics Development, kernel, ML dri-devel, Rodrigo Vivi On Tue, 18 May 2021 at 12:17, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > Hi Ville, > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > bootloader → plymouth → desktop. > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > (intel in this case), so the driver can issue some io(). > > > > > > I don't understand what this commit message is trying to say. > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > the actual hardware setup where this occurs. > > Does the following make sense? > > > > Currently on dual GPU systems, we do not get seamless handover as the > > output flickers during the transition bootloader -> plymouth -> > > desktop. > > This happens as a result of switching (via the VGA arbiter) from the > > "other" GPU back to the default i915 one and issuing io() commands. > > Hmm. Does this work? > Thanks I'll it give it a try. Might need a few days to find the right hardware/software combination. -Emil ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-05-18 12:39 ` Emil Velikov 0 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-18 12:39 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Intel Graphics Development, kernel, ML dri-devel On Tue, 18 May 2021 at 12:17, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > Hi Ville, > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > bootloader → plymouth → desktop. > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > (intel in this case), so the driver can issue some io(). > > > > > > I don't understand what this commit message is trying to say. > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > the actual hardware setup where this occurs. > > Does the following make sense? > > > > Currently on dual GPU systems, we do not get seamless handover as the > > output flickers during the transition bootloader -> plymouth -> > > desktop. > > This happens as a result of switching (via the VGA arbiter) from the > > "other" GPU back to the default i915 one and issuing io() commands. > > Hmm. Does this work? > Thanks I'll it give it a try. Might need a few days to find the right hardware/software combination. -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-05-18 11:17 ` [Intel-gfx] " Ville Syrjälä @ 2021-05-26 16:21 ` Emil Velikov -1 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-26 16:21 UTC (permalink / raw) To: Ville Syrjälä Cc: Intel Graphics Development, kernel, ML dri-devel, Rodrigo Vivi Hi Ville, On Tue, 18 May 2021 at 12:17, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > Hi Ville, > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > bootloader → plymouth → desktop. > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > (intel in this case), so the driver can issue some io(). > > > > > > I don't understand what this commit message is trying to say. > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > the actual hardware setup where this occurs. > > Does the following make sense? > > > > Currently on dual GPU systems, we do not get seamless handover as the > > output flickers during the transition bootloader -> plymouth -> > > desktop. > > This happens as a result of switching (via the VGA arbiter) from the > > "other" GPU back to the default i915 one and issuing io() commands. > > Hmm. Does this work? > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > u8 sr1; > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > + return; > + > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > outb(SR01, VGA_SR_INDEX); > Was able to replicate the issue somewhat and the above does help quite a lot. Feel free to add my: Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Tested-by: Emil Velikov <emil.velikov@collabora.com> Also feel free to reuse as much/little of the following setup details. To reproduce the issue: Get a dual GPU system - Intel+Nvidia in my case. Set the other (Nvidia) as default in UEFI and connect monitors to it. Ensure the bootloader (and if using splash manager like plymouth) are set to display the UEFI BGRT. Personally I tested systemd-boot, although GRUB should also work. I couldn't get plymouth to work/behave here :shrug: Note: Having the Nvidia drivers in the initramfs can lead to extra flicker so leave them out. Include the i915 drivers in initramfs. Without the patch, the existing bootslash is wiped clean almost instantaneously as the i915 driver calls intel_vga_disable(). With your patch the call is a no-op, and the bootsplash stays around until the login manager (and X) is spawned. HTH Emil ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-05-26 16:21 ` Emil Velikov 0 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-05-26 16:21 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Intel Graphics Development, kernel, ML dri-devel Hi Ville, On Tue, 18 May 2021 at 12:17, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > Hi Ville, > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > bootloader → plymouth → desktop. > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > (intel in this case), so the driver can issue some io(). > > > > > > I don't understand what this commit message is trying to say. > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > the actual hardware setup where this occurs. > > Does the following make sense? > > > > Currently on dual GPU systems, we do not get seamless handover as the > > output flickers during the transition bootloader -> plymouth -> > > desktop. > > This happens as a result of switching (via the VGA arbiter) from the > > "other" GPU back to the default i915 one and issuing io() commands. > > Hmm. Does this work? > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > u8 sr1; > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > + return; > + > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > outb(SR01, VGA_SR_INDEX); > Was able to replicate the issue somewhat and the above does help quite a lot. Feel free to add my: Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Tested-by: Emil Velikov <emil.velikov@collabora.com> Also feel free to reuse as much/little of the following setup details. To reproduce the issue: Get a dual GPU system - Intel+Nvidia in my case. Set the other (Nvidia) as default in UEFI and connect monitors to it. Ensure the bootloader (and if using splash manager like plymouth) are set to display the UEFI BGRT. Personally I tested systemd-boot, although GRUB should also work. I couldn't get plymouth to work/behave here :shrug: Note: Having the Nvidia drivers in the initramfs can lead to extra flicker so leave them out. Include the i915 drivers in initramfs. Without the patch, the existing bootslash is wiped clean almost instantaneously as the i915 driver calls intel_vga_disable(). With your patch the call is a no-op, and the bootsplash stays around until the login manager (and X) is spawned. HTH Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-05-26 16:21 ` [Intel-gfx] " Emil Velikov @ 2021-06-04 13:47 ` Emil Velikov -1 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-06-04 13:47 UTC (permalink / raw) To: Ville Syrjälä Cc: Intel Graphics Development, kernel, ML dri-devel, Rodrigo Vivi On Wed, 26 May 2021 at 17:21, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > Hi Ville, > > On Tue, 18 May 2021 at 12:17, Ville Syrjälä > <ville.syrjala@linux.intel.com> wrote: > > > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > > Hi Ville, > > > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > > bootloader → plymouth → desktop. > > > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > > (intel in this case), so the driver can issue some io(). > > > > > > > > I don't understand what this commit message is trying to say. > > > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > > the actual hardware setup where this occurs. > > > Does the following make sense? > > > > > > Currently on dual GPU systems, we do not get seamless handover as the > > > output flickers during the transition bootloader -> plymouth -> > > > desktop. > > > This happens as a result of switching (via the VGA arbiter) from the > > > "other" GPU back to the default i915 one and issuing io() commands. > > > > Hmm. Does this work? > > > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > > u8 sr1; > > > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > > + return; > > + > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > > outb(SR01, VGA_SR_INDEX); > > > Was able to replicate the issue somewhat and the above does help quite a lot. > Feel free to add my: > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > Tested-by: Emil Velikov <emil.velikov@collabora.com> > Humble poke. Cannot see this patch in the drm-misc or drm-intel trees. Is there anything I do to help move it forward? Thanks -Emil ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-06-04 13:47 ` Emil Velikov 0 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-06-04 13:47 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Intel Graphics Development, kernel, ML dri-devel On Wed, 26 May 2021 at 17:21, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > Hi Ville, > > On Tue, 18 May 2021 at 12:17, Ville Syrjälä > <ville.syrjala@linux.intel.com> wrote: > > > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > > Hi Ville, > > > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > > bootloader → plymouth → desktop. > > > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > > (intel in this case), so the driver can issue some io(). > > > > > > > > I don't understand what this commit message is trying to say. > > > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > > the actual hardware setup where this occurs. > > > Does the following make sense? > > > > > > Currently on dual GPU systems, we do not get seamless handover as the > > > output flickers during the transition bootloader -> plymouth -> > > > desktop. > > > This happens as a result of switching (via the VGA arbiter) from the > > > "other" GPU back to the default i915 one and issuing io() commands. > > > > Hmm. Does this work? > > > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > > u8 sr1; > > > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > > + return; > > + > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > > outb(SR01, VGA_SR_INDEX); > > > Was able to replicate the issue somewhat and the above does help quite a lot. > Feel free to add my: > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > Tested-by: Emil Velikov <emil.velikov@collabora.com> > Humble poke. Cannot see this patch in the drm-misc or drm-intel trees. Is there anything I do to help move it forward? Thanks -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-06-04 13:47 ` [Intel-gfx] " Emil Velikov @ 2021-06-04 14:08 ` Ville Syrjälä -1 siblings, 0 replies; 21+ messages in thread From: Ville Syrjälä @ 2021-06-04 14:08 UTC (permalink / raw) To: Emil Velikov Cc: Intel Graphics Development, kernel, ML dri-devel, Rodrigo Vivi On Fri, Jun 04, 2021 at 02:47:16PM +0100, Emil Velikov wrote: > On Wed, 26 May 2021 at 17:21, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > Hi Ville, > > > > On Tue, 18 May 2021 at 12:17, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > > > > > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > > > Hi Ville, > > > > > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > > > bootloader → plymouth → desktop. > > > > > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > > > (intel in this case), so the driver can issue some io(). > > > > > > > > > > I don't understand what this commit message is trying to say. > > > > > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > > > the actual hardware setup where this occurs. > > > > Does the following make sense? > > > > > > > > Currently on dual GPU systems, we do not get seamless handover as the > > > > output flickers during the transition bootloader -> plymouth -> > > > > desktop. > > > > This happens as a result of switching (via the VGA arbiter) from the > > > > "other" GPU back to the default i915 one and issuing io() commands. > > > > > > Hmm. Does this work? > > > > > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > > > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > > > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > > > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > > > u8 sr1; > > > > > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > > > + return; > > > + > > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > > > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > > > outb(SR01, VGA_SR_INDEX); > > > > > Was able to replicate the issue somewhat and the above does help quite a lot. > > Feel free to add my: > > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > > Tested-by: Emil Velikov <emil.velikov@collabora.com> > > > Humble poke. > > Cannot see this patch in the drm-misc or drm-intel trees. Is there > anything I do to help move it forward? Can you just respin the patch with this? -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-06-04 14:08 ` Ville Syrjälä 0 siblings, 0 replies; 21+ messages in thread From: Ville Syrjälä @ 2021-06-04 14:08 UTC (permalink / raw) To: Emil Velikov; +Cc: Intel Graphics Development, kernel, ML dri-devel On Fri, Jun 04, 2021 at 02:47:16PM +0100, Emil Velikov wrote: > On Wed, 26 May 2021 at 17:21, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > Hi Ville, > > > > On Tue, 18 May 2021 at 12:17, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > > > > > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > > > Hi Ville, > > > > > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > > > bootloader → plymouth → desktop. > > > > > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > > > (intel in this case), so the driver can issue some io(). > > > > > > > > > > I don't understand what this commit message is trying to say. > > > > > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > > > the actual hardware setup where this occurs. > > > > Does the following make sense? > > > > > > > > Currently on dual GPU systems, we do not get seamless handover as the > > > > output flickers during the transition bootloader -> plymouth -> > > > > desktop. > > > > This happens as a result of switching (via the VGA arbiter) from the > > > > "other" GPU back to the default i915 one and issuing io() commands. > > > > > > Hmm. Does this work? > > > > > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > > > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > > > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > > > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > > > u8 sr1; > > > > > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > > > + return; > > > + > > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > > > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > > > outb(SR01, VGA_SR_INDEX); > > > > > Was able to replicate the issue somewhat and the above does help quite a lot. > > Feel free to add my: > > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > > Tested-by: Emil Velikov <emil.velikov@collabora.com> > > > Humble poke. > > Cannot see this patch in the drm-misc or drm-intel trees. Is there > anything I do to help move it forward? Can you just respin the patch with this? -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: only disable default vga device 2021-06-04 14:08 ` [Intel-gfx] " Ville Syrjälä @ 2021-06-04 15:53 ` Emil Velikov -1 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-06-04 15:53 UTC (permalink / raw) To: Ville Syrjälä Cc: Intel Graphics Development, kernel, ML dri-devel, Rodrigo Vivi On Fri, 4 Jun 2021 at 15:08, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Fri, Jun 04, 2021 at 02:47:16PM +0100, Emil Velikov wrote: > > On Wed, 26 May 2021 at 17:21, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > > > Hi Ville, > > > > > > On Tue, 18 May 2021 at 12:17, Ville Syrjälä > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > > > > Hi Ville, > > > > > > > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > > > > bootloader → plymouth → desktop. > > > > > > > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > > > > (intel in this case), so the driver can issue some io(). > > > > > > > > > > > > I don't understand what this commit message is trying to say. > > > > > > > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > > > > the actual hardware setup where this occurs. > > > > > Does the following make sense? > > > > > > > > > > Currently on dual GPU systems, we do not get seamless handover as the > > > > > output flickers during the transition bootloader -> plymouth -> > > > > > desktop. > > > > > This happens as a result of switching (via the VGA arbiter) from the > > > > > "other" GPU back to the default i915 one and issuing io() commands. > > > > > > > > Hmm. Does this work? > > > > > > > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > > > > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > > > > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > > > > u8 sr1; > > > > > > > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > > > > + return; > > > > + > > > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > > > > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > > > > outb(SR01, VGA_SR_INDEX); > > > > > > > Was able to replicate the issue somewhat and the above does help quite a lot. > > > Feel free to add my: > > > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > > > Tested-by: Emil Velikov <emil.velikov@collabora.com> > > > > > Humble poke. > > > > Cannot see this patch in the drm-misc or drm-intel trees. Is there > > anything I do to help move it forward? > > Can you just respin the patch with this? > I've used your suggestion and redone the commit message completely. Hope it's far less cryptic now. Patch is on the ML - realised I didn't CC you, just as it went out. https://lore.kernel.org/dri-devel/20210604154905.660142-1-emil.l.velikov@gmail.com/T/#u Thanks -Emil ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device @ 2021-06-04 15:53 ` Emil Velikov 0 siblings, 0 replies; 21+ messages in thread From: Emil Velikov @ 2021-06-04 15:53 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Intel Graphics Development, kernel, ML dri-devel On Fri, 4 Jun 2021 at 15:08, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Fri, Jun 04, 2021 at 02:47:16PM +0100, Emil Velikov wrote: > > On Wed, 26 May 2021 at 17:21, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > > > > > Hi Ville, > > > > > > On Tue, 18 May 2021 at 12:17, Ville Syrjälä > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > > > > Hi Ville, > > > > > > > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > > > > <ville.syrjala@linux.intel.com> wrote: > > > > > > > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > > > > From: Vivek Das Mohapatra <vivek@collabora.com> > > > > > > > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > > > > bootloader → plymouth → desktop. > > > > > > > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > > > > (intel in this case), so the driver can issue some io(). > > > > > > > > > > > > I don't understand what this commit message is trying to say. > > > > > > > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > > > > the actual hardware setup where this occurs. > > > > > Does the following make sense? > > > > > > > > > > Currently on dual GPU systems, we do not get seamless handover as the > > > > > output flickers during the transition bootloader -> plymouth -> > > > > > desktop. > > > > > This happens as a result of switching (via the VGA arbiter) from the > > > > > "other" GPU back to the default i915 one and issuing io() commands. > > > > > > > > Hmm. Does this work? > > > > > > > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > > > > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > > > > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > > > > u8 sr1; > > > > > > > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > > > > + return; > > > > + > > > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > > > > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > > > > outb(SR01, VGA_SR_INDEX); > > > > > > > Was able to replicate the issue somewhat and the above does help quite a lot. > > > Feel free to add my: > > > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> > > > Tested-by: Emil Velikov <emil.velikov@collabora.com> > > > > > Humble poke. > > > > Cannot see this patch in the drm-misc or drm-intel trees. Is there > > anything I do to help move it forward? > > Can you just respin the patch with this? > I've used your suggestion and redone the commit message completely. Hope it's far less cryptic now. Patch is on the ML - realised I didn't CC you, just as it went out. https://lore.kernel.org/dri-devel/20210604154905.660142-1-emil.l.velikov@gmail.com/T/#u Thanks -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2021-06-04 15:53 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-16 17:14 [PATCH] drm/i915: only disable default vga device Emil Velikov 2021-05-16 17:14 ` [Intel-gfx] " Emil Velikov 2021-05-17 10:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-05-17 11:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-05-17 16:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-05-17 17:24 ` [PATCH] " Ville Syrjälä 2021-05-17 17:24 ` [Intel-gfx] " Ville Syrjälä 2021-05-18 11:09 ` Emil Velikov 2021-05-18 11:09 ` [Intel-gfx] " Emil Velikov 2021-05-18 11:17 ` Ville Syrjälä 2021-05-18 11:17 ` [Intel-gfx] " Ville Syrjälä 2021-05-18 12:39 ` Emil Velikov 2021-05-18 12:39 ` [Intel-gfx] " Emil Velikov 2021-05-26 16:21 ` Emil Velikov 2021-05-26 16:21 ` [Intel-gfx] " Emil Velikov 2021-06-04 13:47 ` Emil Velikov 2021-06-04 13:47 ` [Intel-gfx] " Emil Velikov 2021-06-04 14:08 ` Ville Syrjälä 2021-06-04 14:08 ` [Intel-gfx] " Ville Syrjälä 2021-06-04 15:53 ` Emil Velikov 2021-06-04 15:53 ` [Intel-gfx] " Emil Velikov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.