Re: [PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86/x86_64

From: Emil Velikov <emil.l.velikov@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>,
	Sean Paul <seanpaul@google.com>,
	Robert Foss <robert.foss@collabora.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Tomasz Figa <tfiga@google.com>,
	Marissa Wall <marissaw@google.com>,
	Dan Willemsen <dwillemsen@google.com>,
	Chad Versace <chad.versace@linux.intel.com>
Subject: Re: [PATCH] libdrm: intel/Android.mk: Filter libdrm_intel library requirements on x86/x86_64
Date: Wed, 14 Mar 2018 17:21:04 +0000	[thread overview]
Message-ID: <CACvgo51Kdjaotp6s6bcV+FG0JNLAUzD8Pm07y0eJM+Hixoa6Gw@mail.gmail.com> (raw)
In-Reply-To: <1521046056-10946-1-git-send-email-john.stultz@linaro.org>

On 14 March 2018 at 16:47, John Stultz <john.stultz@linaro.org> wrote:
> When building AOSP after updating libdrm project to the
> freedesktop/master branch, I've seen the following build errors:
>
> external/libdrm/intel/Android.mk: error: libdrm_intel
> (SHARED_LIBRARIES android-arm64) missing libpciaccess
> (SHARED_LIBRARIES android-arm64) You can set
> ALLOW_MISSING_DEPENDENCIES=true in your environment if this is
> intentional, but that may defer real problems until later in the
> build.
>
> Using ALLOW_MISSING_DEPENDENCIES=true when building allows
> things to function properly, but is not ideal.
>
> So basically, while I'm not including the libdrm_intel package
> into the build, just the fact that the Android.mk file references
> libpciaccess which isn't a repo included in AOSP causes the build
> failure.
>
> So it seems we need some sort of conditional filter in the
> Android.mk to skip over it if we're not building for intel.
>
Could swear I asked a few times already, but cannot see an answer.
Why/how does this happen - did you forget to set BOARD_GPU_DRIVERS?

One way to avoid this kind of clutches like is to have meta drivers
like "arm-all" or "x86-all".

Some examples:
 - the Mesa i965/anv drivers will not build for arm
 - the Mesa vc4 (even vc5?) driver has some perf. sensitive arm/thumb assembly
 - building the following combinations is waste of resources -
i915/i965/i915g on !x86, freedreno/etnaviv/imx on !arm

Without something like my earlier suggestion all of the above will
need to be special cased. And more are to come with time :-\

That is, unless I'm loosing my marbles. In which case don't be shy and
let me know, please.

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel