From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 961CBC54E8B for ; Tue, 12 May 2020 13:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 766A6206CC for ; Tue, 12 May 2020 13:04:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHo71XNf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729952AbgELNEF (ORCPT ); Tue, 12 May 2020 09:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725923AbgELNEE (ORCPT ); Tue, 12 May 2020 09:04:04 -0400 Received: from mail-vs1-xe42.google.com (mail-vs1-xe42.google.com [IPv6:2607:f8b0:4864:20::e42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D9F0C061A0C; Tue, 12 May 2020 06:04:04 -0700 (PDT) Received: by mail-vs1-xe42.google.com with SMTP id l25so7774518vso.6; Tue, 12 May 2020 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYYWk5B2Zk3TwldAUzCtTJK0glo/7kNcHTQydLAHm5E=; b=cHo71XNftzYCde+bfpfj3O5Me55d/CAF5uoY/3V6E4gXpR2DbAJUqHnB3U2PoAuPXf +jvSQcMEWbRTS89iqGm064nmezHp+7/wF5uH3tyUkSc4R5pkcDKPIYbrYDbNaQxOjKxj 2Xl32Yq45X+snmh1X8CFrneUQu61MsPP5TfmRhdCdlbhcPQ6ZfjEqVDuVwX73I5HcoJz arzItnlRTzilZiKhUB/QYi0gSGwCbjQ7vMkte8LXU113pdTcZ4UA3fS2Kz4LKUad4boU CqMIy+MiXQhYJI3/cVd4ve/e8vid87Xl86l0Xg8M0kLqwsXVK53thEdrIyKWZi/8X3ZU AvrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYYWk5B2Zk3TwldAUzCtTJK0glo/7kNcHTQydLAHm5E=; b=HMzdlE+SlXmcDRrRBr3AFghw4T/mt39zzVcn3G0+P4boMVpiQWNs7b1xkg7fC58oxq PRhUCe26YNQwNEIMdlKGpVtZ+nctqIkp8ghPTh72x0lRPY+tP6TNXFBZEvLV/F5nyjiS TlxuVZrNRxO5qAMbfx564O8/iLNjmxtSo8wUhyx0yG6R0I1pwUbR5wyn2fIZn+Plls+i PPLYvvtEeSygFgYa9PT8mcySsNFUc9tp0Pq1GLAPbV1Ww8LaQHYf5lQeHuTVCjCFW+JP vj54v6wcIT6RsomyJeRTZQvAybAzfr8XjEW6Jbgm/J/BC6drZ/BsI6Nm9enDfiQ0KHCV KvDg== X-Gm-Message-State: AGi0PuaIV8t9dWT34k1mRajBpqGkg4p+zgh1O4CLhhwCF2LsjH7LTHsj D8Zr6uKFFbq1vY22CWOXREcwj/HnzRouSEDKZ8Q= X-Google-Smtp-Source: APiQypJ4NEstWoq9lkMhuVta2nDgCif74eH1N9G3xJwYqz8c5+2f0vuiPACHvfsMZLwR/GXfTW7+fce+ImJb3qkLZhE= X-Received: by 2002:a67:c482:: with SMTP id d2mr16214320vsk.37.1589288643312; Tue, 12 May 2020 06:04:03 -0700 (PDT) MIME-Version: 1.0 References: <20200428141459.87624-1-weiyongjun1@huawei.com> In-Reply-To: From: Emil Velikov Date: Tue, 12 May 2020 14:01:24 +0100 Message-ID: Subject: Re: [PATCH -next] drm/mcde: dsi: Fix return value check in dev_err() To: Linus Walleij Cc: Wei Yongjun , David Airlie , kernel-janitors@vger.kernel.org, "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On Tue, 12 May 2020 at 12:49, Linus Walleij wrote: > > On Tue, Apr 28, 2020 at 4:13 PM Wei Yongjun wrote: > > > In case of error, the function of_drm_find_bridge() returns NULL pointer > > not ERR_PTR(). The IS_ERR() test in the return value check should be > > replaced with NULL test. > > > > Signed-off-by: Wei Yongjun > > Patch applied! Thanks Wei, sorry for the long delay. > It would be nice if of_drm_find_bridge and of_drm_find_panel were consistent - either return NULL or an ERR_PTR. Otherwise the next person using them is likely to get it wrong. -Emil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Date: Tue, 12 May 2020 13:01:24 +0000 Subject: Re: [PATCH -next] drm/mcde: dsi: Fix return value check in dev_err() Message-Id: List-Id: References: <20200428141459.87624-1-weiyongjun1@huawei.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Walleij Cc: David Airlie , kernel-janitors@vger.kernel.org, Wei Yongjun , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" Hi all, On Tue, 12 May 2020 at 12:49, Linus Walleij wrote: > > On Tue, Apr 28, 2020 at 4:13 PM Wei Yongjun wrote: > > > In case of error, the function of_drm_find_bridge() returns NULL pointer > > not ERR_PTR(). The IS_ERR() test in the return value check should be > > replaced with NULL test. > > > > Signed-off-by: Wei Yongjun > > Patch applied! Thanks Wei, sorry for the long delay. > It would be nice if of_drm_find_bridge and of_drm_find_panel were consistent - either return NULL or an ERR_PTR. Otherwise the next person using them is likely to get it wrong. -Emil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D5DC54E4A for ; Tue, 12 May 2020 13:04:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78FA1206CC for ; Tue, 12 May 2020 13:04:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHo71XNf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78FA1206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D93716E913; Tue, 12 May 2020 13:04:04 +0000 (UTC) Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 294B36E913 for ; Tue, 12 May 2020 13:04:04 +0000 (UTC) Received: by mail-vs1-xe41.google.com with SMTP id x136so7771754vsx.2 for ; Tue, 12 May 2020 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYYWk5B2Zk3TwldAUzCtTJK0glo/7kNcHTQydLAHm5E=; b=cHo71XNftzYCde+bfpfj3O5Me55d/CAF5uoY/3V6E4gXpR2DbAJUqHnB3U2PoAuPXf +jvSQcMEWbRTS89iqGm064nmezHp+7/wF5uH3tyUkSc4R5pkcDKPIYbrYDbNaQxOjKxj 2Xl32Yq45X+snmh1X8CFrneUQu61MsPP5TfmRhdCdlbhcPQ6ZfjEqVDuVwX73I5HcoJz arzItnlRTzilZiKhUB/QYi0gSGwCbjQ7vMkte8LXU113pdTcZ4UA3fS2Kz4LKUad4boU CqMIy+MiXQhYJI3/cVd4ve/e8vid87Xl86l0Xg8M0kLqwsXVK53thEdrIyKWZi/8X3ZU AvrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYYWk5B2Zk3TwldAUzCtTJK0glo/7kNcHTQydLAHm5E=; b=HF7amk9O8YW8tGbqQtLCYvnRd9gXX+pGqmZDYLnLDC0eQ4jawF1X5XQioRvqEp+wnY 6XLq6KIpy5ub+XDKYDWBES67YZkHxFNib8+PAM+D2xe6El0RzcxMDSQ+Fs/gQ6YepJNo cx2pgxZ3U22fU9AF3/5B7fcU/gcTMxpxn5LxHdpxFrB8Mdx1mhWl6kKg4KIEfFY6QRg8 +BRYR4ooVnY7MedC4F25s5c+s+mBfIlzvGZwk/s4lLLk8TjkGZHyCp3tyC2n55Oq10Qk xDfU+iwvG42wXa6UYCRo/adcCdFfciLS1dbHWdV3/Q37S5pJeIXRtwK80XSOZBFx8GEr Ay2Q== X-Gm-Message-State: AGi0PubJRyUs+xX3yRinI9fcqX+ZLZ6vZ4GWwPzjbqqwVdhET1Mp7iFv /EDf9FIaF6IIPxGJfgFDAKRxnPIGeyDkB7pxFI3o0fRY X-Google-Smtp-Source: APiQypJ4NEstWoq9lkMhuVta2nDgCif74eH1N9G3xJwYqz8c5+2f0vuiPACHvfsMZLwR/GXfTW7+fce+ImJb3qkLZhE= X-Received: by 2002:a67:c482:: with SMTP id d2mr16214320vsk.37.1589288643312; Tue, 12 May 2020 06:04:03 -0700 (PDT) MIME-Version: 1.0 References: <20200428141459.87624-1-weiyongjun1@huawei.com> In-Reply-To: From: Emil Velikov Date: Tue, 12 May 2020 14:01:24 +0100 Message-ID: Subject: Re: [PATCH -next] drm/mcde: dsi: Fix return value check in dev_err() To: Linus Walleij X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, Wei Yongjun , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi all, On Tue, 12 May 2020 at 12:49, Linus Walleij wrote: > > On Tue, Apr 28, 2020 at 4:13 PM Wei Yongjun wrote: > > > In case of error, the function of_drm_find_bridge() returns NULL pointer > > not ERR_PTR(). The IS_ERR() test in the return value check should be > > replaced with NULL test. > > > > Signed-off-by: Wei Yongjun > > Patch applied! Thanks Wei, sorry for the long delay. > It would be nice if of_drm_find_bridge and of_drm_find_panel were consistent - either return NULL or an ERR_PTR. Otherwise the next person using them is likely to get it wrong. -Emil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel